Anonymous | Login | Signup for a new account | 2025-06-18 01:14 UTC | ![]() |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0000801 | Zandronum | [All Projects] Bug | public | 2012-04-22 16:57 | 2018-09-30 19:52 | ||||
Reporter | unknownna | ||||||||
Assigned To | Dusk | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 98d | ||||||||
Target Version | Fixed in Version | 1.0 | |||||||
Summary | 0000801: MageWandSmoke actor not removed online | ||||||||
Description | Attached screenshot. | ||||||||
Additional Information | Actor DoomPlayer_02 : DoomPlayer | ||||||||
Attached Files | ![]() ![]() | ||||||||
![]() |
||||||
|
![]() |
|
Dusk (developer) 2012-04-23 14:28 |
Added proper network handling for MageWandSmoke. Effects applied to it should work properly online. In the process, MageWandSmoke now has +CLIENTSIDEONLY to prevent bandwidth hogging: 'https://bitbucket.org/CrimsonDusk/notebola/changeset/6777bafb17c3 [^]' I also moved shouldActorNotBeSpawned to network.cpp (and applied NETWORK_InClientMode) so that the mage wand smoke can use it. My reasoning for +CLIENTSIDEONLY for MageWandSmoke: since there was no synchronization of the smoke actors in the first place, any effects used on it did not work. Like A_FadeOut this ticket was created for. This means that you could never have such codepointers in the smoke and have it working online - and there was no bug reports about it until now. Therefore, adding +CLIENTSIDEONLY to the smoke should be safe. Leaving it out would cause a major bandwidth issue with Hexen, as the mage wand is a rather often used weapon and spawns a lot of these trail actors. |
Torr Samaho (administrator) 2012-04-25 02:07 edited on: 2012-04-25 12:18 |
You should be very, very hesitant when altering ZDoom's DECORATE code. Any mod that derives from MageWandSmoke may break if you make any alterations to the code. Something that is less likely to break here would be handle this similar to what A_CustomMissile is doing when the client spawns something on its own: If you are concerned about the bandwidth, let the client handling the spawning (like it already did since the code was not adapted for Skulltag's c/s approach) but give the actor the client spawned on its own the CLIENTSIDEONLY flag:
BTW: Why did you put the SERVERCOMMANDS_SpawnThing call in there? Since you added CLIENTSIDEONLY to the actor definition, the server will not spawn anything and this code will never be called. EDIT: I'm not really sure if we want to make this client side. Of course it works for vanilla Hexen, but we have to be aware that it will break mods that replace "MageWandSmoke" with something that's not purely for visual effects. Of course those mods never worked properly in Skulltag since AMageWandMissile::Effect didn't have any special c/s handling. |
Dusk (developer) 2012-04-30 01:24 |
I was assuming that actors deriving and replacing MageWandSmoke would be effects-only because of the nature of the code. Though, your approach is certainly a lot better... |
Torr Samaho (administrator) 2012-06-09 13:52 |
Since it won't make things worse than they already are I added the patch from 0000801:0003422. |
Watermelon (developer) 2012-08-02 13:49 |
Confirmed to work online, fadeout done properly, seems to be no apparent lag on my end. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
![]() |
|||
Date Modified | Username | Field | Change |
2012-04-22 16:57 | unknownna | New Issue | |
2012-04-22 16:57 | unknownna | File Added: magewandsmoke_01.wad | |
2012-04-22 16:57 | unknownna | Status | new => confirmed |
2012-04-22 16:57 | unknownna | Additional Information Updated | View Revisions |
2012-04-22 16:58 | unknownna | File Added: Screenshot_Doom_20120422_185449.png | |
2012-04-22 17:05 | unknownna | Relationship added | related to 0000240 |
2012-04-22 18:27 | Dusk | Assigned To | => Dusk |
2012-04-22 18:27 | Dusk | Status | confirmed => assigned |
2012-04-23 14:28 | Dusk | Note Added: 0003404 | |
2012-04-23 14:28 | Dusk | Status | assigned => needs review |
2012-04-25 02:07 | Torr Samaho | Note Added: 0003422 | |
2012-04-25 02:07 | Torr Samaho | Status | needs review => feedback |
2012-04-25 02:08 | Torr Samaho | Note Edited: 0003422 | View Revisions |
2012-04-25 02:08 | Torr Samaho | Note Revision Dropped: 3422: 0001833 | |
2012-04-25 12:15 | Torr Samaho | Note Edited: 0003422 | View Revisions |
2012-04-25 12:18 | Torr Samaho | Note Edited: 0003422 | View Revisions |
2012-04-30 01:24 | Dusk | Note Added: 0003503 | |
2012-05-13 23:59 | Dusk | Status | feedback => assigned |
2012-06-09 13:22 | Torr Samaho | Category | General => Bug |
2012-06-09 13:52 | Torr Samaho | Note Added: 0003708 | |
2012-06-09 13:52 | Torr Samaho | Status | assigned => needs testing |
2012-08-02 13:49 | Watermelon | Note Added: 0004197 | |
2012-08-02 19:10 | Torr Samaho | Status | needs testing => resolved |
2012-08-02 19:10 | Torr Samaho | Fixed in Version | => 1.0 |
2012-08-02 19:10 | Torr Samaho | Resolution | open => fixed |
2018-09-30 19:52 | Blzut3 | Status | resolved => closed |
Copyright © 2000 - 2025 MantisBT Team |