0003152: Backport RGF_NOSIGHT for A_RadiusGive

(0018043)
Konda (reporter)
2017-07-15 20:17

It would be nice if this was backported before 4.0. It's an essential tool for any kind of mod that wants to access all actors on the map and do something with them, like executing an ACS script that affects all weapons or monsters on the map.

(0018049)
Ivan (reporter)
2017-07-16 14:04

For a workaround, give all monsters a TID within a previously known range and iterate through them. That's going to be way faster than using A_RadiusGive because there won't be distance checks involved.

(0018052)
Konda (reporter)
2017-07-16 22:13

Ivan's solution relies on replacing all actors that would be otherwise affected by A_RadiusGive. The advantage of A_RadiusGive is that it gives you access to any actor, which enables support for actors introduced by another mod, and you have no control over other mods' actor definitions unless you create a patch mod that specifically targets mods on which to enable support.

(0018431)
Michaelis (reporter)
2017-10-04 13:13

Konda has outlined precisely the use for it.
Currently there's no way to change behavior of monsters that you don't provide yourself -- be it vanilla monsters or those present in a different mod loaded with yours.

If RGF_NOSIGHT was a thing, it would be possible to at least give them all a CustomInventory-based item that could do something in Pickup state, for example, launch an ACS script, that could do something else.
As an application example, I would use it to make a general damnums-like mod, making all monsters show damage dealt using floating numbers -- in a way compatible with vanilla, and any mods.

(0018899)
Polygon (reporter)
2017-11-20 08:41

I 100% STRONGLY Support backporting this in. Damage numbers is one thing but being able to do this can open up a whole world of new possibilities making modding even more dynamic!

(0020008)
Michaelis (reporter)
2018-10-08 10:21

RGF_NOSIGHT was originally introduced in'https://github.com/coelckers/gzdoom/commit/165d2887fd8bdab5e4f388c5db54e99c83e27488 [^]' , and then fixed in'https://github.com/coelckers/gzdoom/commit/31611c17d572e2aab109099d047e157fd51682cc [^]' .
This extension alone would grant great amount of modability to Zandronum. Before anonymous functions and ZScript were introduced, A_RadiusGive was the GZDoom's solution for two years to many problems currently unsolvable in Zandronum v3.0.

(0021284)
Torr Samaho (administrator)
2020-04-27 17:36

It turned out that this was easy to backport. I added this to the sanbox for testing:'https://bitbucket.org/zandronum/zandronum-sandbox-stable [^]'

(0021335)
Michaelis (reporter)
2020-05-11 12:05

"Rgftest.pk3" can be used to test implementation of A_RadiusGive flags against GZDoom.

With 3.1 beta build 200501-1847, it works and correctly counts players, monsters and barrels.
Projectiles, pickups and corpses are not counted because these flags are not yet backported.

(0023137)
Ru5tK1ng (updater)
2024-02-29 22:48

Closing based off this ^

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Michaelis dbthanatos Korshun DoodGuy EnsaladaDeTomate Konda TheMisterCat Decay Polygon eagle Marcaek mifu
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-06-07 05:31	Michaelis	New Issue
2017-06-07 05:31	Michaelis	File Added: rgf_nosight.wad
2017-07-15 20:17	Konda	Note Added: 0018043
2017-07-16 14:04	Ivan	Note Added: 0018049
2017-07-16 22:13	Konda	Note Added: 0018052
2017-10-04 13:13	Michaelis	Note Added: 0018431
2017-11-20 08:41	Polygon	Note Added: 0018899
2018-10-08 10:21	Michaelis	Note Added: 0020008
2020-04-27 17:36	Torr Samaho	Note Added: 0021284
2020-04-29 06:33	Torr Samaho	Assigned To	=> Torr Samaho
2020-04-29 06:33	Torr Samaho	Status	new => needs testing
2020-05-11 12:05	Michaelis	File Added: rgftest.pk3
2020-05-11 12:05	Michaelis	Note Added: 0021335
2024-02-29 22:48	Ru5tK1ng	Note Added: 0023137
2024-02-29 22:48	Ru5tK1ng	Status	needs testing => resolved
2024-02-29 22:48	Ru5tK1ng	Resolution	open => fixed

Notes
(0018043) Konda (reporter) 2017-07-15 20:17	It would be nice if this was backported before 4.0. It's an essential tool for any kind of mod that wants to access all actors on the map and do something with them, like executing an ACS script that affects all weapons or monsters on the map.

(0018049) Ivan (reporter) 2017-07-16 14:04	For a workaround, give all monsters a TID within a previously known range and iterate through them. That's going to be way faster than using A_RadiusGive because there won't be distance checks involved.

(0018052) Konda (reporter) 2017-07-16 22:13	Ivan's solution relies on replacing all actors that would be otherwise affected by A_RadiusGive. The advantage of A_RadiusGive is that it gives you access to any actor, which enables support for actors introduced by another mod, and you have no control over other mods' actor definitions unless you create a patch mod that specifically targets mods on which to enable support.

(0018431) Michaelis (reporter) 2017-10-04 13:13	Konda has outlined precisely the use for it. Currently there's no way to change behavior of monsters that you don't provide yourself -- be it vanilla monsters or those present in a different mod loaded with yours. If RGF_NOSIGHT was a thing, it would be possible to at least give them all a CustomInventory-based item that could do something in Pickup state, for example, launch an ACS script, that could do something else. As an application example, I would use it to make a general damnums-like mod, making all monsters show damage dealt using floating numbers -- in a way compatible with vanilla, and any mods.

(0018899) Polygon (reporter) 2017-11-20 08:41	I 100% STRONGLY Support backporting this in. Damage numbers is one thing but being able to do this can open up a whole world of new possibilities making modding even more dynamic!

(0020008) Michaelis (reporter) 2018-10-08 10:21	RGF_NOSIGHT was originally introduced in'https://github.com/coelckers/gzdoom/commit/165d2887fd8bdab5e4f388c5db54e99c83e27488 [^]' , and then fixed in'https://github.com/coelckers/gzdoom/commit/31611c17d572e2aab109099d047e157fd51682cc [^]' . This extension alone would grant great amount of modability to Zandronum. Before anonymous functions and ZScript were introduced, A_RadiusGive was the GZDoom's solution for two years to many problems currently unsolvable in Zandronum v3.0.

(0021284) Torr Samaho (administrator) 2020-04-27 17:36	It turned out that this was easy to backport. I added this to the sanbox for testing:'https://bitbucket.org/zandronum/zandronum-sandbox-stable [^]'

(0021335) Michaelis (reporter) 2020-05-11 12:05	"Rgftest.pk3" can be used to test implementation of A_RadiusGive flags against GZDoom. With 3.1 beta build 200501-1847, it works and correctly counts players, monsters and barrels. Projectiles, pickups and corpses are not counted because these flags are not yet backported.

(0023137) Ru5tK1ng (updater) 2024-02-29 22:48	Closing based off this ^

Relationships