0003034: Inventory drop should be excluded from sv_limitcommands

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003034

Zandronum

[All Projects] Suggestion

public

2017-03-11 09:38

2017-03-11 10:29

Reporter

Borg

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

2.1

Target Version

Fixed in Version

Summary

0003034: Inventory drop should be excluded from sv_limitcommands

Description

There is no point limiting inventory drop to one second. At least
not so aggresivly. If it needs to be limited, I would suggest to use
value around 100ms (3-4 game ticks).

Additional Information

void CLIENTCOMMANDS_RequestInventoryDrop( AInventory *pItem )
{
    if ( sv_limitcommands )
    {
        if ( !(GAMEMODE_GetFlags( GAMEMODE_GetCurrentMode( )) & GMF_COOPERATIVE) )
        {
            Printf( "Dropping is not allowed in non-cooperative game modes.\n" );
            return;
        }

        if (( g_ulLastDropTime > 0 ) && ( (ULONG)gametic < ( g_ulLastDropTime + ( TICRATE ))))
        {
            Printf( "You must wait at least one second before using drop again.\n" );
            return;
        }
    }

    if ( pItem == NULL )
        return;

    const USHORT usActorNetworkIndex = pItem->GetClass( )->getActorNetworkIndex();

    g_ulLastDropTime = gametic;

    NETWORK_WriteByte( &CLIENT_GetLocalBuffer( )->ByteStream, CLC_INVENTORYDROP );
    NETWORK_WriteShort( &CLIENT_GetLocalBuffer( )->ByteStream, usActorNetworkIndex );
}

Attached Files

Relationships

Notes
(0016965) Dusk (developer) 2017-03-11 10:29	I agree that it's too tight. We should put together a more flexible limiting setup so that you can for a short while use drop for more than once per second but not constantly.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2017-03-11 09:38	Borg	New Issue
2017-03-11 10:29	Dusk	Note Added: 0016965

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.