Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002736Zandronum[All Projects] Bugpublic2016-05-17 10:152018-09-30 22:00
ReporterWaTaKiD 
Assigned ToEdward-san 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002736: crash when exiting demo as idx 1
Descriptiondoes not crash when demo was recorded by a player with idx 0
does not crash in zan 2.1.2 or gzdoom 1.8.6
this commit is the culprit:'https://bitbucket.org/Torr_Samaho/zandronum/commits/4a7ea43b28eeeec226d44e93d8ee6834cc7d84fe [^]'
crash report using 3.0-r160510-1827 and example demo are attached
Steps To Reproduceeither play the attached demo (only doom2.wad is used) and exit it or:

host server: zandronum -iwad doom2 -host
connect client to use idx 0: zandronum -iwad doom2 -connect localhost
connect client to use idx 1 and record a demo: zandronum -iwad doom2 -connect localhost -record democrash.cld
wait a few seconds then exit and play the demo: zandronum -iwad doom2 -playdemo democrash.cld
exit the demo
crash
Attached Files? file icon democrash.cld [^] (6,026 bytes) 2016-05-17 10:15
zip file icon CrashReport-democrash.zip [^] (23,074 bytes) 2016-05-17 10:15

- Relationships

-  Notes
User avatar (0015075)
Edward-san (developer)
2016-06-12 18:33

 I finally found the problem:


    // In a client demo, don't lose the userinfo we gave to our console player.
    if ( CLIENTDEMO_IsPlaying( ))
        memcpy( &players[lConsolePlayer].userinfo, &players[consoleplayer].userinfo, sizeof( userinfo_t ));
User avatar (0015076)
Edward-san (developer)
2016-06-12 18:35

 Please check that'https://bitbucket.org/zandronum/zandronum-sandbox/commits/28f0abbdc9e6a66515c25d9ae091e19ef5841bc8 [^]' fixes the issue and the demo doesn't break with it.
User avatar (0015077)
WaTaKiD (updater)
2016-06-13 00:28

 this 3.0 build contains the above commit:'https://www.dropbox.com/s/vtbk4k2ddvnadjc/zandronum-3.0-r160612-1819-28f0abb-windows.zip?dl=0 [^]'

following the steps to reproduce, i was unable to crash

i also recorded a demo as idx 0 and exited before and after a client with idx 1 connected, just in case, and no crash

i even watched the demo (a quick playthrough of doom2 map01) and didnt notice anything wrong
User avatar (0015096)
Edward-san (developer)
2016-06-18 21:56
edited on: 2016-06-18 23:07

 I had to transplant the changes to latest upstream, because of code conflicts:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/109/non-0-idx-demo-crash-fix/diff [^]' .

[edit] if you want to test this, you need to create a new demo, because of the net protocol changes.
User avatar (0015102)
Edward-san (developer)
2016-06-20 19:12

 Added in zandronum 3.0 upstream with this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/73b0376a61cb [^]' .
User avatar (0015186)
WaTaKiD (updater)
2016-07-02 17:16
edited on: 2016-07-02 17:38

 using'https://www.dropbox.com/s/47tfog9di3lorlg/zandronum-3.0-r160702-1232-b244a48-windows.zip?dl=0 [^]' seems to be worse

when i try to play a demo created by the client with idx 1, it errors with "svcc_authenticate: unknown map: 1"

when i try to play a demo created by a client with idx 0, its fine up until my 2nd client connects, then i get the same error

note that these are newly recorded demos using this build

edit: oops, this is not caused by'https://bitbucket.org/Torr_Samaho/zandronum/commits/73b0376a61cb46715ef817f82f8223eb50c7b8fe [^]'

ill make a new note once i find the commit responsible
User avatar (0015191)
WaTaKiD (updater)
2016-07-02 18:48

 ive found this commit to be the cause:'https://bitbucket.org/Torr_Samaho/zandronum/commits/b6a26f4055d644c2bb2c00343059cdab8b7be391 [^]'
User avatar (0015206)
Torr Samaho (administrator)
2016-07-03 15:37

 The new issue should be fixed now.
User avatar (0015209)
WaTaKiD (updater)
2016-07-03 16:47

 using'https://www.dropbox.com/s/m41j6cif9hbee2k/zandronum-3.0-r160703-1614-e8e72e3-windows.zip?dl=0 [^]' i no longer get any crashes or errors when exiting demos, regardless if recorded by idx 0 or 1
User avatar (0015424)
Edward-san (developer)
2016-08-10 09:58

 It has been added to 3.0 upstream for some time:'https://bitbucket.org/Torr_Samaho/zandronum/commits/73b0376a61cb [^]'
User avatar (0015467)
Ru5tK1ng (updater)
2016-08-18 00:56

 Is this fix in 3.0-160814? If so, Zandro crashed when I tried playing the test demo.
User avatar (0015476)
Edward-san (developer)
2016-08-18 09:07

 Try recording a new demo and play that one.
User avatar (0015489)
Ru5tK1ng (updater)
2016-08-18 14:58

 I went ahead and made new demos as both idx 0 and 1. When playing back the demos, there was no crash.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-05-17 10:15 WaTaKiD New Issue
2016-05-17 10:15 WaTaKiD File Added: democrash.cld
2016-05-17 10:15 WaTaKiD File Added: CrashReport-democrash.zip
2016-05-17 19:48 Torr Samaho Target Version => 3.0
2016-06-12 18:33 Edward-san Note Added: 0015075
2016-06-12 18:33 Edward-san Assigned To => Edward-san
2016-06-12 18:33 Edward-san Status new => assigned
2016-06-12 18:35 Edward-san Note Added: 0015076
2016-06-12 18:35 Edward-san Status assigned => feedback
2016-06-13 00:28 WaTaKiD Note Added: 0015077
2016-06-13 00:28 WaTaKiD Status feedback => assigned
2016-06-18 21:56 Edward-san Note Added: 0015096
2016-06-18 21:57 Edward-san Status assigned => needs review
2016-06-18 23:07 Edward-san Note Edited: 0015096 View Revisions
2016-06-20 19:12 Edward-san Note Added: 0015102
2016-06-20 19:12 Edward-san Status needs review => needs testing
2016-07-02 17:16 WaTaKiD Note Added: 0015186
2016-07-02 17:17 WaTaKiD Status needs testing => assigned
2016-07-02 17:38 WaTaKiD Note Edited: 0015186 View Revisions
2016-07-02 18:48 WaTaKiD Note Added: 0015191
2016-07-03 15:37 Torr Samaho Note Added: 0015206
2016-07-03 16:47 WaTaKiD Note Added: 0015209
2016-08-10 09:58 Edward-san Note Added: 0015424
2016-08-10 09:58 Edward-san Status assigned => needs testing
2016-08-18 00:56 Ru5tK1ng Note Added: 0015467
2016-08-18 09:07 Edward-san Note Added: 0015476
2016-08-18 14:58 Ru5tK1ng Note Added: 0015489
2016-08-18 14:58 Ru5tK1ng Status needs testing => resolved
2016-08-18 14:58 Ru5tK1ng Resolution open => fixed
2016-08-18 14:58 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 22:00 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker