0002421: Player doesn't get "Secret discovered" message when secret was already discovered by someone else.

(0013306)
Edward-san (developer)
2015-08-29 10:29

I suspect it's caused by the fix for ticket 0002363 . Can someone confirm this?

(0013309)
Unknown (reporter)
2015-08-29 11:53

It would be better if secrets are announced to global if someone finds them, so other players don't have to find it (unless they want to) .

(0013310)
Zalewa (developer)
2015-08-29 12:51

Unknown: how do you suggest this should be solved then? Players getting "a secret is releaved" message out of the blue would be confused whether it's they who did this or not. I also don't see the point of displaying such message for a player who didn't actually discover anything.

(0013313)
Torr Samaho (administrator)
2015-08-29 18:43

Is 3.0's behavior differing from ZDoom's multiplayer behavior in this regard?

(0013316)
Zalewa (developer)
2015-08-29 20:51

Which ZDoom build should I test?

(0013317)
Edward-san (developer)
2015-08-29 20:52
edited on: 2015-08-30 15:04

It seems to happen in zdoom git commit 458e1b1b (code base for 3.0) and got the same result, but the same happens also in zdoom r2560 (code base for 2.0), so I'd say we always handled the secret differently from zdoom before 3.0...

Steps to reproduce:

host with: zdoom -iwad doom2.wad -host 2 -warp 01 -skill 4 -nomonsters
connect a second player with: zdoom -iwad doom2.wad -join localhost

make one player discover a secret (for example the one before the exit), then the other player won't be able to 'reveal' the secret.

[edit] I can reproduce it on zdoom git head as well, if it may interest..

(0013320)
Unknown (reporter)
2015-08-29 23:58
edited on: 2015-08-30 00:08

Zalewa : The secret should count of course (for all players) at scoreboard or idk, it's another cooperative basic (finding secrets together you know ...) , Of course once notified that secret is found, Other players don't have to look for it or get "Secret Revealed" .

(0013321)
Empyre (reporter)
2015-08-30 03:01

If a found secret is shared with everybody, would it be highlighted on everybody's automap?

(0013324)
Unknown (reporter)
2015-08-30 11:44

I Think so .

(0013325)
Leonard (developer)
2015-08-30 12:02
edited on: 2015-08-30 12:04

While I agree a "global" secret count could be useful, I think that the "a secret is releaved" message should stay local because as Zalewa pointed out it simply doesn't make sense and is confusing to get it out of the blue when you actually did nothing.

I would also like to point out that I do play survival regularly and once people have finished a map most of the time they like to look around for the remaining items to do a "refill" and the local secret count usually comes in handy as you actually know what you have to look for.

(0013331)
Torr Samaho (administrator)
2015-08-30 16:23

Before changing anything, we first need to agree on what the correct behavior is supposed to be. Is ZDoom, Zandronum 2.x or neither of them correct? If ZDoom is not correct, the problem should be first reported there.

(0013334)
Ivan (reporter)
2015-08-30 19:00
edited on: 2015-08-30 19:00

Is it too much effort to give the shared keys treatment to the secrets and go a different way from both Zdoom and Zandronum 2.x? Like "X has found a secret!" that gets globally announced if there is more than 1 player present. Otherwise, it'd use the normal "You've found a secret" behavior.

(0013335)
Zalewa (developer)
2015-08-30 20:09

I think it's pointless and distracting to be informed of somebody else finding a secret.

(0013337)
Ivan (reporter)
2015-08-30 22:12

It's probably better than not being notified of it at all. Besides, it can be moved to the chat zone instead of middle of screen. Or can be given an actual flag to toggle this behavior. I'd very much like this to happen personally. It'd especially help if someone found a secret with things that don't respawn so I don't waste time waiting there.

(0013338)
Zalewa (developer)
2015-08-30 22:20

Chat zone info might not be a bad idea after all. I just don't want a yelling message popping up out of nowhere in the middle of the screen when I'm trying to navigate around monster attacks in survival. And please, no more optional settings. This game has too many settings already.

(0013339)
Edward-san (developer)
2015-08-31 07:07

Quote from Torr Samaho
Before changing anything, we first need to agree on what the correct behavior is supposed to be. Is ZDoom, Zandronum 2.x or neither of them correct? If ZDoom is not correct, the problem should be first reported there.

ZDoom's behavior is correct, according to this thread.

(0013340)
Empyre (reporter)
2015-08-31 16:33

Even though it differs from vanilla behavior, I think that players intuitively expect to be able to discover secrets even if another player has already discovered it. I do like the idea of a Shared Secrets setting similar to the Shared Keys setting. It it is turned on, then everybody would see an announcement that so-and-so has found a secret, and that secret would be revealed on everybody's map. The default setting would be off.

(0016522)
Zalewa (developer)
2016-12-18 16:11
edited on: 2016-12-18 16:14

Indirectly fixed by this pull request:
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/178/fixed-problems-with-secrets-clientside/ [^]'

In multiplayer, players will be informed through the chat area about the secret being discovered by a player.

(0016592)
Zalewa (developer)
2017-01-02 22:30

I did the "shared secret" message thing, played some coop with it a bit and decided that it's too distracting to be justified. I updated my PR with the removal of the message.'https://bitbucket.org/zalewa/zandronum/commits/22edf6db3ebf84cd8b45f99cdca577552d96fa12?at=default [^]'

(0017735)
Torr Samaho (administrator)
2017-05-21 19:19

I added your patch.

(0017748)
Ru5tK1ng (updater)
2017-05-23 02:29

Since the other fixes related to secrets seem to be working and updating properly, I'll mark this as resolved since the global message was removed and you only see the secret revealed message if you find a secret or coopspy one.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Leonard
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-08-29 08:41	Zalewa	New Issue
2015-08-29 10:29	Edward-san	Note Added: 0013306
2015-08-29 11:53	Unknown	Note Added: 0013309
2015-08-29 12:51	Zalewa	Note Added: 0013310
2015-08-29 18:43	Torr Samaho	Note Added: 0013313
2015-08-29 20:51	Zalewa	Note Added: 0013316
2015-08-29 20:52	Edward-san	Note Added: 0013317
2015-08-29 20:53	Edward-san	Note Edited: 0013317	View Revisions
2015-08-29 20:53	Edward-san	Note Edited: 0013317	View Revisions
2015-08-29 23:58	Unknown	Note Added: 0013320
2015-08-30 00:07	Unknown	Note Edited: 0013320	View Revisions
2015-08-30 00:08	Unknown	Note Edited: 0013320	View Revisions
2015-08-30 03:01	Empyre	Note Added: 0013321
2015-08-30 11:44	Unknown	Note Added: 0013324
2015-08-30 12:02	Leonard	Note Added: 0013325
2015-08-30 12:04	Leonard	Note Edited: 0013325	View Revisions
2015-08-30 15:04	Edward-san	Note Edited: 0013317	View Revisions
2015-08-30 16:23	Torr Samaho	Note Added: 0013331
2015-08-30 19:00	Ivan	Note Added: 0013334
2015-08-30 19:00	Ivan	Note Edited: 0013334	View Revisions
2015-08-30 20:09	Zalewa	Note Added: 0013335
2015-08-30 22:12	Ivan	Note Added: 0013337
2015-08-30 22:20	Zalewa	Note Added: 0013338
2015-08-31 07:07	Edward-san	Note Added: 0013339
2015-08-31 16:33	Empyre	Note Added: 0013340
2016-11-20 21:37	Edward-san	Product Version	3.0 => 3.0-beta
2016-12-18 13:22	Zalewa	Relationship added	related to 0002425
2016-12-18 13:22	Zalewa	Relationship added	related to 0002424
2016-12-18 13:22	Zalewa	Relationship added	related to 0002422
2016-12-18 14:53	Zalewa	Assigned To	=> Zalewa
2016-12-18 14:53	Zalewa	Status	new => assigned
2016-12-18 16:11	Zalewa	Note Added: 0016522
2016-12-18 16:11	Zalewa	Status	assigned => needs review
2016-12-18 16:14	Zalewa	Note Edited: 0016522	View Revisions
2016-12-24 22:41	Dusk	Target Version	=> 3.0
2017-01-02 22:30	Zalewa	Note Added: 0016592
2017-05-21 19:19	Torr Samaho	Note Added: 0017735
2017-05-21 19:19	Torr Samaho	Status	needs review => needs testing
2017-05-23 02:29	Ru5tK1ng	Note Added: 0017748
2017-05-23 02:29	Ru5tK1ng	Status	needs testing => resolved
2017-05-23 02:29	Ru5tK1ng	Resolution	open => fixed
2017-05-23 02:29	Ru5tK1ng	Fixed in Version	=> 3.0
2018-09-30 21:44	Blzut3	Status	resolved => closed

Notes
(0013306) Edward-san (developer) 2015-08-29 10:29	I suspect it's caused by the fix for ticket 0002363 . Can someone confirm this?

(0013309) Unknown (reporter) 2015-08-29 11:53	It would be better if secrets are announced to global if someone finds them, so other players don't have to find it (unless they want to) .

(0013310) Zalewa (developer) 2015-08-29 12:51	Unknown: how do you suggest this should be solved then? Players getting "a secret is releaved" message out of the blue would be confused whether it's they who did this or not. I also don't see the point of displaying such message for a player who didn't actually discover anything.

(0013313) Torr Samaho (administrator) 2015-08-29 18:43	Is 3.0's behavior differing from ZDoom's multiplayer behavior in this regard?

(0013316) Zalewa (developer) 2015-08-29 20:51	Which ZDoom build should I test?

(0013317) Edward-san (developer) 2015-08-29 20:52 edited on: 2015-08-30 15:04	It seems to happen in zdoom git commit 458e1b1b (code base for 3.0) and got the same result, but the same happens also in zdoom r2560 (code base for 2.0), so I'd say we always handled the secret differently from zdoom before 3.0... Steps to reproduce: host with: zdoom -iwad doom2.wad -host 2 -warp 01 -skill 4 -nomonsters connect a second player with: zdoom -iwad doom2.wad -join localhost make one player discover a secret (for example the one before the exit), then the other player won't be able to 'reveal' the secret. [edit] I can reproduce it on zdoom git head as well, if it may interest..

(0013320) Unknown (reporter) 2015-08-29 23:58 edited on: 2015-08-30 00:08	Zalewa : The secret should count of course (for all players) at scoreboard or idk, it's another cooperative basic (finding secrets together you know ...) , Of course once notified that secret is found, Other players don't have to look for it or get "Secret Revealed" .

(0013321) Empyre (reporter) 2015-08-30 03:01	If a found secret is shared with everybody, would it be highlighted on everybody's automap?

(0013324) Unknown (reporter) 2015-08-30 11:44	I Think so .

(0013325) Leonard (developer) 2015-08-30 12:02 edited on: 2015-08-30 12:04	While I agree a "global" secret count could be useful, I think that the "a secret is releaved" message should stay local because as Zalewa pointed out it simply doesn't make sense and is confusing to get it out of the blue when you actually did nothing. I would also like to point out that I do play survival regularly and once people have finished a map most of the time they like to look around for the remaining items to do a "refill" and the local secret count usually comes in handy as you actually know what you have to look for.

(0013331) Torr Samaho (administrator) 2015-08-30 16:23	Before changing anything, we first need to agree on what the correct behavior is supposed to be. Is ZDoom, Zandronum 2.x or neither of them correct? If ZDoom is not correct, the problem should be first reported there.

(0013334) Ivan (reporter) 2015-08-30 19:00 edited on: 2015-08-30 19:00	Is it too much effort to give the shared keys treatment to the secrets and go a different way from both Zdoom and Zandronum 2.x? Like "X has found a secret!" that gets globally announced if there is more than 1 player present. Otherwise, it'd use the normal "You've found a secret" behavior.

(0013335) Zalewa (developer) 2015-08-30 20:09	I think it's pointless and distracting to be informed of somebody else finding a secret.

(0013337) Ivan (reporter) 2015-08-30 22:12	It's probably better than not being notified of it at all. Besides, it can be moved to the chat zone instead of middle of screen. Or can be given an actual flag to toggle this behavior. I'd very much like this to happen personally. It'd especially help if someone found a secret with things that don't respawn so I don't waste time waiting there.

(0013338) Zalewa (developer) 2015-08-30 22:20	Chat zone info might not be a bad idea after all. I just don't want a yelling message popping up out of nowhere in the middle of the screen when I'm trying to navigate around monster attacks in survival. And please, no more optional settings. This game has too many settings already.

(0013339) Edward-san (developer) 2015-08-31 07:07	Quote from Torr Samaho Before changing anything, we first need to agree on what the correct behavior is supposed to be. Is ZDoom, Zandronum 2.x or neither of them correct? If ZDoom is not correct, the problem should be first reported there. ZDoom's behavior is correct, according to this thread.

(0013340) Empyre (reporter) 2015-08-31 16:33	Even though it differs from vanilla behavior, I think that players intuitively expect to be able to discover secrets even if another player has already discovered it. I do like the idea of a Shared Secrets setting similar to the Shared Keys setting. It it is turned on, then everybody would see an announcement that so-and-so has found a secret, and that secret would be revealed on everybody's map. The default setting would be off.

(0016522) Zalewa (developer) 2016-12-18 16:11 edited on: 2016-12-18 16:14	Indirectly fixed by this pull request: 'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/178/fixed-problems-with-secrets-clientside/ [^]' In multiplayer, players will be informed through the chat area about the secret being discovered by a player.

(0016592) Zalewa (developer) 2017-01-02 22:30	I did the "shared secret" message thing, played some coop with it a bit and decided that it's too distracting to be justified. I updated my PR with the removal of the message.'https://bitbucket.org/zalewa/zandronum/commits/22edf6db3ebf84cd8b45f99cdca577552d96fa12?at=default [^]'

(0017735) Torr Samaho (administrator) 2017-05-21 19:19	I added your patch.

(0017748) Ru5tK1ng (updater) 2017-05-23 02:29	Since the other fixes related to secrets seem to be working and updating properly, I'll mark this as resolved since the global message was removed and you only see the secret revealed message if you find a secret or coopspy one.