Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002082Zandronum[All Projects] Bugpublic2015-01-25 11:182018-09-30 21:38
ReporterZalewa 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version2.1Fixed in Version2.1 
Summary0002082: .deh files are not reported by the server if they're loaded with -deh.
DescriptionTo load a .deh file you need to use '-deh' argument. However, the .deh file loaded in such way is not reported by the server, so the server browser don't know that it needs to load it too when launching the client. .deh file is reported properly when loaded with '-file', but in such case its contents aren't really loaded by the game at all.
Attached Files

- Relationships
related to 0002081closedZalewa Doomseeker .deh/.bex files may need to be loaded with different cmd line args depending on game 

-  Notes
User avatar (0011937)
Dusk (developer)
2015-03-30 15:09

 Added a new query flag to get the deh patches.
User avatar (0011938)
Zalewa (developer)
2015-03-30 16:05

 Awesome.
User avatar (0012005)
Torr Samaho (administrator)
2015-04-03 15:16
edited on: 2015-04-03 15:21

 Looks fine. Just two minor comments:

- Any particular reason why you implemented the same thing for SQF_OPTIONAL_WADS and SQF_DEH quite differently, i.e.

    // [TP] Optional wads
    if ( ulFlags & SQF_OPTIONAL_WADS )
    {
        int numIndices = NETWORK_ReadByte( pByteStream );

        while ( numIndices-- )
            NETWORK_ReadByte( pByteStream );
    }

vs.

    // [TP] Dehacked patches
    if ( ulFlags & SQF_DEH )
    {
        for ( int i = NETWORK_ReadByte( pByteStream ); i > 0; --i )
            NETWORK_ReadString( pByteStream );
    }

? Both code snippets are perfectly fine, it's just a little strange to see the very same thing being implemented differently, even though the code snippets are right after each other in the source and were implemented by the same person ;).

- SQF_OPTIONAL_WADS has

    // [TP] Don't send optional wads if there isn't any.
    if ( g_OptionalWadIndices.Size() == 0 )
        ulBits &= ~SQF_OPTIONAL_WADS;

SQF_DEH doesn't do this. Wouldn't it be nicer to have the two things behave consistently?

EDIT: Tiny thing: The history entry has "-" and "+" switched, but I can easily correct this locally.
User avatar (0012009)
Dusk (developer)
2015-04-03 18:53
edited on: 2015-04-03 18:55
Quote
Any particular reason why you implemented the same thing for SQF_OPTIONAL_WADS and SQF_DEH quite differently

Because somebody said I'm not supposed to change unrelated code in patches. :p
TBH I didn't even notice this.

Quote
SQF_OPTIONAL_WADS has <code> SQF_DEH doesn't do this. Wouldn't it be nicer to have the two things behave consistently?

That's a minor oversight indeed. I'll fix this.
User avatar (0012170)
Dusk (developer)
2015-04-25 16:35

 'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/134 [^]'
User avatar (0012353)
cobalt (updater)
2015-05-24 11:12

 Issue addressed by commit b2846a443687: - added query flag SQF_DEH to allow server browsers to query any dehacked patches loaded by the server (addresses 2082)
Committed by Teemu Piippo [Dusk] on Saturday 25 April 2015 19:08:05

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/browser.cpp | 11 ++++++++---
 src/d_dehacked.cpp | 19 ++++++++++++++++++-
 src/d_dehacked.h | 3 +++
 src/sv_main.h | 3 ++-
 src/sv_master.cpp | 15 +++++++++++++++
 6 files changed, 47 insertions(+), 5 deletions(-)

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-01-25 11:18 Zalewa New Issue
2015-01-25 11:21 Zalewa Relationship added related to 0002081
2015-03-29 19:08 Dusk Target Version => 2.1
2015-03-30 13:54 Dusk Assigned To => Dusk
2015-03-30 13:54 Dusk Status new => assigned
2015-03-30 15:09 Dusk Note Added: 0011937
2015-03-30 15:11 Dusk Status assigned => needs review
2015-03-30 16:05 Zalewa Note Added: 0011938
2015-04-03 15:16 Torr Samaho Note Added: 0012005
2015-04-03 15:16 Torr Samaho Status needs review => feedback
2015-04-03 15:21 Torr Samaho Note Edited: 0012005 View Revisions
2015-04-03 18:53 Dusk Note Added: 0012009
2015-04-03 18:53 Dusk Status feedback => assigned
2015-04-03 18:55 Dusk Note Edited: 0012009 View Revisions
2015-04-25 16:35 Dusk Note Added: 0012170
2015-04-25 16:35 Dusk Status assigned => needs review
2015-05-24 11:12 cobalt Status needs review => needs testing
2015-05-24 11:12 cobalt Note Added: 0012353
2015-06-24 22:46 Dusk Status needs testing => resolved
2015-06-24 22:46 Dusk Fixed in Version => 2.2
2015-06-24 22:46 Dusk Resolution open => fixed
2015-06-24 22:47 Dusk Fixed in Version 2.2 => 2.1
2018-09-30 21:38 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker