Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000165Zandronum[All Projects] Bugpublic2010-11-03 02:232018-09-30 22:33
Reporterunknownna 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version 
Summary0000165: The "team" command isn't disabled if "sv_noteamselect" is 1
DescriptionYou can still select which team you wish to join if sv_noteamselect is 1.
Steps To Reproduce1. skulltag.exe -host +teamplay 1 +sv_noteamselect 1
2. Connect a client to the server.
3. "team blue" in the console.
Attached Files

- Relationships

-  Notes
User avatar (0003494)
TIHan (reporter)
2012-04-29 19:10

Fixed.
'https://bitbucket.org/TIHan/tst/changeset/980084fd8a1f [^]'
User avatar (0003498)
Torr Samaho (administrator)
2012-04-30 00:01

Patch added.
User avatar (0003526)
unknownna (updater)
2012-05-01 10:12
edited on: 2012-05-01 10:14

It seems to have fixed the issue, but the "changeteam" message for spectators is now changed. It used to be "You can only toggle your team if you are on a team.". Now it is "You are not allowed to choose your team!".

User avatar (0003539)
TIHan (reporter)
2012-05-01 13:38

> Now it is "You are not allowed to choose your team!".

Anything wrong with that? The purpose of the flag itself is to not allow the spectator to choose his/her team.
User avatar (0003541)
unknownna (updater)
2012-05-01 15:00
edited on: 2012-05-01 15:04

Quote from Torr Samaho
Quote from unknownna
Quote from Torr Samaho
Quote from unknownna
Quote from Torr Samaho
Quote from unknownna
but I'm not put in the queue with the changeteam command

"changeteam teamname" work fine for me. changeteam without argument is supposed to put you on the next team, i.e. if you are on team one you are put on team two and so forth. In particular, it always puts you on the other team, if there are only two teams.

I see. I only used "changeteam".

If you are not on a team, there is no "next" or "other" team, so the command simply does nothing in this case. If you think that this behavior is unexpected, I can add a message that tells the spectator that it can't toggle its team without being on a team.

That'd be nice.

Done.


User avatar (0003542)
TIHan (reporter)
2012-05-01 15:48

The purpose of sv_noteamselect as I said before was to not allow the spectator to choose his/her team. I don't see how this is related to toggling your team.
User avatar (0003557)
unknownna (updater)
2012-05-02 09:33

We need 2 messages for spectators when they use the changeteam command, one when using "changeteam teamname" and one when using "changeteam" without any arguments.

The new message, i.e., "You are not allowed to choose your team!", should be displayed when using "changeteam teamname".
The old 98e message, i.e., You can only toggle your team if you are on a team.", should be displayed when using "changeteam".
User avatar (0003558)
TIHan (reporter)
2012-05-02 14:21

You should get "You can only toggle your team if you are on a team.", should be displayed when using "changeteam" if you have sv_noteamselect set to 0. IMO, I don't see a problem with displaying "You are not allowed to choose your team!" message to appear instead when using sv_noteamselect to set 1.
User avatar (0003559)
unknownna (updater)
2012-05-02 16:54
edited on: 2012-05-02 16:55

I think it should work like this when you're a spectator:

sv_noteamselect 0

changeteam = You can only toggle your team if you are on a team.
changeteam teamname = Playername joined the teamname team.
team = Playername joined the teamname team.

sv_noteamselect 1

changeteam = You can only toggle your team if you are on a team.
changeteam teamname = You are not allowed to change/choose your team!
team = You are not allowed to choose your team!

What do you think, Torr?

User avatar (0003560)
TIHan (reporter)
2012-05-02 17:22

I see your point, but TBH this would require some work due to the logic behind these messages. In the end, I don't see us getting any benefit out of it other than more work. The functionality would still be the same, and the message is fine anyway.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: ZzZombo
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2010-11-03 02:23 unknownna New Issue
2010-11-03 02:34 unknownna Note Added: 0000536
2010-11-03 02:36 unknownna Note Edited: 0000536 View Revisions
2012-04-20 08:24 unknownna Note Deleted: 0000536
2012-04-20 08:37 unknownna Severity major => minor
2012-04-20 08:37 unknownna Reproducibility N/A => always
2012-04-20 08:37 unknownna Status new => confirmed
2012-04-20 08:37 unknownna Category Suggestion => Bugs
2012-04-20 08:37 unknownna Product Version => 98d
2012-04-20 08:37 unknownna Summary disable "team" command if "sv_noteamselect" is set to true || make "join" print "<name> joined the <team> team." in team modes => The "team" command isn't disabled if "sv_noteamselect" is 1
2012-04-20 08:37 unknownna Description Updated View Revisions
2012-04-20 08:37 unknownna Steps to Reproduce Updated View Revisions
2012-04-20 08:37 unknownna Additional Information Updated View Revisions
2012-04-29 02:03 TIHan Assigned To => TIHan
2012-04-29 02:03 TIHan Status confirmed => assigned
2012-04-29 19:10 TIHan Note Added: 0003494
2012-04-29 19:10 TIHan Status assigned => needs review
2012-04-30 00:01 Torr Samaho Note Added: 0003498
2012-04-30 00:02 Torr Samaho Status needs review => feedback
2012-04-30 00:02 Torr Samaho Status feedback => assigned
2012-05-01 10:12 unknownna Note Added: 0003526
2012-05-01 10:14 unknownna Note Edited: 0003526 View Revisions
2012-05-01 13:38 TIHan Note Added: 0003539
2012-05-01 15:00 unknownna Note Added: 0003541
2012-05-01 15:04 unknownna Note Edited: 0003541 View Revisions
2012-05-01 15:48 TIHan Note Added: 0003542
2012-05-02 09:33 unknownna Note Added: 0003557
2012-05-02 14:21 TIHan Note Added: 0003558
2012-05-02 16:54 unknownna Note Added: 0003559
2012-05-02 16:55 unknownna Note Edited: 0003559 View Revisions
2012-05-02 17:22 TIHan Note Added: 0003560
2012-06-09 13:22 Torr Samaho Category General => Bug
2017-05-20 02:27 Ru5tK1ng Assigned To TIHan =>
2017-05-20 02:27 Ru5tK1ng Status assigned => resolved
2017-05-20 02:27 Ru5tK1ng Resolution open => fixed
2018-09-30 22:33 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker