Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001410Zandronum[All Projects] Bugpublic2013-07-17 22:222018-09-30 21:33
ReporterWatermelon 
Assigned ToDusk 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1 
Target Version1.1.1Fixed in Version1.1.1 
Summary0001410: Teamchat can be heard by the other team
DescriptionAs the topic says, Blue can see Red's team chat...etc
Attached Filesdiff file icon teamchat.diff [^] (647 bytes) 2013-07-17 22:37 [Show Content]

- Relationships

-  Notes
User avatar (0006687)
Dusk (developer)
2013-07-17 22:37

 fixedddddddddddddddddd

o/
User avatar (0006690)
Edward-san (developer)
2013-07-17 22:50

 Just saying, it was broken starting from changeset db11a4687ab3.
User avatar (0006695)
Torr Samaho (administrator)
2013-07-18 07:04
edited on: 2013-07-18 07:08

 From what I can tell your patch break may break team chat for spectators if the spectators were on different teams before.

From the top of my head I'd say

( PLAYER_IsTrueSpectator ( &players[ulIdx] ) != PLAYER_IsTrueSpectator ( &players[ulPlayer] )

has to be replaced by

( ( PLAYER_IsTrueSpectator ( &players[ulIdx] ) != PLAYER_IsTrueSpectator ( &players[ulPlayer] ) || PLAYER_IsTrueSpectator ( &players[ulIdx] ) = false )
User avatar (0006696)
Edward-san (developer)
2013-07-18 10:25
Quote

PLAYER_IsTrueSpectator ( &players[ulIdx] ) = false


I suppose it's '==', not '='.
User avatar (0006703)
Torr Samaho (administrator)
2013-07-18 16:40

 Yes, that was a typo, the code wouldn't have compiled as is. Here is a testing binary with my proposed fix. Please confirm that it works and also check that spectator chat still works regardless on which team the spectators may have been before.
User avatar (0006705)
Arco (updater)
2013-07-18 17:14

 Conformed fixed. Spectators and players alike of different teams cannot see their enemies nor other spectator team chat.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-07-17 22:22 Watermelon New Issue
2013-07-17 22:25 Dusk Assigned To => Dusk
2013-07-17 22:25 Dusk Priority urgent => immediate
2013-07-17 22:25 Dusk Status new => assigned
2013-07-17 22:37 Dusk File Added: teamchat.diff
2013-07-17 22:37 Dusk Note Added: 0006687
2013-07-17 22:38 Edward-san Note Added: 0006688
2013-07-17 22:38 Edward-san Note Deleted: 0006688
2013-07-17 22:38 Watermelon Note Added: 0006689
2013-07-17 22:38 Dusk Status assigned => needs review
2013-07-17 22:38 Watermelon Note Deleted: 0006689
2013-07-17 22:50 Edward-san Note Added: 0006690
2013-07-18 00:14 Dusk Target Version 1.1 => 1.1.1
2013-07-18 07:04 Torr Samaho Note Added: 0006695
2013-07-18 07:08 Torr Samaho Note Edited: 0006695 View Revisions
2013-07-18 07:08 Torr Samaho Note Revision Dropped: 6695: 0003723
2013-07-18 10:25 Edward-san Note Added: 0006696
2013-07-18 16:40 Torr Samaho Note Added: 0006703
2013-07-18 16:41 Torr Samaho Status needs review => needs testing
2013-07-18 17:14 Arco Note Added: 0006705
2013-07-18 17:25 Dusk Status needs testing => resolved
2013-07-18 17:25 Dusk Fixed in Version => 1.1.1
2013-07-18 17:25 Dusk Resolution open => fixed
2013-07-18 17:32 Dusk Status resolved => feedback
2013-07-18 17:32 Dusk Resolution fixed => reopened
2013-07-18 22:00 Dusk Status feedback => resolved
2013-07-18 22:00 Dusk Resolution reopened => fixed
2018-09-30 21:33 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker