Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000951Zandronum[All Projects] Suggestionpublic2012-08-04 18:362018-09-30 23:31
ReporterEdward-san 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target Version1.4Fixed in Version1.4 
Summary0000951: Allow spectators to pass through some kind of portals (or what are they called)
DescriptionHi. I noticed that in both skulltag and zandronum alpha there are some "teleport lines" which are usable by players but not by spectators.
An example:

create a new game with zombie horde map pack, ie zh-mappack6a.pk3;
goto to map zm06 (ignore the console messages);
write in console 'warp 2900 1000'

you'll see a door which a player can use, but the spectator not. Is ACS involved in this case?

I was not sure to label it as a 'bug', so I thought about a 'suggestion'.
Steps To ReproduceDescription.
Additional InformationActually it's not just that door, it happens in other spots in the same map and in other maps in the same file. Example:

in zm06:
"3750 630" at your left;
"11300 2800" at your back right;
"11500 540" at your front;
Attached Fileszip file icon secact.wad.zip [^] (23,586 bytes) 2012-08-05 19:07
diff file icon thingact.diff [^] (3,099 bytes) 2013-05-26 14:37 [Show Content]

- Relationships

-  Notes
User avatar (0004243)
Torr Samaho (administrator)
2012-08-04 19:27

Spectators can use teleports in general, so there must be something special about this. Please create a minimal example wad.
User avatar (0004244)
Watermelon (developer)
2012-08-04 20:15

Is it a teleport line special? Or an ACS_Execute[Always] that invokes a teleport somewhere?
User avatar (0004247)
Edward-san (developer)
2012-08-04 22:54

I sent a PM to ZzZombo, the author of the mappack about that.
User avatar (0004248)
Ivan (reporter)
2012-08-04 23:08

Yeah you can't teleport at the ZE06 of Zombie Horde AFAIK. The megacorp building escape thing. I don't know how it teleports the players though.
User avatar (0004249)
Edward-san (developer)
2012-08-04 23:53
edited on: 2012-08-04 23:53

this script is the culprit in that case:


Script 2 (void) /* Teleport to the director's office */
{
If(CheckInventory("zombiemaker")) Teleport_NoFog(49, 1, 0);
Else Teleport_NoFog(100+PlayerNumber(), 1, 0);
}

that's an ACS_Execute line so probably can't be fixed by Zandronum.

The thing is that in ZM07 there's that green line that works fine, because it's assigned directly to Teleport_NoFog.

User avatar (0004250)
Edward-san (developer)
2012-08-05 00:13

Found out that near the door I indicated at the description there's a thing called Actor Enters Sector (type 9998), with Special: 71 (Teleport_NoFog). Probably spectators can't interact with it...
User avatar (0004251)
Torr Samaho (administrator)
2012-08-05 08:09
edited on: 2012-08-05 08:10

Quote from Edward-san
that's an ACS_Execute line so probably can't be fixed by Zandronum.

Yes, Zandronum itself can't handle this.

Quote from Edward-san
Found out that near the door I indicated at the description there's a thing called Actor Enters Sector (type 9998), with Special: 71 (Teleport_NoFog). Probably spectators can't interact with it...

This is something Zandronum possibly can handle. If you create a minimal example wad I'll look into it.

User avatar (0004275)
Edward-san (developer)
2012-08-05 18:00

I can't create a new wad for now. I hope someone else can do this.
User avatar (0004276)
Dusk (developer)
2012-08-05 19:08
edited on: 2012-08-05 19:08

Attached a test-case wad with one test for every sector action.

User avatar (0004280)
Edward-san (developer)
2012-08-05 21:54

Hmm... only "above" and "below" parts are not bugged...
User avatar (0004284)
Edward-san (developer)
2012-08-06 11:13

Why did you close this and labeled this as 'waiting for zdoom'? The player can activate the teleports with no problems, just the spectators can't.
User avatar (0004285)
Torr Samaho (administrator)
2012-08-06 11:28

Oops, I closed the wrong ticket (too many open tabs...).

Regarding this issue: I remembered that I explicitly prevented spectators from activating sector specials. This was necessary since spectators could activate gameplay relevant sector specials offline. This has to be revised so that spectators can activate a few selected specials but no other specials. I started to work on this, but noticed that this requires more changes than I want to sneak in before we release 1.0. I'll take care of this after 1.0's release.
User avatar (0004358)
ZzZombo (reporter)
2012-08-13 08:28

Just to clarify, I'm not the author of the mappack and didn't release any maps for ZH.
User avatar (0006342)
Edward-san (developer)
2013-05-25 00:43
edited on: 2013-05-25 00:44

Quote
Hmm... only "above" and "below" parts are not bugged...


I have to correct this statement, because, after retesting it, only if I spectate offline I get that behavior, but if I connect online and stay spectated, or spectate after joining the game, I can't get any of the portals work.

It still happens in the last beta build.

User avatar (0006345)
Edward-san (developer)
2013-05-26 14:24
edited on: 2013-05-26 14:49

When it's called ASectorAction::CheckTrigger in the two Above/Below floors, the action special is 0 for the online spectators so they won't ever activate.

For offline, when i apply the attached patch, the offline spectators can activate all the Teleport actions except for 'Use' trigger, but I suppose it's okay.

User avatar (0010884)
Edward-san (developer)
2014-11-14 02:49

Okay, took a look today and understood a bit better the thing, thanks to Dusk's input. Pull request:'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/102/fixed-spectators-could-not-trigger-allowed/diff [^]'
User avatar (0011008)
cobalt (updater)
2014-11-30 17:28

Issue addressed by commit c74d086231a2: Fixed: Spectators could not trigger allowed action specials with sectors. The only exceptions are the 'Use' and the 'UseWall' action triggers (fixes 951)
Committed by edward_san [edward-san] on Thursday 20 November 2014 23:41:54

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/g_shared/a_sectoraction.cpp | 6 +++---
 src/gamemode.cpp | 20 ++++++++++++++++++++
 src/gamemode.h | 1 +
 src/p_map.cpp | 28 ++--------------------------
 src/p_mobj.cpp | 8 ++------
 src/p_spec.cpp | 15 ++-------------
 src/sv_main.cpp | 4 +++-
 8 files changed, 34 insertions(+), 49 deletions(-)
User avatar (0011884)
StrikerMan780 (reporter)
2015-03-25 01:49

A map of mine uses a lot of Teleports with "Actor Hits Ceiling" and "Actor Hits Floor" actors, and it seems to work as a spectator now.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-08-04 18:36 Edward-san New Issue
2012-08-04 19:27 Torr Samaho Note Added: 0004243
2012-08-04 19:28 Torr Samaho Status new => feedback
2012-08-04 20:15 Watermelon Note Added: 0004244
2012-08-04 22:54 Edward-san Note Added: 0004247
2012-08-04 22:54 Edward-san Status feedback => new
2012-08-04 23:08 Ivan Note Added: 0004248
2012-08-04 23:53 Edward-san Note Added: 0004249
2012-08-04 23:53 Edward-san Note Edited: 0004249 View Revisions
2012-08-05 00:13 Edward-san Note Added: 0004250
2012-08-05 08:09 Torr Samaho Note Added: 0004251
2012-08-05 08:10 Torr Samaho Note Edited: 0004251 View Revisions
2012-08-05 08:10 Torr Samaho Note Revision Dropped: 4251: 0002336
2012-08-05 18:00 Edward-san Note Added: 0004275
2012-08-05 19:07 Dusk File Added: secact.wad.zip
2012-08-05 19:08 Dusk Note Added: 0004276
2012-08-05 19:08 Dusk Note Edited: 0004276 View Revisions
2012-08-05 21:54 Edward-san Note Added: 0004280
2012-08-06 08:36 Torr Samaho Status new => closed
2012-08-06 08:36 Torr Samaho Resolution open => waiting for zdoom
2012-08-06 08:36 Torr Samaho Product Version 1.0-beta => 98d
2012-08-06 11:13 Edward-san Note Added: 0004284
2012-08-06 11:13 Edward-san Status closed => feedback
2012-08-06 11:13 Edward-san Resolution waiting for zdoom => reopened
2012-08-06 11:28 Torr Samaho Note Added: 0004285
2012-08-06 11:28 Torr Samaho Assigned To => Torr Samaho
2012-08-06 11:28 Torr Samaho Status feedback => assigned
2012-08-13 08:28 ZzZombo Note Added: 0004358
2013-05-25 00:43 Edward-san Note Added: 0006342
2013-05-25 00:44 Edward-san Note Edited: 0006342 View Revisions
2013-05-26 14:24 Edward-san Note Added: 0006345
2013-05-26 14:36 Edward-san File Added: thingact.diff
2013-05-26 14:37 Edward-san File Deleted: thingact.diff
2013-05-26 14:37 Edward-san File Added: thingact.diff
2013-05-26 14:49 Edward-san Note Edited: 0006345 View Revisions
2013-05-26 14:49 Edward-san Note Edited: 0006345 View Revisions
2014-11-14 02:49 Edward-san Note Added: 0010884
2014-11-14 10:28 Edward-san Assigned To Torr Samaho => Edward-san
2014-11-14 10:29 Edward-san Status assigned => needs review
2014-11-30 17:28 cobalt Status needs review => needs testing
2014-11-30 17:28 cobalt Target Version => 1.4
2014-11-30 17:28 cobalt Description Updated View Revisions
2014-11-30 17:28 cobalt Additional Information Updated View Revisions
2014-11-30 17:28 cobalt Note Added: 0011008
2015-03-25 01:49 StrikerMan780 Note Added: 0011884
2015-03-25 19:42 Dusk Status needs testing => resolved
2015-03-25 19:42 Dusk Fixed in Version => 1.4
2015-03-25 19:42 Dusk Resolution reopened => fixed
2018-09-30 23:31 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker