0000838: [120415-2135] ACS Command "LocalSetMusic" doesn't work online

(0003570)
unknownna (updater)
2012-05-06 22:17
edited on: 2012-05-06 22:21

Script 1 (Void) NET
{
    LocalSetMusic ("D_IN_CIT");
    Suspend;
    LocalSetMusic ("D_RUNNIN");
}

This works fine for me. I think you'll have to post an example WAD.

(0003571)
StrikerMan780 (reporter)
2012-05-06 22:47
edited on: 2012-05-06 22:48

Try using it in a map, with linedef triggers, rather than puking it. Also, make sure you're testing this online.

If that doesn't work out, use an SVN Client like TortoiseSVN, and download this repository:'http://shadow-mavericks-multi-purpose-mod.googlecode.com/svn/trunk/ [^]'

To compile, run DevBuild.bat

Make a server, and use any of the music changers, in the map "HQ". The music changers can be found in my room, in the weapons shop lobby, and the HQ lobby. They should be relatively easy to find. If not, I can give directions.

(0003574)
MP2E (reporter)
2012-05-06 23:55

I can't seem to reproduce the issue with the test wad you included and the latest revision in Linux x86_64. Even using a proxy to delay packets to 200 ping and 10% packet loss still "just worked". I'm going to check out SMMPs svn and get back to you on this though

(0003575)
StrikerMan780 (reporter)
2012-05-07 01:00

Be aware that this was tested using a windows build.

(0003576)
unknownna (updater)
2012-05-07 01:04

> To compile, run DevBuild.bat

Could you do me a favor and upload a build somewhere so that I can download it?

(0003577)
StrikerMan780 (reporter)
2012-05-07 01:46

Just put the contents of the PK3 folder in a zip, and load that with Skulltag.

(0003578)
unknownna (updater)
2012-05-07 02:26
edited on: 2012-05-07 02:34

> Try using it in a map, with linedef triggers, rather than puking it. Also, make sure you're testing this online.

FYI, I did that before I uploaded the example WAD.

> Just put the contents of the PK3 folder in a zip, and load that with Skulltag.

344 MB downloaded. I'm not doing that again. Anyway, I managed to find your room and the music changer seems to work. I select a track with +use and play it with +attack.

(0003579)
StrikerMan780 (reporter)
2012-05-07 03:12
edited on: 2012-05-07 03:16

Unknownna, Are you using linux or windows? The reason I ask, is because it's affecting windows servers from what I can tell.

Also, for future testing, the beauty of SVN is that you don't have to re-download for every update anymore.

(0003580)
unknownna (updater)
2012-05-07 03:13

> Unknownna, Are you using linux or windows?

Windows.

(0003581)
StrikerMan780 (reporter)
2012-05-07 04:10
edited on: 2012-05-07 04:11

Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file)

I'm beginning to wonder if it has to do with loading in the 7-Zip file format, because from further testing with that build, it seems to affect all music in the mod, either through "changemus" or even just default map music.

(0003584)
unknownna (updater)
2012-05-07 12:51

> Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file)

I tried to run QuickBuild.dat and it told me: "Unable to find revision number from Subversion. You must install Subversion from'http://subversion.tigris.org/." [^]'

I also created a 7z archive with SLADE and put my example WAD in there and it still seems to be working as intended for me online.

(0003585)
unknownna (updater)
2012-05-07 13:05

The only thing I noticed is that 1 client only changes its music if the server executes the script. All (or none) clients should change their music if the server is the activator of the script.

(0003587)
StrikerMan780 (reporter)
2012-05-07 20:21
edited on: 2012-05-07 21:00

"> Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file)
I tried to run QuickBuild.dat and it told me: "Unable to find revision number from Subversion. You must install Subversion from'http://subversion.tigris.org/" [^]'
I also created a 7z archive with SLADE and put my example WAD in there and it still seems to be working as intended for me online."

Install the subversion command line tools from that site. Also, use CUSTOM music in your PK7. As far as I know, Slade doesn't even support 7-zip archives, just Zip. Also, be sure it is a SOLID archive.

"The only thing I noticed is that 1 client only changes its music if the server executes the script. All (or none) clients should change their music if the server is the activator of the script."

No, it shouldn't. There's a reason it's called LOCALsetmusic.

Anyhow, I am NOT the only one getting this bug, 10 other people during testing get the same exact thing. I can also reproduce it repeatedly, over and over again without any inconsistency. I'm beginning to get extremely frustrated, because I know something is wrong. It shouldn't be difficult to reproduce either, since all of our testing team have been able to do it.

(0003588)
Torr Samaho (administrator)
2012-05-07 23:41
edited on: 2012-05-07 23:42

> This worked in 98d, and as late as ST 98e build 3299 from my testing.

So you have tried the same version of the pk3 in different Skulltag versions (using the same ini file), and it works in 98d and 98e-3299, but is broken in newer beta builds?

> a simple box map, with a few player starts, and a linedef trigger for this script should work:

Do you just suspect that this works or did you test this on your own? Suspecting that localsetmusic is broken and actually knowing that it's broken are very different. With such a huge mod it is very tempting to make hasty conclusions that later turn out to be wrong. The first thing that needs to be done is to create a minimal example wad that allows to reproduce the problem. Did you test unknownna's example wad? If it works for you, you know that LocalSetMusic is not the problem.

(0003589)
StrikerMan780 (reporter)
2012-05-07 23:45
edited on: 2012-05-08 01:07

Ignore the 1st post... Turned out the cause is different. As for creating a minimal wad, that's absolutely impossible if I don't know the direct cause. But, I *do* know that it is indeed a bug with Skulltag, and not the project itself. Something is telling me the resources aren't being loaded correctly or something along those lines. The game should be playing music, but instead is using stuff from the Sounds folder, namely, the bullet casing sounds...

EDIT: And like the fucking useless idiot that I am, It turns out I jumped to conclusions too early, and have now found that the bug is in Build 3299 as well. It seems to have to do with the PK7/7Z format (perhaps when the archive is solid?). Loading it as a PK3 seems to be alright so far.

To simplify things, I've added PK3 and PK7 versions of all Build Batches on the SMMP SVN. Hopefully this helps.

(0003619)
StrikerMan780 (reporter)
2012-05-13 22:47
edited on: 2012-05-13 22:48

Yeah, it definitely seems to have something to do with the PK7 format... Try using the DevBuild_PK7.bat file. It uses ultra compression, and it's a solid archive.

(0003629)
Torr Samaho (administrator)
2012-05-14 19:33

If it has to do with the compression it is most likely a ZDoom bug (that possibly already is fixed in ZDoom). Anyway, unless somebody condenses this down to a minimal example wad debugging this in Skulltag is not feasible.

(0003636)
StrikerMan780 (reporter)
2012-05-14 23:37

How is it not feasible? If it has to do with file size, there's a reason I migrated over to SVN...

(0003637)
Edward-san (developer)
2012-05-14 23:54

A minimal example wad helps greatly because when you do a step-by-step debugging you won't need to pass through lots of unneeded calls. The size is not the principal problem.

(0005131)
StrikerMan780 (reporter)
2012-10-16 17:27

Just scrap this issue, as what I originally thought the issue was, wasn't. I'll make a new issue when I get a test PK7 ready.

(0005140)
Torr Samaho (administrator)
2012-10-20 18:41

Ok, closed.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-05-06 21:06	StrikerMan780	New Issue
2012-05-06 22:16	unknownna	File Added: localsetmusic_01.wad
2012-05-06 22:17	unknownna	Note Added: 0003570
2012-05-06 22:17	unknownna	Status	new => feedback
2012-05-06 22:21	unknownna	Note Edited: 0003570	View Revisions
2012-05-06 22:47	StrikerMan780	Note Added: 0003571
2012-05-06 22:47	StrikerMan780	Status	feedback => new
2012-05-06 22:47	StrikerMan780	Note Edited: 0003571	View Revisions
2012-05-06 22:48	StrikerMan780	Note Edited: 0003571	View Revisions
2012-05-06 23:55	MP2E	Note Added: 0003574
2012-05-07 01:00	StrikerMan780	Note Added: 0003575
2012-05-07 01:04	unknownna	Note Added: 0003576
2012-05-07 01:04	unknownna	Status	new => feedback
2012-05-07 01:46	StrikerMan780	Note Added: 0003577
2012-05-07 01:46	StrikerMan780	Status	feedback => new
2012-05-07 02:26	unknownna	File Added: Screenshot_Doom_20120507_042038.png
2012-05-07 02:26	unknownna	Note Added: 0003578
2012-05-07 02:26	unknownna	Status	new => feedback
2012-05-07 02:34	unknownna	Note Edited: 0003578	View Revisions
2012-05-07 03:12	StrikerMan780	Note Added: 0003579
2012-05-07 03:12	StrikerMan780	Status	feedback => new
2012-05-07 03:13	StrikerMan780	Note Edited: 0003579	View Revisions
2012-05-07 03:13	unknownna	Note Added: 0003580
2012-05-07 03:16	StrikerMan780	Note Edited: 0003579	View Revisions
2012-05-07 04:10	StrikerMan780	Note Added: 0003581
2012-05-07 04:11	StrikerMan780	Note Edited: 0003581	View Revisions
2012-05-07 12:34	unknownna	File Added: localsetmusic_02.7z
2012-05-07 12:51	unknownna	Note Added: 0003584
2012-05-07 12:51	unknownna	Status	new => feedback
2012-05-07 13:05	unknownna	Note Added: 0003585
2012-05-07 20:21	StrikerMan780	Note Added: 0003587
2012-05-07 20:21	StrikerMan780	Status	feedback => new
2012-05-07 20:24	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 20:25	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 20:25	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 20:26	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 20:52	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 20:53	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 21:00	StrikerMan780	Note Edited: 0003587	View Revisions
2012-05-07 23:41	Torr Samaho	Note Added: 0003588
2012-05-07 23:42	Torr Samaho	Note Edited: 0003588	View Revisions
2012-05-07 23:42	Torr Samaho	Note Revision Dropped: 3588: 0001958
2012-05-07 23:45	StrikerMan780	Note Added: 0003589
2012-05-07 23:46	StrikerMan780	Note Edited: 0003589	View Revisions
2012-05-07 23:47	StrikerMan780	Note Edited: 0003589	View Revisions
2012-05-08 00:53	StrikerMan780	Note Edited: 0003589	View Revisions
2012-05-08 01:02	StrikerMan780	Note Edited: 0003589	View Revisions
2012-05-08 01:07	StrikerMan780	Note Edited: 0003589	View Revisions
2012-05-13 22:47	StrikerMan780	Note Added: 0003619
2012-05-13 22:48	StrikerMan780	Note Edited: 0003619	View Revisions
2012-05-14 19:33	Torr Samaho	Note Added: 0003629
2012-05-14 19:33	Torr Samaho	Status	new => feedback
2012-05-14 23:37	StrikerMan780	Note Added: 0003636
2012-05-14 23:37	StrikerMan780	Status	feedback => new
2012-05-14 23:54	Edward-san	Note Added: 0003637
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2012-10-16 17:27	StrikerMan780	Note Added: 0005131
2012-10-20 18:41	Torr Samaho	Note Added: 0005140
2012-10-20 18:41	Torr Samaho	Status	new => closed
2012-10-20 18:41	Torr Samaho	Resolution	open => no change required

Notes
(0003570) unknownna (updater) 2012-05-06 22:17 edited on: 2012-05-06 22:21	Script 1 (Void) NET { LocalSetMusic ("D_IN_CIT"); Suspend; LocalSetMusic ("D_RUNNIN"); } This works fine for me. I think you'll have to post an example WAD.

(0003571) StrikerMan780 (reporter) 2012-05-06 22:47 edited on: 2012-05-06 22:48	Try using it in a map, with linedef triggers, rather than puking it. Also, make sure you're testing this online. If that doesn't work out, use an SVN Client like TortoiseSVN, and download this repository:'http://shadow-mavericks-multi-purpose-mod.googlecode.com/svn/trunk/ [^]' To compile, run DevBuild.bat Make a server, and use any of the music changers, in the map "HQ". The music changers can be found in my room, in the weapons shop lobby, and the HQ lobby. They should be relatively easy to find. If not, I can give directions.

(0003574) MP2E (reporter) 2012-05-06 23:55	I can't seem to reproduce the issue with the test wad you included and the latest revision in Linux x86_64. Even using a proxy to delay packets to 200 ping and 10% packet loss still "just worked". I'm going to check out SMMPs svn and get back to you on this though

(0003575) StrikerMan780 (reporter) 2012-05-07 01:00	Be aware that this was tested using a windows build.

(0003576) unknownna (updater) 2012-05-07 01:04	> To compile, run DevBuild.bat Could you do me a favor and upload a build somewhere so that I can download it?

(0003577) StrikerMan780 (reporter) 2012-05-07 01:46	Just put the contents of the PK3 folder in a zip, and load that with Skulltag.

(0003578) unknownna (updater) 2012-05-07 02:26 edited on: 2012-05-07 02:34	> Try using it in a map, with linedef triggers, rather than puking it. Also, make sure you're testing this online. FYI, I did that before I uploaded the example WAD. > Just put the contents of the PK3 folder in a zip, and load that with Skulltag. 344 MB downloaded. I'm not doing that again. Anyway, I managed to find your room and the music changer seems to work. I select a track with +use and play it with +attack.

(0003579) StrikerMan780 (reporter) 2012-05-07 03:12 edited on: 2012-05-07 03:16	Unknownna, Are you using linux or windows? The reason I ask, is because it's affecting windows servers from what I can tell. Also, for future testing, the beauty of SVN is that you don't have to re-download for every update anymore.

(0003580) unknownna (updater) 2012-05-07 03:13	> Unknownna, Are you using linux or windows? Windows.

(0003581) StrikerMan780 (reporter) 2012-05-07 04:10 edited on: 2012-05-07 04:11	Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file) I'm beginning to wonder if it has to do with loading in the 7-Zip file format, because from further testing with that build, it seems to affect all music in the mod, either through "changemus" or even just default map music.

(0003584) unknownna (updater) 2012-05-07 12:51	> Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file) I tried to run QuickBuild.dat and it told me: "Unable to find revision number from Subversion. You must install Subversion from'http://subversion.tigris.org/." [^]' I also created a 7z archive with SLADE and put my example WAD in there and it still seems to be working as intended for me online.

(0003585) unknownna (updater) 2012-05-07 13:05	The only thing I noticed is that 1 client only changes its music if the server executes the script. All (or none) clients should change their music if the server is the activator of the script.

(0003587) StrikerMan780 (reporter) 2012-05-07 20:21 edited on: 2012-05-07 21:00	"> Also, try using QuickBuild.bat then, it packs it as a PK7. (7-Zip file) I tried to run QuickBuild.dat and it told me: "Unable to find revision number from Subversion. You must install Subversion from'http://subversion.tigris.org/" [^]' I also created a 7z archive with SLADE and put my example WAD in there and it still seems to be working as intended for me online." Install the subversion command line tools from that site. Also, use CUSTOM music in your PK7. As far as I know, Slade doesn't even support 7-zip archives, just Zip. Also, be sure it is a SOLID archive. "The only thing I noticed is that 1 client only changes its music if the server executes the script. All (or none) clients should change their music if the server is the activator of the script." No, it shouldn't. There's a reason it's called LOCALsetmusic. Anyhow, I am NOT the only one getting this bug, 10 other people during testing get the same exact thing. I can also reproduce it repeatedly, over and over again without any inconsistency. I'm beginning to get extremely frustrated, because I know something is wrong. It shouldn't be difficult to reproduce either, since all of our testing team have been able to do it.

(0003588) Torr Samaho (administrator) 2012-05-07 23:41 edited on: 2012-05-07 23:42	> This worked in 98d, and as late as ST 98e build 3299 from my testing. So you have tried the same version of the pk3 in different Skulltag versions (using the same ini file), and it works in 98d and 98e-3299, but is broken in newer beta builds? > a simple box map, with a few player starts, and a linedef trigger for this script should work: Do you just suspect that this works or did you test this on your own? Suspecting that localsetmusic is broken and actually knowing that it's broken are very different. With such a huge mod it is very tempting to make hasty conclusions that later turn out to be wrong. The first thing that needs to be done is to create a minimal example wad that allows to reproduce the problem. Did you test unknownna's example wad? If it works for you, you know that LocalSetMusic is not the problem.

(0003589) StrikerMan780 (reporter) 2012-05-07 23:45 edited on: 2012-05-08 01:07	Ignore the 1st post... Turned out the cause is different. As for creating a minimal wad, that's absolutely impossible if I don't know the direct cause. But, I do know that it is indeed a bug with Skulltag, and not the project itself. Something is telling me the resources aren't being loaded correctly or something along those lines. The game should be playing music, but instead is using stuff from the Sounds folder, namely, the bullet casing sounds... EDIT: And like the fucking useless idiot that I am, It turns out I jumped to conclusions too early, and have now found that the bug is in Build 3299 as well. It seems to have to do with the PK7/7Z format (perhaps when the archive is solid?). Loading it as a PK3 seems to be alright so far. To simplify things, I've added PK3 and PK7 versions of all Build Batches on the SMMP SVN. Hopefully this helps.

(0003619) StrikerMan780 (reporter) 2012-05-13 22:47 edited on: 2012-05-13 22:48	Yeah, it definitely seems to have something to do with the PK7 format... Try using the DevBuild_PK7.bat file. It uses ultra compression, and it's a solid archive.

(0003629) Torr Samaho (administrator) 2012-05-14 19:33	If it has to do with the compression it is most likely a ZDoom bug (that possibly already is fixed in ZDoom). Anyway, unless somebody condenses this down to a minimal example wad debugging this in Skulltag is not feasible.

(0003636) StrikerMan780 (reporter) 2012-05-14 23:37	How is it not feasible? If it has to do with file size, there's a reason I migrated over to SVN...

(0003637) Edward-san (developer) 2012-05-14 23:54	A minimal example wad helps greatly because when you do a step-by-step debugging you won't need to pass through lots of unneeded calls. The size is not the principal problem.

(0005131) StrikerMan780 (reporter) 2012-10-16 17:27	Just scrap this issue, as what I originally thought the issue was, wasn't. I'll make a new issue when I get a test PK7 ready.

(0005140) Torr Samaho (administrator) 2012-10-20 18:41	Ok, closed.

Relationships