0000455: "+showmedals" for coop spy

(0008747)
Watermelon (developer)
2014-05-09 03:47
edited on: 2014-05-09 13:56

Since we have

NetCommand command( SVC_GIVEPLAYERMEDAL );
command.addByte( ulPlayer );
command.addByte( ulMedal );
command.sendCommandToClients( ulPlayerExtra, ulFlags );

for sending medals, that means all clients know about it. Any reason not to have f12 spying other player's medals?

(0008763)
Watermelon (developer)
2014-05-09 19:39

Easy fix, oversight by Carn I'm guessing...

'https://bitbucket.org/ChrisKOmg/zandronum/commits/809e4a555dcf437004f5dac60ff3cce0766b373a [^]'

(Optional:'https://bitbucket.org/ChrisKOmg/zandronum/commits/ab00d57bd2db2ea2641be42c330cb767ab465e0a [^]' )

(0008768)
Konar6 (reporter)
2014-05-10 08:18

I don't think it was an oversight since the message reads "YOU have earned the following medals". Would make sense changing that in case you want to display the spied player's medals instead.

(0008770)
Watermelon (developer)
2014-05-10 13:10
edited on: 2014-05-10 13:40

If it wasn't an oversight then there'd be no reason checks for camera/camera->player being NULL. It would just have been MEDAL_RenderAllMedalsFullscreen( &players[consoleplayer] );

But the names need to be updated to reflect that on the scoreboard.

'https://bitbucket.org/ChrisKOmg/zandronum/commits/d286d68d94c6b11204b933331b3cc8bcfd7f9a59 [^]'

(0008771)
Edward-san (developer)
2014-05-10 14:17
edited on: 2014-05-10 14:17

I believe you should avoid std::string and use the zdoom-derived FString.

Uh, speaking of std::string, it's used a lot in some zandronum files:

network.cpp:285: std::vector<std::string> lumpsToAuthenticate;
network.cpp.orig:285: std::vector<std::string> lumpsToAuthenticate;
networkshared.cpp:566:std::string GenerateCouldNotOpenFileErrorString( const char *pszFunctionHeader, const char *pszFileName, LONG lErrorCode )
networkshared.cpp:568: std::stringstream errorMessage;
networkshared.cpp:1065:std::string IPList::getEntryAsString( const ULONG ulIdx, bool bIncludeComment, bool bIncludeExpiration, bool bInludeNewline ) const
networkshared.cpp:1067: std::stringstream entryStream;
networkshared.cpp:1102:void IPList::addEntry( const char *pszIP0, const char *pszIP1, const char *pszIP2, const char *pszIP3, const char *pszPlayerName, const char *pszCommentUncleaned, std::string &Message, time_t tExpiration )
networkshared.cpp:1108: std::stringstream messageStream;
networkshared.cpp:1218:void IPList::addEntry( const char *pszIPAddress, const char *pszPlayerName, const char *pszComment, std::string &Message, time_t tExpiration )
networkshared.cpp:1257:void IPList::removeEntry( const char *pszIP0, const char *pszIP1, const char *pszIP2, const char *pszIP3, std::string &Message )
networkshared.cpp:1261: std::stringstream messageStream;
networkshared.cpp:1281:void IPList::removeEntry( const char *pszIPAddress, std::string &Message )
networkshared.cpp:1300: std::string outString;
networkshared.h:287:std::string GenerateCouldNotOpenFileErrorString( const char *pszFunctionHeader, const char *pszFileName, LONG lErrorCode );networkshared.h:348: std::string
_filename;
networkshared.h:349: std::string _error;
networkshared.h:360: std::string getEntryAsString( const ULONG ulIdx, bool bIncludeComment = true, bool bIncludeExpiration = true, bool bInludeNewline = true ) const;
networkshared.h:364: void addEntry( const char *pszIP0, const char *pszIP1, const char *pszIP2, const char *pszIP3, const char *pszPlayerName, const char *pszComment, std::string &Message, time_t tExpiration );
networkshared.h:365: void addEntry( const char *pszIPAddress, const char *pszPlayerName, const char *pszComment, std::string &Message, time_t tExpiration );
networkshared.h:366: void removeEntry( const char *pszIP0, const char *pszIP1, const char *pszIP2, const char *pszIP3, std::string &Message );
networkshared.h:367: void removeEntry( const char *pszIPAddress, std::string &Message );sv_ban.cpp:204: std::string Message;
sv_ban.cpp:213: std::string Message;
sv_ban.cpp:255: std::string Message;
sv_ban.cpp:411: std::string message;
sv_ban.cpp:618: std::string message;
sv_ban.cpp:636: std::string message;
sv_ban.cpp:651: std::string message;
sv_ban.cpp:666: std::string message;
sv_main.cpp:6369: std::string reason;
win32/serverconsole/serverconsole.cpp:1491: std::string Message;

If you wish, Torr, I can take a look at these and convert them to FString.

(0008773)
Watermelon (developer)
2014-05-10 21:11

Is there something wrong with std::string? Not that I have a problem with FString

(0008828)
Torr Samaho (administrator)
2014-06-01 15:21

I added your patches (compressed into a single changeset).

Quote from Watermelon

Is there something wrong with std::string?

No, std::string is fine.

(0008884)
Arco (updater)
2014-06-07 22:34

Works correctly.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2011-05-19 00:43	unknownna	New Issue
2011-05-19 00:43	unknownna	File Added: screenshot.png
2014-05-09 03:47	Watermelon	Note Added: 0008747
2014-05-09 13:56	Watermelon	Note Edited: 0008747	View Revisions
2014-05-09 19:39	Watermelon	Note Added: 0008763
2014-05-09 19:39	Watermelon	Assigned To	=> Watermelon
2014-05-09 19:39	Watermelon	Status	new => needs review
2014-05-09 19:39	Watermelon	Category	Suggestion => Bug
2014-05-10 08:18	Konar6	Note Added: 0008768
2014-05-10 13:10	Watermelon	Note Added: 0008770
2014-05-10 13:40	Watermelon	Note Edited: 0008770	View Revisions
2014-05-10 14:17	Edward-san	Note Added: 0008771
2014-05-10 14:17	Edward-san	Note Edited: 0008771	View Revisions
2014-05-10 21:11	Watermelon	Note Added: 0008773
2014-06-01 15:21	Torr Samaho	Note Added: 0008828
2014-06-01 15:21	Torr Samaho	Status	needs review => needs testing
2014-06-01 15:21	Torr Samaho	Target Version	=> 1.3
2014-06-07 22:34	Arco	Note Added: 0008884
2014-06-07 22:34	Arco	Status	needs testing => resolved
2014-06-07 22:34	Arco	Resolution	open => fixed
2018-09-30 22:42	Blzut3	Status	resolved => closed

Notes
(0008747) Watermelon (developer) 2014-05-09 03:47 edited on: 2014-05-09 13:56	Since we have NetCommand command( SVC_GIVEPLAYERMEDAL ); command.addByte( ulPlayer ); command.addByte( ulMedal ); command.sendCommandToClients( ulPlayerExtra, ulFlags ); for sending medals, that means all clients know about it. Any reason not to have f12 spying other player's medals?

(0008763) Watermelon (developer) 2014-05-09 19:39	Easy fix, oversight by Carn I'm guessing... 'https://bitbucket.org/ChrisKOmg/zandronum/commits/809e4a555dcf437004f5dac60ff3cce0766b373a [^]' (Optional:'https://bitbucket.org/ChrisKOmg/zandronum/commits/ab00d57bd2db2ea2641be42c330cb767ab465e0a [^]' )

(0008768) Konar6 (reporter) 2014-05-10 08:18	I don't think it was an oversight since the message reads "YOU have earned the following medals". Would make sense changing that in case you want to display the spied player's medals instead.

(0008770) Watermelon (developer) 2014-05-10 13:10 edited on: 2014-05-10 13:40	If it wasn't an oversight then there'd be no reason checks for camera/camera->player being NULL. It would just have been MEDAL_RenderAllMedalsFullscreen( &players[consoleplayer] ); But the names need to be updated to reflect that on the scoreboard. 'https://bitbucket.org/ChrisKOmg/zandronum/commits/d286d68d94c6b11204b933331b3cc8bcfd7f9a59 [^]'

(0008771) Edward-san (developer) 2014-05-10 14:17 edited on: 2014-05-10 14:17	I believe you should avoid std::string and use the zdoom-derived FString. Uh, speaking of std::string, it's used a lot in some zandronum files: network.cpp:285: std::vector<std::string> lumpsToAuthenticate; network.cpp.orig:285: std::vector<std::string> lumpsToAuthenticate; networkshared.cpp:566:std::string GenerateCouldNotOpenFileErrorString( const char pszFunctionHeader, const char pszFileName, LONG lErrorCode ) networkshared.cpp:568: std::stringstream errorMessage; networkshared.cpp:1065:std::string IPList::getEntryAsString( const ULONG ulIdx, bool bIncludeComment, bool bIncludeExpiration, bool bInludeNewline ) const networkshared.cpp:1067: std::stringstream entryStream; networkshared.cpp:1102:void IPList::addEntry( const char pszIP0, const char pszIP1, const char pszIP2, const char pszIP3, const char pszPlayerName, const char pszCommentUncleaned, std::string &Message, time_t tExpiration ) networkshared.cpp:1108: std::stringstream messageStream; networkshared.cpp:1218:void IPList::addEntry( const char pszIPAddress, const char pszPlayerName, const char pszComment, std::string &Message, time_t tExpiration ) networkshared.cpp:1257:void IPList::removeEntry( const char pszIP0, const char pszIP1, const char pszIP2, const char pszIP3, std::string &Message ) networkshared.cpp:1261: std::stringstream messageStream; networkshared.cpp:1281:void IPList::removeEntry( const char pszIPAddress, std::string &Message ) networkshared.cpp:1300: std::string outString; networkshared.h:287:std::string GenerateCouldNotOpenFileErrorString( const char pszFunctionHeader, const char pszFileName, LONG lErrorCode );networkshared.h:348: std::string _filename; networkshared.h:349: std::string _error; networkshared.h:360: std::string getEntryAsString( const ULONG ulIdx, bool bIncludeComment = true, bool bIncludeExpiration = true, bool bInludeNewline = true ) const; networkshared.h:364: void addEntry( const char pszIP0, const char pszIP1, const char pszIP2, const char pszIP3, const char pszPlayerName, const char pszComment, std::string &Message, time_t tExpiration ); networkshared.h:365: void addEntry( const char pszIPAddress, const char pszPlayerName, const char pszComment, std::string &Message, time_t tExpiration ); networkshared.h:366: void removeEntry( const char pszIP0, const char pszIP1, const char pszIP2, const char pszIP3, std::string &Message ); networkshared.h:367: void removeEntry( const char pszIPAddress, std::string &Message );sv_ban.cpp:204: std::string Message; sv_ban.cpp:213: std::string Message; sv_ban.cpp:255: std::string Message; sv_ban.cpp:411: std::string message; sv_ban.cpp:618: std::string message; sv_ban.cpp:636: std::string message; sv_ban.cpp:651: std::string message; sv_ban.cpp:666: std::string message; sv_main.cpp:6369: std::string reason; win32/serverconsole/serverconsole.cpp:1491: std::string Message; If you wish, Torr, I can take a look at these and convert them to FString.

(0008773) Watermelon (developer) 2014-05-10 21:11	Is there something wrong with std::string? Not that I have a problem with FString

(0008828) Torr Samaho (administrator) 2014-06-01 15:21	I added your patches (compressed into a single changeset). Quote from Watermelon Is there something wrong with std::string? No, std::string is fine.

(0008884) Arco (updater) 2014-06-07 22:34	Works correctly.

Relationships