0004038: server browser reports incorrect max client count

Notes
(0022471) Zalewa (developer) 2022-10-23 19:40	This should fix it:'https://bitbucket.org/Doomseeker/doomseeker/commits/b3cfa1884b8ccd086a88a4a8e0fbf314c0a882b8 [^]'

(0022472) WubTheCaptain (reporter) 2022-10-24 01:30 edited on: 2022-10-24 01:30	Quote from Zalewa This should fix it:'https://bitbucket.org/Doomseeker/doomseeker/commits/b3cfa1884b8ccd086a88a4a8e0fbf314c0a882b8 [^]' According to this commit, numFreeSpectatorSlots() is now deprecated, but the deprecation has not been formally documented in the CHANGELOG.md changes file yet.

(0022475) Zalewa (developer) 2022-10-26 20:39	Now it is :) 'https://bitbucket.org/Doomseeker/doomseeker/commits/30b14a0db146db8f9883ccba0675642a957a40ed [^]'

(0022640) Zalewa (developer) 2023-01-05 12:08	Beta package for Windows available at the beta auto-update channel and at: 'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]' Please test.

(0022670) WaTaKiD (updater) 2023-01-05 15:26	using 230105-1140, the reported issue is not fixed and theres also a new bug, ill put the new bug in the next note as for the reported issue, its basically reverse from before: now mousing over a server only takes sv_maxclients into account host a server with sv_maxclients 55 and sv_maxplayers 54 refresh doomseeker and mouse over the server itll show "0 / 55 (55 can join)" when it should show (54 can join) because 0 / 55 refers to sv_maxclients (the number of clients that can connect) and (54 can join) refers to sv_maxplayers (the number of clients that can join the game and play after connecting)

(0022671) WaTaKiD (updater) 2023-01-05 15:26	the new bug is in the create game menu, the max clients value will be overridden by the max players value if its higher, for example: host a server with max clients 55 and max players 54 send "sv_maxclients ; sv_maxplayers" to the server and notice both are correctly set now repeat with 54 clients and 55 players the server will show both values at 55, which shouldnt be the case

(0022672) Zalewa (developer) 2023-01-05 16:02	Quote from WaTaKiD host a server with sv_maxclients 55 and sv_maxplayers 54 refresh doomseeker and mouse over the server itll show "0 / 55 (55 can join)" when it should show (54 can join) Indeed that got bugged. Should be fixed here:'https://bitbucket.org/Doomseeker/doomseeker/commits/23f6c60afaf8c8c08d125d9946d3a1ed5ba6c11c [^]' I have also changed the formula so that it counts only the players who are in the game when calculating the 'can join' number (so spectators aren't counted). Quote from WaTaKiD the new bug is in the create game menu, the max clients value will be overridden by the max players value if its higher It's now new. IIRC it has always been so. The code that does this currently dates back to 2014 and from what I recall this was a deliberate choice to make that correction. Is there a use case where the max.clients < max.players is desired?

(0022674) WaTaKiD (updater) 2023-01-05 16:16	i guess i just didnt notice it before, sorry about that (in my defense, doomseeker doesnt tell me that it does that or why, which is why i thought it was a bug) apart from "zan allows it, why not?", all else i can think of is: say i wanted to just set the max clients to 2 so i can play/test with a friend, but leave max players at 64 for when i decide to open the server up ill only have to change max clients instead of both clients and players

(0022677) Zalewa (developer) 2023-01-06 00:23	Quote from WaTaKiD i wanted to just set the max clients to 2 so i can play/test with a friend, but leave max players at 64 for when i decide to open the server up ill only have to change max clients instead of both clients and players Ok, that's a good enough reason. I have changed this behavior so that the two values are decoupled now. Here: 'https://bitbucket.org/Doomseeker/doomseeker/commits/e028054e108e91d053be28aa911412dbf9c63e48 [^]' Also, this and the previous fixes are deployed on the beta auto-update channel. Please test again.

(0022678) WaTaKiD (updater) 2023-01-06 01:07	client/player values with/without spectators/players now display correctly and max clients can freely be set to a value lower than max players

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2022-09-27 00:07	WaTaKiD	New Issue
2022-10-23 19:10	Zalewa	Assigned To	=> Zalewa
2022-10-23 19:10	Zalewa	Status	new => assigned
2022-10-23 19:40	Zalewa	Note Added: 0022471
2022-10-23 19:40	Zalewa	Status	assigned => needs review
2022-10-23 19:40	Zalewa	Target Version	=> 1.4.0
2022-10-24 01:30	WubTheCaptain	Note Added: 0022472
2022-10-24 01:30	WubTheCaptain	Note Edited: 0022472	View Revisions
2022-10-24 01:30	WubTheCaptain	Note Edited: 0022472	View Revisions
2022-10-26 20:39	Zalewa	Note Added: 0022475
2023-01-05 12:08	Zalewa	Note Added: 0022640
2023-01-05 12:08	Zalewa	Status	needs review => needs testing
2023-01-05 15:26	WaTaKiD	Note Added: 0022670
2023-01-05 15:26	WaTaKiD	Note Added: 0022671
2023-01-05 15:29	Zalewa	Status	needs testing => assigned
2023-01-05 16:02	Zalewa	Note Added: 0022672
2023-01-05 16:02	Zalewa	Status	assigned => needs review
2023-01-05 16:03	Zalewa	Status	needs review => feedback
2023-01-05 16:16	WaTaKiD	Note Added: 0022674
2023-01-05 16:16	WaTaKiD	Status	feedback => assigned
2023-01-06 00:23	Zalewa	Note Added: 0022677
2023-01-06 00:23	Zalewa	Status	assigned => needs testing
2023-01-06 01:07	WaTaKiD	Note Added: 0022678
2023-01-06 10:58	Zalewa	Status	needs testing => resolved
2023-01-06 10:58	Zalewa	Fixed in Version	=> 1.4.0
2023-01-06 10:58	Zalewa	Resolution	open => fixed

Relationships