Zandronum Chat on our Discord Server Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003878Doomseeker[All Projects] Suggestionpublic2021-02-16 04:012021-07-01 12:23
ReporterAlexMax 
Assigned ToPol M 
PrioritynormalSeverityminorReproducibilityN/A
Statusneeds testingResolutionopen 
PlatformOSOS Version
Product Version1.3.1 
Target VersionFixed in Version 
Summary0003878: Odamex 0.9 protocol changes
DescriptionOdamex 0.9 is about to be released, and it does not contain any notable protocol changes. I can see the test servers from the existing Doomseeker release.

However, we do have a fair few more game modes that need to be checked for. The "official list" that we use both internally and in the launcher is as follows:

    else if (sv_gametype == 0 && g_lives > 0)
        name = "Survival";
    else if (sv_gametype == 0)
        name = "Cooperative";
    else if (sv_gametype == 1 && g_lives > 0)
        name = "Last Marine Standing";
    else if (sv_gametype == 1 && sv_maxplayers <= 2)
        name = "Duel";
    else if (sv_gametype == 1)
        name = "Deathmatch";
    else if (sv_gametype == 2 && g_lives > 0)
        name = "Team Last Marine Standing";
    else if (sv_gametype == 2)
        name = "Team Deathmatch";
    else if (sv_gametype == 3 && g_sides)
        name = "Attack & Defend CTF";
    else if (sv_gametype == 3 && g_lives > 0)
        name = "LMS Capture The Flag";
    else if (sv_gametype == 3)
        name = "Capture The Flag";

Obviously you can use whatever strings you find appropriate, but this is merely the conditions we check to determine which game mode name to render.

If you notice a "g_gametypename" cvar, please do not put it in the gametype column, as it is meant to be used by in-game interfaces that have much more room than a server browser.

Thanks.
Attached Files

- Relationships

-  Notes
User avatar (0021597)
AlexMax (reporter)
2021-02-17 14:46

One other thing of note, I notice that that "Version" displayed by Doomseeker is kind of messed up. In protocol version 7, instead of broadcasting a revision number, we broadcast a revision string after the "time" and "protocol number". This revision string contains the complete version (including the number).

https://github.com/odamex/odamex/blob/0.8.3/server/src/sv_sqp.cpp#L89 [^]
User avatar (0021598)
WubTheCaptain (developer)
2021-02-18 11:24
edited on: 2021-02-18 11:25

0003878:0021597: Seems unrelated to the original post, so you may want to report a new issue.

User avatar (0021599)
AlexMax (reporter)
2021-02-19 05:01

Noted. I opened a separate ticket for the query protocol bump.
User avatar (0021610)
AlexMax (reporter)
2021-03-23 02:20
edited on: 2021-03-23 02:22

My apologies, but in the release shuffle there was a small additional thing that slipped my mind that I think is related to the above changes, as it also concerns handling of server vars and not an actual protocol bug.

We have retired "sv_website" in lieu of "sv_downloadsites". It's used by our internal WAD downloader, and it is similar to "sv_website" except that it is capable of being a list of multiple download sites, instead of just one. The list is separated by space characters (0x20) and in case Wadseeker cannot handle multiple added sources simply using the first URL in the list is fine.

User avatar (0021614)
Pol M (developer)
2021-06-27 16:25

Hey AlexMax, where is the code from?
I'd like to reference something for future changes :)
User avatar (0021615)
AlexMax (reporter)
2021-06-28 01:24

This is what odalaunch uses:

https://github.com/odamex/odamex/blob/stable/odalaunch/src/lst_servers.cpp#L439 [^]

This is what Odamex itself uses (for ingame messages):

https://github.com/odamex/odamex/blob/stable/common/g_gametype.cpp#L53 [^]
User avatar (0021616)
Pol M (developer)
2021-06-28 19:59
edited on: 2021-06-28 19:59

Thank you AlexMax!
Changes made, after review we'll publish the new protocol, with all the bells and whistles a two-afternoon job lets me do! Again, thank you for letting us know.
https://bitbucket.org/Doomseeker/doomseeker/pull-requests/5/new-odamex-protocol-wadseeker-change-to [^]

User avatar (0021617)
Blzut3 (administrator)
2021-06-28 23:17

Changes look good to me, so merged. Zalewa will probably want to put out a testing build for this and the related Wadseeker change.
User avatar (0021619)
Zalewa (developer)
2021-06-29 09:23

Builds put on the beta update channel.

I think after this is tested we could do a proper release of 1.3.2?
User avatar (0021620)
Pol M (developer)
2021-07-01 12:23

Yep, it's the simplest option in my opinion.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2021-02-16 04:01 AlexMax New Issue
2021-02-16 06:52 WubTheCaptain Status new => acknowledged
2021-02-16 06:53 WubTheCaptain Severity major => minor
2021-02-16 06:55 WubTheCaptain Product Version => 1.3.1
2021-02-17 14:46 AlexMax Note Added: 0021597
2021-02-18 11:24 WubTheCaptain Note Added: 0021598
2021-02-18 11:25 WubTheCaptain Note Edited: 0021598 View Revisions
2021-02-19 05:01 AlexMax Note Added: 0021599
2021-03-23 02:20 AlexMax Note Added: 0021610
2021-03-23 02:22 AlexMax Note Edited: 0021610 View Revisions
2021-06-15 11:48 Pol M Assigned To => Pol M
2021-06-15 11:48 Pol M Status acknowledged => confirmed
2021-06-27 13:03 Pol M Status confirmed => assigned
2021-06-27 16:25 Pol M Note Added: 0021614
2021-06-28 01:24 AlexMax Note Added: 0021615
2021-06-28 19:56 Pol M Status assigned => needs review
2021-06-28 19:59 Pol M Note Added: 0021616
2021-06-28 19:59 Pol M Note Edited: 0021616 View Revisions
2021-06-28 23:17 Blzut3 Note Added: 0021617
2021-06-28 23:17 Blzut3 Status needs review => needs testing
2021-06-29 09:23 Zalewa Note Added: 0021619
2021-07-01 12:23 Pol M Note Added: 0021620






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker