0003797: huffman.cpp is mostly C, despite the file extension, but with C++ namespace, using C's stdlib.h

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0003797

Doomseeker

[All Projects] Cleanup

public

2020-06-05 09:04

2020-06-07 19:40

Reporter

WubTheCaptain

Assigned To

Priority

none

Severity

trivial

Reproducibility

have not tried

Status

feedback

Resolution

open

Platform

OS Version

Product Version

1.3.1

Target Version

Fixed in Version

Summary

0003797: huffman.cpp is mostly C, despite the file extension, but with C++ namespace, using C's stdlib.h

Description

$ file src/plugins/zandronum/huffman/huffman.cpp
src/plugins/zandronum/huffman/huffman.cpp: C source, ASCII text, with CRLF line terminators

This is from upstream, do I care to fix rename this to huffman.c?
Compare:

$ file src/plugins/zandronum/huffman/bitwriter.cpp
src/plugins/zandronum/huffman/bitwriter.cpp: C++ source, ASCII text

Interestingly, huffman.cpp has C++ namespace (using namespace skulltag;) but a C header (#include <stdlib.h>) instead of C++ equivalent. So I guess I could change it to #include <cstdlib>.

Additional Information

I'm trying to make the whole source tree more browsable and friendly to searching with grep. Hence, this question / issue while cleaning up.

Attached Files

Relationships

Notes
(0021375) Pol M (developer) 2020-06-07 19:08 edited on: 2020-06-07 19:08	From what I can tell, this file comes from here and we should try to keep them in sync in order to easily pull changes from upstream. You can propose the change to the zandronum project and send them a pull request, and then we can merge it in.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2020-06-05 09:04	WubTheCaptain	New Issue
2020-06-07 19:08	Pol M	Note Added: 0021375
2020-06-07 19:08	Pol M	Note Edited: 0021375	View Revisions
2020-06-07 19:09	Pol M	Assigned To	=> Pol M
2020-06-07 19:09	Pol M	Status	new => feedback
2020-06-07 19:40	Pol M	Assigned To	Pol M =>

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.