|Anonymous | Login | Signup for a new account||2018-10-19 11:05 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003545||Doomseeker||[All Projects] Bug||public||2018-10-08 04:00||2018-10-11 18:02|
|Target Version||1.2||Fixed in Version||1.2|
|Summary||0003545: Bzip2 IO device doesn't handle files with multiple streams|
|Description||Apparently a bz2 file can contain multiple streams concatenated together. Wadseeker needs to reinitialize the decompressor at each boundary. Presumably this fact is utilized by programs that do multithreaded compression.|
|Steps To Reproduce||Have Wadseeker extract this Zandronum testing release:https://zandronum.com/downloads/testing/3.1/ZandroDev3.1-180901-1533linux-x86_64.tar.bz2 [^]|
Release version of Wadseeker will silently fail to extract the binary.
Forgot to tag ticket number in commit message:https://bitbucket.org/Doomseeker/doomseeker/commits/9d64a42b9955e80c819c7da7f9cbb080ffb25866 [^]
This took me way longer than I want to admit to figure out. That said I can't find much documentation on the bz2 file format so I don't feel too bad about it. Somehow though all the archiving tools know about it, so at least I can confirm that multiple implementations (including most importantly the reference bzip2 program) do this by tracing through the source codes.
|I'm not favoring the "multiple nested ifs" and "if-else" coding style, personally.|
|Zalewa, please review/test?|
edited on: 2018-10-08 20:52
Quote from WubTheCaptain
The `ZandronumClientExeFile::downloadTestingBinaries()` method does a lot of stuff if anything. I'd start the refactor from splitting it into smaller ones, but that should be done on occasion of some more important change as there are no major issues with it requiring dedicated or immediate work.
Testing will have to wait until I'm less tired. I also don't have any bz2 archives readily available for testing.
I packed dwango5.wad into a 'tar.bz2' archive using 3 different methods and added 'tar.bz2' to the supported WAD archive extensions in Wadseeker just for testing purposes. I have then attempted to install each archive with a Doomseeker build from before the patch and then with a build with the patch.
The commands and WAD installation results are as listed:
The files created by `tar` and `bzip2` are the same while `pbzip2` creates a file with a different size.
So I suppose this proves that the problem is fixed.
|I'll hope you'll get into a habit of using pipes instead of temporary files and &&, tee hee.|
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2018-10-08 04:00||Blzut3||New Issue|
|2018-10-08 04:00||Blzut3||Status||new => assigned|
|2018-10-08 04:00||Blzut3||Assigned To||=> Blzut3|
|2018-10-08 04:16||Blzut3||Note Added: 0019997|
|2018-10-08 04:16||Blzut3||Status||assigned => needs testing|
|2018-10-08 04:17||Blzut3||Fixed in Version||=> 1.2|
|2018-10-08 08:14||WubTheCaptain||Note Added: 0020001|
|2018-10-08 10:04||WubTheCaptain||Note Added: 0020007|
|2018-10-08 10:04||WubTheCaptain||Assigned To||Blzut3 => Zalewa|
|2018-10-08 10:04||WubTheCaptain||Status||needs testing => needs review|
|2018-10-08 20:51||Zalewa||Note Added: 0020027|
|2018-10-08 20:52||Zalewa||Note Edited: 0020027||View Revisions|
|2018-10-11 17:48||Zalewa||Note Added: 0020077|
|2018-10-11 17:58||WubTheCaptain||Status||needs review => resolved|
|2018-10-11 17:58||WubTheCaptain||Resolution||open => fixed|
|2018-10-11 18:02||WubTheCaptain||Note Added: 0020078|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2018 MantisBT Team|