Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003495Doomseeker[All Projects] Suggestionpublic2018-09-18 20:272018-10-27 22:55
ReporterWubTheCaptain 
Assigned ToBlzut3 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
Platformamd64OSOpenBSDOS Version6.4-current
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003495: Cleanup CMake files to "find Qt5 the right way"
DescriptionQt 5 modules don't need to be found individually. Use "find_package(Qt5 COMPONENTS Core Widgets [...] REQUIRED)" syntax, instead of multiple lines.
Additional InformationCMake: Finding Qt 5 the "Right Way"

Found while trying to build Doomseeker 1.2~beta from source on OpenBSD -current (6.4), with failing Qt5 detection.

Qt5 support was added by Blutz3 with commit a12be25e533bb1b217e0502d6f85879c2c40e5b5.
Attached Files

- Relationships

-  Notes
User avatar (0019546)
WubTheCaptain (reporter)
2018-09-18 20:39

Doomseeker 1.0 is not affected, as it didn't support Qt5.
User avatar (0019667)
Blzut3 (administrator)
2018-09-22 22:51

Simple enough:'https://bitbucket.org/Doomseeker/doomseeker/commits/bf0945af945751e54ea3ed846e74370b29d26fe7 [^]'
User avatar (0019674)
WubTheCaptain (reporter)
2018-09-22 23:39

Bitbucket pipelines already passed this, but just to be sure I'll test on OpenBSD later.
User avatar (0019677)
WubTheCaptain (reporter)
2018-09-23 00:17

Question: Why is there a new branch "@" tagged to this commit?
User avatar (0019678)
Blzut3 (administrator)
2018-09-23 00:21

From:'https://www.mercurial-scm.org/wiki/Bookmarks [^]'
Quote
If you have a bookmark named @ when cloning a remote repository, "hg clone" will check it out by default.

While Pol M was learning to use bookmarks I noticed that we never added the default bookmark to our repo, so now we have it.
User avatar (0019681)
WubTheCaptain (reporter)
2018-09-23 00:49
edited on: 2018-09-23 00:52

As long as the @ bookmark is reasonably up to date or sensible, okay. (No idea what's the most sensible place to tag it to.)

Building on OpenBSD just became so much easier, thanks to resolving this ticket only need to export Qt5_DIR now:

export Qt5_DIR=/usr/local/lib/qt5/cmake/Qt5
cmake -DCMAKE_CXX_FLAGS='-I/usr/local/include' $DOOMSEEKER_SRC
make


(Okay, I cheated a little bit with better cmake instructions. 😄)

Compare to previous build steps:

export Qt5Widgets_DIR=/usr/local/lib/qt5/cmake/Qt5Widgets
export Qt5LinguistTools_DIR=/usr/local/lib/qt5/cmake/Qt5LinguistTools
export Qt5Multimedia_DIR=/usr/local/lib/qt5/cmake/Qt5Multimedia
export Qt5Xml_DIR=/usr/local/lib/qt5/cmake/Qt5Xml
export CPATH=$CPATH:/usr/local/include
cmake $DOOMSEEKER_SRC
make



Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-09-18 20:27 WubTheCaptain New Issue
2018-09-18 20:39 WubTheCaptain Note Added: 0019546
2018-09-18 20:42 WubTheCaptain Assigned To => Blzut3
2018-09-18 20:42 WubTheCaptain Status new => assigned
2018-09-18 20:42 WubTheCaptain Additional Information Updated View Revisions
2018-09-18 20:42 WubTheCaptain Status assigned => new
2018-09-22 22:50 Blzut3 Status new => assigned
2018-09-22 22:50 Blzut3 Target Version => 1.2
2018-09-22 22:51 Blzut3 Note Added: 0019667
2018-09-22 22:51 Blzut3 Status assigned => needs review
2018-09-22 23:38 WubTheCaptain Status needs review => needs testing
2018-09-22 23:39 WubTheCaptain Note Added: 0019674
2018-09-23 00:17 WubTheCaptain Note Added: 0019677
2018-09-23 00:21 Blzut3 Note Added: 0019678
2018-09-23 00:49 WubTheCaptain Note Added: 0019681
2018-09-23 00:49 WubTheCaptain Status needs testing => resolved
2018-09-23 00:49 WubTheCaptain Fixed in Version => 1.2
2018-09-23 00:49 WubTheCaptain Resolution open => fixed
2018-09-23 00:50 WubTheCaptain OS => OpenBSD
2018-09-23 00:50 WubTheCaptain OS Version => 6.4-current
2018-09-23 00:50 WubTheCaptain Platform => amd64
2018-09-23 00:52 WubTheCaptain Note Edited: 0019681 View Revisions
2018-09-23 00:52 WubTheCaptain Note Edited: 0019681 View Revisions
2018-10-27 22:55 WubTheCaptain Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker