Anonymous | Login | Signup for a new account | 2024-04-24 03:54 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003461 | Doomseeker | UI | public | 2018-08-24 01:29 | 2019-07-30 10:13 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | low | Severity | trivial | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | Debian GNU/Linux | OS Version | buster/sid | ||||
Product Version | 1.1 | ||||||||
Target Version | 1.3 | Fixed in Version | 1.3 | ||||||
Summary | 0003461: Right aligning decoration images/user roles (player slot styles) is done with a CustomItemDelegate hack | ||||||||
Description | The issue related to this hack is probably best to be explained with a screenshot, attached. For an introduction: Player slots are right-aligned in the server list view table ("Servers"). Some ancient code in Doomseeker handles this with CustomItemDelegate painting. The width of player block slots is 168 px wide in this case (second column in the screenshot), or 24 players. The "bounding box" (for a lack of better word... the small border around it) for this is 289 px wide, both aligned to right. There is approximately 174 px of free space on the left side of that in the screenshot, which is not part of the bounding box that would normally fill the whole width of the selected column. Coincidentally, this free space happens to be the width of the player block slot plus margin/padding. In other words, 2-player slots experience very wide "bounding box" while larger, up to 64-player slots receive very small ones (sometimes not visible) – the very reverse of what's intended, although full width would make more sense too. A server which cannot be reached (0 player slots, not shown in screenshot) has the full width, as expected. | ||||||||
Steps To Reproduce | To reproduce the effects similar to the one in the screenshot:
| ||||||||
Additional Information | This is a hack from a very long ago (2009–2011 or earlier).Quote from src/core/gui/widgets/serverlistview.cpp// If the row is selected and we are using the right aligned feature // we must now redraw the decoration. The rectangle that was used // in the previous function will cause the image to clip. // // The only other way I can think of for fixing that problem would // be to completely rewrite this class, which I really don't want // to do. Qt 5.11 used in the screenshot. Found in Doomseeker 1.1 and 1.2~beta-180821-1617M. | ||||||||
Attached Files | 3461.png [^] (7,933 bytes) 2018-08-24 01:30
3461-hint.png [^] (13,059 bytes) 2018-08-24 02:16 3461-hint-2.png [^] (17,900 bytes) 2018-08-24 02:24 | ||||||||
Relationships | |||||||||||
|
Notes | |
(0019393) WubTheCaptain (reporter) 2018-08-24 02:17 edited on: 2018-08-24 02:33 |
For better accessibility, I've also attached a photo manipulation (3461-hint.png) which displays the "bounding box" with a gradient of stripes. 3461-hint-2.png shows the left margin of the bounding box is the same as the width of the slots (as if they were left-aligned). For clarification, the stripes should be the full width of the column but this hack paints them wrongly. |
(0019394) WubTheCaptain (reporter) 2018-08-24 02:39 edited on: 2018-08-24 02:41 |
Also there's no margin whatsoever on the right side of slots due to this hack (?). Expected 3 px. |
(0020508) WubTheCaptain (reporter) 2019-04-19 18:31 |
This issue has not seen activity in a while; can anyone confirm or acknowledge this issue? |
(0020518) Pol M (developer) 2019-04-20 12:12 edited on: 2019-06-05 14:41 |
Can confirm the issue in my Arch machine (there are themes of qt5 that do not show the box), and I'm quite sure that I also saw this on Windows. This box is actually caused by the free space, it works kinda like this: initially the columns are left aligned, causing an empty box to appear on the right. When the player slots are moved to the right, the empty box stays there. Why are the slots right aligned? I'm asking because looking at the problem I'm not even sure how it should be fixed. If it is not possible to solve, maybe we will have to determine what we prefer: the alignment or the slightly unpleasant graphical bug. |
(0020840) Zalewa (developer) 2019-06-25 21:43 |
CustomItemDelegate hack has been hacked even more to not show the focus rectangle in columns for the game and for players. Here's the commit that does that:'https://bitbucket.org/Doomseeker/doomseeker/commits/bdecbb4d527ea2c8956ae00729d2dc4cb0ce74ad [^]' To be frank I'm thinking that this focus rectangle is useless in this whole table so perhaps this hacky hack should apply to all the columns? |
(0020871) Pol M (developer) 2019-07-12 12:14 |
Tested, it works pretty well, the rectangle no longer appears.Quote from Zalewa I'd say that for consistency this should be desired. I'll move this to assigned. |
(0020873) WubTheCaptain (reporter) 2019-07-12 18:19 |
Quote from Pol M The issue in OP is either unresolved (we still use the hack) or resolved (a working workaround was committed). I'd prefer to leave this issue as resolved in such case. |
(0020875) WubTheCaptain (reporter) 2019-07-12 18:34 |
In a theorized big picture, I would be curious to know how the player slots are aligned in right-to-left languages (no localizations implemented yet). |
(0020876) Zalewa (developer) 2019-07-12 20:22 edited on: 2019-07-12 20:23 |
I'll agree with Wub here that this matter is resolved. The matter of having the focus rectangle in server table at all is now in ticket 0003677. As far as RTL goes - I've no idea. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2018-08-24 01:29 | WubTheCaptain | New Issue | |
2018-08-24 01:30 | WubTheCaptain | File Added: 3461.png | |
2018-08-24 01:30 | WubTheCaptain | Additional Information Updated | View Revisions |
2018-08-24 01:32 | WubTheCaptain | Description Updated | View Revisions |
2018-08-24 01:35 | WubTheCaptain | Description Updated | View Revisions |
2018-08-24 01:38 | WubTheCaptain | Description Updated | View Revisions |
2018-08-24 01:38 | WubTheCaptain | Description Updated | View Revisions |
2018-08-24 01:40 | WubTheCaptain | Additional Information Updated | View Revisions |
2018-08-24 02:15 | WubTheCaptain | File Added: 3461-hint.png | |
2018-08-24 02:15 | WubTheCaptain | File Deleted: 3461-hint.png | |
2018-08-24 02:16 | WubTheCaptain | File Added: 3461-hint.png | |
2018-08-24 02:17 | WubTheCaptain | Note Added: 0019393 | |
2018-08-24 02:17 | WubTheCaptain | Note Edited: 0019393 | View Revisions |
2018-08-24 02:24 | WubTheCaptain | File Added: 3461-hint-2.png | |
2018-08-24 02:26 | WubTheCaptain | Note Edited: 0019393 | View Revisions |
2018-08-24 02:26 | WubTheCaptain | Note Edited: 0019393 | View Revisions |
2018-08-24 02:33 | WubTheCaptain | Note Edited: 0019393 | View Revisions |
2018-08-24 02:39 | WubTheCaptain | Note Added: 0019394 | |
2018-08-24 02:41 | WubTheCaptain | Note Edited: 0019394 | View Revisions |
2018-08-24 02:48 | WubTheCaptain | Description Updated | View Revisions |
2018-08-24 02:52 | WubTheCaptain | Relationship added | related to 0003462 |
2018-10-05 06:36 | WubTheCaptain | Priority | normal => low |
2018-12-04 00:40 | WubTheCaptain | Category | Bug => UI |
2019-04-19 18:31 | WubTheCaptain | Note Added: 0020508 | |
2019-04-20 12:12 | Pol M | Note Added: 0020518 | |
2019-04-20 12:12 | Pol M | Assigned To | => Pol M |
2019-04-20 12:12 | Pol M | Status | new => acknowledged |
2019-04-20 12:12 | Pol M | Assigned To | Pol M => |
2019-04-20 12:12 | Pol M | Status | acknowledged => confirmed |
2019-06-05 14:23 | Pol M | Note Edited: 0020518 | View Revisions |
2019-06-05 14:41 | Pol M | Note Edited: 0020518 | View Revisions |
2019-06-05 14:41 | Pol M | Note Edited: 0020518 | View Revisions |
2019-06-25 21:43 | Zalewa | Note Added: 0020840 | |
2019-06-25 21:43 | Zalewa | Assigned To | => Zalewa |
2019-06-25 21:43 | Zalewa | Status | confirmed => needs review |
2019-06-26 02:55 | WubTheCaptain | Target Version | => 1.3 |
2019-07-02 21:26 | Zalewa | Status | needs review => needs testing |
2019-07-12 12:14 | Pol M | Note Added: 0020871 | |
2019-07-12 12:14 | Pol M | Status | needs testing => assigned |
2019-07-12 18:19 | WubTheCaptain | Note Added: 0020873 | |
2019-07-12 18:34 | WubTheCaptain | Note Added: 0020875 | |
2019-07-12 20:22 | Zalewa | Note Added: 0020876 | |
2019-07-12 20:22 | Zalewa | Status | assigned => resolved |
2019-07-12 20:22 | Zalewa | Fixed in Version | => 1.3 |
2019-07-12 20:22 | Zalewa | Resolution | open => fixed |
2019-07-12 20:23 | Zalewa | Note Edited: 0020876 | View Revisions |
2019-07-12 20:23 | Zalewa | Relationship added | related to 0003677 |
2019-07-30 10:13 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |