Zandronum Chat on our Discord Server Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003018Zandronum[All Projects] Bugpublic2017-02-19 01:032019-06-04 21:54
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityhave not tried
PlatformOSOS Version
Product Version2.1 
Target VersionFixed in Version 
Summary0003018: Master server leaks memory
DescriptionNETBUFFER_s does not destroy its buffer when deleted, but relies on its Free method being called. Master server's BanlistPacketSender does not do this. As a result, 1KiB of memory is leaked every time the master server sends the banlist to a server. Since there's hundreds of servers, this must tally up to hundreds of kilobytes lost quickly enough.

Note: I don't know how to actually test it. But this seems like a glaring problem and I can't see how this cannot be happening.

The master server as is locks up mysteriously and needs to be restarted all the time. Maybe this is why?

I noticed this by doing some refactor on the network classes and decided to make NETBUFFER_s have a destructor. I noticed that this makes every single Free() calls unnecessary and allows removal of a lot of code.
Attached Files

- Relationships

-  Notes
User avatar (0016877)
Dusk (developer)
2017-02-19 01:07

Argh! NETBUFFER_s can have a stack buffer too. So it cannot have a destructor since it's not encapsulated enough.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Combinebobnt
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-02-19 01:03 Dusk New Issue
2017-02-19 01:03 Dusk Status new => assigned
2017-02-19 01:03 Dusk Assigned To => Dusk
2017-02-19 01:07 Dusk Note Added: 0016877
2019-06-04 21:54 Dusk Status assigned => new

Questions or other issues? Contact Us.


Copyright © 2000 - 2021 MantisBT Team
Powered by Mantis Bugtracker