0002878: OpenGL Models Broken

(0015885)
Torr Samaho (administrator)
2016-10-10 17:29

Models seem to work fine for me (I only tested a player model). Are you sure you have gl_use_models set to 1?

(0015895)
Unknown (reporter)
2016-10-11 12:10

Works fine here, I Suppose the mod you're trying to load is replacing the models with it's own sprites or simply does not work with models .

(0015935)
SiulAnul (reporter)
2016-10-12 22:51

correction: the problem is with weapon models. monster and player models work fine.

(0015936)
SiulAnul (reporter)
2016-10-12 22:55

and i am loading ONLY DSmodels in screenshot.

(0015937)
Edward-san (developer)
2016-10-12 23:27

Does it happen with GZDoom 1.8.6?

(0015940)
SiulAnul (reporter)
2016-10-12 23:47

it freezes when i load ds models with models turned on

(0015947)
Torr Samaho (administrator)
2016-10-13 06:26

With ST-Models-Complete.pk3 I can reproduce the problem with the HUD models. Needs skulltag_actors.pk3 and skulltag_data_126.pk3 loaded. Can somebody check when this broke?

(0015951)
unknownna (updater)
2016-10-13 07:25

It's broken and crashes in the first official 3.0 alpha build (150819-2351) for me.

Execution could not continue.

Script error, "st-models-complete.pk3:modeldef.skulltag.itmes.def" line 17:
MODELDEF: Unknown actor type 'RegenerationRune'

I have some builds earlier than that (150517-2229 and 150718-1852), where it's partially broken: The chaingun, minigun and BFG10K models appear out of all the weapon models.

zandronum -iwad doom2.wad -file skulltag_actors_1-1-1.pk3 skulltag_data_126.pk3 st-models-complete.pk3 +vid_renderer 1 +gl_use_models 1 +map map01

(0015953)
SiulAnul (reporter)
2016-10-13 10:27

a guy on the tspg irc, where i had first reported this problem, said he had written some bad MODELDEF code.

(0015955)
WaTaKiD (updater)
2016-10-13 17:11

this is the one: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/39019a620b136427f460b60b220b2223235abf0e [^]'

(0015956)
Torr Samaho (administrator)
2016-10-13 17:43

Quote from unknownna

zandronum -iwad doom2.wad -file skulltag_actors_1-1-1.pk3 skulltag_data_126.pk3 st-models-complete.pk3 +vid_renderer 1 +gl_use_models 1 +map map01

The newer 3.0 versions are not compatible with old versions of skulltag_actors. In general, any Zandronum build should only be used with the version of skulltag_actors.pk3 it is bundled with.

Quote from WaTaKiD

this is the one:'https://bitbucket.org/Torr_Samaho/zandronum/commits/39019a620b136427f460b60b220b2223235abf0e

[^]'
Hmm, if I compile that revision, I can't even start Zandronum with skulltag_actors.pk3, skulltag_data_126.pk3 and ST-Models-Complete.pk3 loaded.

Can somebody condense ST-Models-Complete.pk3 to a minimal example wad? It should be sufficient if the example contains a single non-working HUD model for a standard Doom weapon and nothing else. This way we can also test it in GZDoom 1.8.6.

(0015957)
WaTaKiD (updater)
2016-10-13 18:04

iirc there was a change to zan + skulltag_actors (plans to drop it and let hypnotoad take care of it with skulltag_content, i believe) at some point, so i used skulltag_actors that comes with zan with some newer builds, but much older ones (such as with the commit i linked here) i instead used skulltag_actors_1-1-1

(0015985)
SiulAnul (reporter)
2016-10-14 10:18

why is qstuff working though? it uses models too.

(0015989)
unknownna (updater)
2016-10-14 14:31
edited on: 2016-10-14 14:32

I stripped down ST-Models-Complete.pk3 to the pistol. From what I can tell it seems to be a GZDoom issue. Even loading HUDmodelbug.zip in GZDoom 2.2.0 crashes it when loading a map.

(0015993)
Torr Samaho (administrator)
2016-10-14 18:06

I had a look at the example wad and noticed that it uses the property "zoffset". IIRC that's a Skulltag/Zandronum only property. I added it before GZDoom added the "offset" property. That's most likely why GZDoom can't use the file.

(0015994)
Torr Samaho (administrator)
2016-10-14 18:16

I think I know what's happening. The MODELDEF code in the example file uses invisible non-ASCII characters. If you delete those, the wad is working fine again.

ZDoom's parser got more strict and doesn't accept those anymore. So, technically, this is a bug of the wad. Old ZDoom versions just didn't notice it.

(0015995)
WaTaKiD (updater)
2016-10-14 18:33

sounds similar to'http://zandronum.com/tracker/view.php?id=2722#c14794 [^]' then

(0017095)
Torr Samaho (administrator)
2017-04-08 12:19

Since this is an error of the mod noticed by the stricter ZDoom parser in 3.0, I'm closing this. ZDoom apparently decided to break compatibility with mods affected by these syntax errors, so 3.0 is behaving as intended.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Notes
(0015885) Torr Samaho (administrator) 2016-10-10 17:29	Models seem to work fine for me (I only tested a player model). Are you sure you have gl_use_models set to 1?

(0015895) Unknown (reporter) 2016-10-11 12:10	Works fine here, I Suppose the mod you're trying to load is replacing the models with it's own sprites or simply does not work with models .

(0015935) SiulAnul (reporter) 2016-10-12 22:51	correction: the problem is with weapon models. monster and player models work fine.

(0015936) SiulAnul (reporter) 2016-10-12 22:55	and i am loading ONLY DSmodels in screenshot.

(0015937) Edward-san (developer) 2016-10-12 23:27	Does it happen with GZDoom 1.8.6?

(0015940) SiulAnul (reporter) 2016-10-12 23:47	it freezes when i load ds models with models turned on

(0015947) Torr Samaho (administrator) 2016-10-13 06:26	With ST-Models-Complete.pk3 I can reproduce the problem with the HUD models. Needs skulltag_actors.pk3 and skulltag_data_126.pk3 loaded. Can somebody check when this broke?

(0015951) unknownna (updater) 2016-10-13 07:25	It's broken and crashes in the first official 3.0 alpha build (150819-2351) for me. Execution could not continue. Script error, "st-models-complete.pk3:modeldef.skulltag.itmes.def" line 17: MODELDEF: Unknown actor type 'RegenerationRune' I have some builds earlier than that (150517-2229 and 150718-1852), where it's partially broken: The chaingun, minigun and BFG10K models appear out of all the weapon models. zandronum -iwad doom2.wad -file skulltag_actors_1-1-1.pk3 skulltag_data_126.pk3 st-models-complete.pk3 +vid_renderer 1 +gl_use_models 1 +map map01

(0015953) SiulAnul (reporter) 2016-10-13 10:27	a guy on the tspg irc, where i had first reported this problem, said he had written some bad MODELDEF code.

(0015955) WaTaKiD (updater) 2016-10-13 17:11	this is the one: 'https://bitbucket.org/Torr_Samaho/zandronum/commits/39019a620b136427f460b60b220b2223235abf0e [^]'

(0015956) Torr Samaho (administrator) 2016-10-13 17:43	Quote from unknownna zandronum -iwad doom2.wad -file skulltag_actors_1-1-1.pk3 skulltag_data_126.pk3 st-models-complete.pk3 +vid_renderer 1 +gl_use_models 1 +map map01 The newer 3.0 versions are not compatible with old versions of skulltag_actors. In general, any Zandronum build should only be used with the version of skulltag_actors.pk3 it is bundled with. Quote from WaTaKiD this is the one:'https://bitbucket.org/Torr_Samaho/zandronum/commits/39019a620b136427f460b60b220b2223235abf0e [^]' Hmm, if I compile that revision, I can't even start Zandronum with skulltag_actors.pk3, skulltag_data_126.pk3 and ST-Models-Complete.pk3 loaded. Can somebody condense ST-Models-Complete.pk3 to a minimal example wad? It should be sufficient if the example contains a single non-working HUD model for a standard Doom weapon and nothing else. This way we can also test it in GZDoom 1.8.6.

(0015957) WaTaKiD (updater) 2016-10-13 18:04	iirc there was a change to zan + skulltag_actors (plans to drop it and let hypnotoad take care of it with skulltag_content, i believe) at some point, so i used skulltag_actors that comes with zan with some newer builds, but much older ones (such as with the commit i linked here) i instead used skulltag_actors_1-1-1

(0015985) SiulAnul (reporter) 2016-10-14 10:18	why is qstuff working though? it uses models too.

(0015989) unknownna (updater) 2016-10-14 14:31 edited on: 2016-10-14 14:32	I stripped down ST-Models-Complete.pk3 to the pistol. From what I can tell it seems to be a GZDoom issue. Even loading HUDmodelbug.zip in GZDoom 2.2.0 crashes it when loading a map.

(0015993) Torr Samaho (administrator) 2016-10-14 18:06	I had a look at the example wad and noticed that it uses the property "zoffset". IIRC that's a Skulltag/Zandronum only property. I added it before GZDoom added the "offset" property. That's most likely why GZDoom can't use the file.

(0015994) Torr Samaho (administrator) 2016-10-14 18:16	I think I know what's happening. The MODELDEF code in the example file uses invisible non-ASCII characters. If you delete those, the wad is working fine again. ZDoom's parser got more strict and doesn't accept those anymore. So, technically, this is a bug of the wad. Old ZDoom versions just didn't notice it.

(0015995) WaTaKiD (updater) 2016-10-14 18:33	sounds similar to'http://zandronum.com/tracker/view.php?id=2722#c14794 [^]' then

(0017095) Torr Samaho (administrator) 2017-04-08 12:19	Since this is an error of the mod noticed by the stricter ZDoom parser in 3.0, I'm closing this. ZDoom apparently decided to break compatibility with mods affected by these syntax errors, so 3.0 is behaving as intended.

Issue History
Date Modified	Username	Field	Change
2016-10-10 16:21	SiulAnul	New Issue
2016-10-10 17:29	Torr Samaho	Note Added: 0015885
2016-10-10 17:29	Torr Samaho	Status	new => feedback
2016-10-11 12:10	Unknown	Note Added: 0015895
2016-10-12 22:51	SiulAnul	Note Added: 0015935
2016-10-12 22:51	SiulAnul	Status	feedback => new
2016-10-12 22:54	SiulAnul	File Added: Screenshot_Doom_20161012_185709.png
2016-10-12 22:55	SiulAnul	Note Added: 0015936
2016-10-12 23:27	Edward-san	Note Added: 0015937
2016-10-12 23:27	Edward-san	Status	new => feedback
2016-10-12 23:47	SiulAnul	Note Added: 0015940
2016-10-12 23:47	SiulAnul	Status	feedback => new
2016-10-13 06:26	Torr Samaho	Note Added: 0015947
2016-10-13 06:26	Torr Samaho	Assigned To	=> Torr Samaho
2016-10-13 06:26	Torr Samaho	Status	new => feedback
2016-10-13 07:25	unknownna	Note Added: 0015951
2016-10-13 07:27	unknownna	Steps to Reproduce Updated	View Revisions
2016-10-13 10:27	SiulAnul	Note Added: 0015953
2016-10-13 10:27	SiulAnul	Status	feedback => assigned
2016-10-13 17:11	WaTaKiD	Note Added: 0015955
2016-10-13 17:43	Torr Samaho	Note Added: 0015956
2016-10-13 18:04	WaTaKiD	Note Added: 0015957
2016-10-14 10:18	SiulAnul	Note Added: 0015985
2016-10-14 10:18	SiulAnul	File Added: Screenshot_Doom_20161014_062146.png
2016-10-14 14:19	unknownna	File Added: HUDmodelbug.zip
2016-10-14 14:31	unknownna	Note Added: 0015989
2016-10-14 14:31	unknownna	Steps to Reproduce Updated	View Revisions
2016-10-14 14:32	unknownna	Note Edited: 0015989	View Revisions
2016-10-14 18:06	Torr Samaho	Note Added: 0015993
2016-10-14 18:16	Torr Samaho	Note Added: 0015994
2016-10-14 18:33	WaTaKiD	Note Added: 0015995
2016-12-24 22:42	Dusk	Target Version	=> 3.0
2017-04-08 12:19	Torr Samaho	Note Added: 0017095
2017-04-08 12:19	Torr Samaho	Status	assigned => closed
2017-04-08 12:20	Torr Samaho	Resolution	open => no change required

Relationships