0002798: Thing Z position incorrect on respawned items.

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002798

Zandronum

[All Projects] Bug

public

2016-07-30 20:20

2018-09-30 22:34

Reporter

Borg

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

2.1

Target Version

Fixed in Version

Summary

0002798: Thing Z position incorrect on respawned items.

Description

Seems that SpawnPoint[2] is not properly initialized on Spawn chain.
(Or Z pos is reset to FLOORZ somehow?)

We have a MapSpot on map with Z position.
Then we do: SpawnSpot() -> RandomSpawner -> Item
On map start item is positioned properly but after respawn
it lands on floor, not on 3dfloor as we wanted.

Steps To Reproduce

Download:
'ftp://borg.uu3.net/home/borg/tmp/3DFLOOR.WAD [^]'
'ftp://borg.uu3.net/home/borg/tmp/chaingun.wad [^]'

Start zandronum: -file chaingun.wad -file 3DFLOOR.WAD +sv_itemrespawn 1
Now aproach lift, go to the roof and pickup chaingun.
Wait for respawn sound... Go to the bottom and open door,
you will find respawned chaingun here.

Attached Files

Relationships

Notes
(0015417) Borg (reporter) 2016-07-30 21:21	Okey, after long digging in source code of zandronum, I suspect this one to be guilty: bool AInventory::DoRespawn () z = floorz; <- why its here? I checked code under AActor P_SpawnMapThing (FMapThing mthing, int position) and its calls P_FindFloorCeiling(mobj, true) to locate any 3D floors. While later, StaticSpawn(...) uses Z from RandomSpawner (Z itself + SpawnPoint[2] updated), floorz unfortunatly is incorrectly calculated by StaticSpawn itself: actor->floorz = actor->Sector->floorplane.ZatPoint (ix, iy); Question is, why that z=floorz is there? It fixes anything else? Of course, I can be totaly wrong about it.

(0015418) Edward-san (developer) 2016-07-31 10:40	Please check GZDoom 1.8.6 and latest zandronum 3.0 beta.

(0015419) Borg (reporter) 2016-07-31 11:47	I checked 3.0 build 160519-2047 and it works fine. So it seems its fixed.

(0015671) Ru5tK1ng (updater) 2016-09-20 01:09	Based on that, I'll mark this as resolved.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-07-30 20:20	Borg	New Issue
2016-07-30 20:37	WaTaKiD	Steps to Reproduce Updated	View Revisions
2016-07-30 21:21	Borg	Note Added: 0015417
2016-07-31 10:40	Edward-san	Note Added: 0015418
2016-07-31 10:40	Edward-san	Status	new => feedback
2016-07-31 11:47	Borg	Note Added: 0015419
2016-07-31 11:47	Borg	Status	feedback => new
2016-09-20 01:09	Ru5tK1ng	Note Added: 0015671
2016-09-20 01:09	Ru5tK1ng	Status	new => resolved
2016-09-20 01:09	Ru5tK1ng	Resolution	open => fixed
2018-09-30 22:34	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.