Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002724Zandronum[All Projects] Bugpublic2016-05-03 20:512018-09-30 21:57
ReporterZalewa 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002724: Blinking sectors with 256 brightness blink to darkness online.
DescriptionWhen sector brightness is set to 256 some of the standard Doom lighting effects (flicker and blink, but not glow) will cause the sector to blink between complete darkness and brightness of the adjacent sector. This happens only online. Tested with build 3.0-alpha-r160131-2023. Correct behavior can be achieved by a workaround of lowering the sector brightness level to 255.
Steps To Reproduce1. Download attached sector_lights.wad
2. Run this WAD on server in cooperative mode (MAP01).
3. Join the server and observe.
4. Then run this WAD in offline mode and observe again - problem should go away.
Additional InformationI have checked with Zandronum 2.1.2, Chocolate Doom and vanilla Doom. All of them work correctly with brightness 256.
Attached Files? file icon sector_lights.wad [^] (5,303 bytes) 2016-05-03 20:51

- Relationships

-  Notes
User avatar (0014819)
Edward-san (developer)
2016-05-04 17:21
edited on: 2016-05-04 17:25

 The network code assumes that the light value is in the range [0-255], so of course setting the brightness to 256 won't work. In 2.1, the minlight and the maxlight values were clamped between 0 and 255, so this is why the issue didn't show up before.

BTW: the involved zdoom change is r3223.
User avatar (0014820)
Edward-san (developer)
2016-05-04 18:14
edited on: 2016-05-04 18:15

 I reread the discussion which brought that fix:'http://forum.zdoom.org/viewtopic.php?f=7&t=29993 [^]' , it seems that it's possible to have the brightness values even greater than 256 (technically in the 'short int' range) since vanilla doom (see esselfortium's post in the next page) so it's necessary to raise the bandwidth consumption as needed.
User avatar (0014821)
Edward-san (developer)
2016-05-04 19:10

 Fixed with this pull request.

Incidentally, I noticed a bug in zdoom's code which didn't clamp the light values for the light flicker code and made a bug report here.
User avatar (0014822)
Zalewa (developer)
2016-05-04 20:20

 Won't sending a short instead of a byte increase the bandwidth consumption needed during the entire game? Perhaps, while technically incorrect, it would've been more practical to clamp the value to 255 and keep sending it as a byte? I don't know if there's any case where brightness above 256 is used
User avatar (0014823)
Edward-san (developer)
2016-05-04 21:55
edited on: 2016-05-04 22:00

 The only action which could give problems in term of bandwidth is the glowing light one (commit history doesn't tell me why each tic the server must send an update for the DGlow2 action...). Nevermind that. The additional bandwidth usage is either 1 or 2 bytes per action start/stop, so it's not a big deal.
User avatar (0014833)
Torr Samaho (administrator)
2016-05-08 19:09

 Do you know of any map where spending the additional byte makes a visible lighting difference?
User avatar (0014841)
Edward-san (developer)
2016-05-08 20:57

 Clarified via IRC. Added the fix with changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/422433728c1fd2c7d0c435c02f3589a2a4c8f6c7 [^]' . Added the zdoom fix with changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/c7646bd1657d11f6f8a6d68ec7498085501b791e [^]' .
User avatar (0014871)
Ru5tK1ng (updater)
2016-05-11 22:29

 Tested this online with r160510-1827 and the light effects appeared to be the same as offline effects.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-05-03 20:51 Zalewa New Issue
2016-05-03 20:51 Zalewa File Added: sector_lights.wad
2016-05-04 17:21 Edward-san Note Added: 0014819
2016-05-04 17:25 Edward-san Note Edited: 0014819 View Revisions
2016-05-04 18:14 Edward-san Note Added: 0014820
2016-05-04 18:14 Edward-san Assigned To => Edward-san
2016-05-04 18:14 Edward-san Status new => assigned
2016-05-04 18:15 Edward-san Note Edited: 0014820 View Revisions
2016-05-04 19:10 Edward-san Note Added: 0014821
2016-05-04 19:10 Edward-san Status assigned => needs review
2016-05-04 20:20 Zalewa Note Added: 0014822
2016-05-04 21:55 Edward-san Note Added: 0014823
2016-05-04 21:56 Edward-san Note Edited: 0014823 View Revisions
2016-05-04 22:00 Edward-san Note Edited: 0014823 View Revisions
2016-05-04 22:00 Edward-san Note Edited: 0014823 View Revisions
2016-05-08 19:09 Torr Samaho Note Added: 0014833
2016-05-08 19:10 Torr Samaho Status needs review => feedback
2016-05-08 20:57 Edward-san Note Added: 0014841
2016-05-08 20:57 Edward-san Status feedback => needs testing
2016-05-11 22:29 Ru5tK1ng Note Added: 0014871
2016-05-11 22:29 Ru5tK1ng Status needs testing => resolved
2016-05-11 22:29 Ru5tK1ng Resolution open => fixed
2016-05-11 22:29 Ru5tK1ng Fixed in Version => 3.0
2016-05-11 22:29 Ru5tK1ng Target Version => 3.0
2016-11-20 21:35 Edward-san Product Version 3.0 => 3.0-beta
2018-09-30 21:57 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker