Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002445Zandronum[All Projects] Suggestionpublic2015-09-07 06:312024-01-29 18:47
Reportercybermind 
Assigned ToTorr Samaho 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target VersionFixed in Version 
Summary0002445: Backport HITTARGET, HITMASTER and HITTRACER
DescriptionI want to ask if it's possible to backport this revision'http://zdoom.org/Changelog/533ae95/files [^]' to the next Zandronum alpha build? I want to port my ZDoom mod to Zandronum but currently this is impossible because my mod uses these flags a lot.
This revision features 3 actor flags - HITTARGET, HITMASTER and HITTRACER (defined in flags7 bit field) and 3 lines of actor pointer rearrangement in p_mobj.cpp, so I think it won't be a problem to backport this.
Attached Files

- Relationships

-  Notes
User avatar (0014760)
Fused (reporter)
2016-04-27 20:44

 This is also extremely neccesary for my mod and without will cause many problems here. It would be great if this was backported because it allows for some really useful features which my mod needs.
User avatar (0014765)
Leonard (developer)
2016-04-28 18:41

 Here is a chronologically ordered list of the commits that concern these flags:
'https://github.com/coelckers/gzdoom/commit/533ae959336a4cd7a2e5c2580c70c3bf81294e70 [^]'
'https://github.com/coelckers/gzdoom/commit/b6c5cfb9efc8f398d09cbbfde3da653bdb968eaf [^]'
'https://github.com/coelckers/gzdoom/commit/fc05a3bb2f602182d7195cd7cb7603ce018b2e84 [^]'
'https://github.com/coelckers/gzdoom/commit/24f1bfae99c6d2d79bac8fb9f0bdc296b5aaee0d [^]'
'https://github.com/coelckers/gzdoom/commit/31ad6428436216b20bd04bb7810dc261ec287552 [^]'
'https://github.com/coelckers/gzdoom/commit/519ff8b7d114b6d38ba0813b8d7f509ef6e6329c [^]'
All of them were done in the span of less than a month.
Specifically the bulletpuff handling addition is extremely useful.
User avatar (0015241)
Torr Samaho (administrator)
2016-07-09 17:34

 Since these flags really seem to be quite useful, I had a look at the backports. Unfortunately, the merging required numerous conflicts to be resolved manually, but I think it is all worked out now. I pushed the result to the sandbox:'https://bitbucket.org/zandronum/zandronum-sandbox/ [^]'

Please test if it works properly. If it does, I can pull the additions to 3.0.
User avatar (0015243)
Edward-san (developer)
2016-07-09 18:01

 AFAIR there were also some fixes to issues caused by these changes (the history must be checked, though I cannot right now).
User avatar (0015296)
Torr Samaho (administrator)
2016-07-12 18:56

 Did you have a chance to check the history yet? Judging from the code changes, I'd they shouldn't cause any problems as long as none of the new flags are used.
User avatar (0015297)
Dusk (developer)
2016-07-12 20:18
edited on: 2016-07-12 20:22

 The branch for storing logins for ticket 0002763 was based off the commits stored for this branch, so I closed the head involved. The commits can be found at bookmark 'hittarget-2445'. Unfortunately I cannot re-transplant the changesets onto the same parent.
User avatar (0015301)
Edward-san (developer)
2016-07-12 22:20
Quote
Did you have a chance to check the history yet? Judging from the code changes, I'd they shouldn't cause any problems as long as none of the new flags are used.


I've had a look at it and indeed I found nothing relevant.
User avatar (0023037)
Ru5tK1ng (updater)
2024-01-29 18:47

 These were added in 3.0.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Leonard Fused
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-09-07 06:31 cybermind New Issue
2016-04-27 20:44 Fused Note Added: 0014760
2016-04-28 18:41 Leonard Note Added: 0014765
2016-05-01 20:55 Dusk Summary Backport zdoom revision 533ae95 => Backport HITTARGET, HITMASTER and HITTRACER
2016-07-09 17:34 Torr Samaho Note Added: 0015241
2016-07-09 17:34 Torr Samaho Assigned To => Torr Samaho
2016-07-09 17:34 Torr Samaho Status new => feedback
2016-07-09 18:01 Edward-san Note Added: 0015243
2016-07-12 18:56 Torr Samaho Note Added: 0015296
2016-07-12 20:18 Dusk Note Added: 0015297
2016-07-12 20:21 Dusk Note Edited: 0015297 View Revisions
2016-07-12 20:22 Dusk Note Edited: 0015297 View Revisions
2016-07-12 22:20 Edward-san Note Added: 0015301
2024-01-29 18:47 Ru5tK1ng Note Added: 0023037
2024-01-29 18:47 Ru5tK1ng Status feedback => resolved
2024-01-29 18:47 Ru5tK1ng Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker