0002363: COUNTSECRET actors are not handled properly online

Notes
(0013138) cobalt (updater) 2015-08-09 09:40	Issue addressed by commit 450e3dc28ce8: Fixed: The COUNTSECRET flag was not handled online (fixes 2363). Note: This also fixes that newly connecting clients were not properly informed about the secrets that were already revealed. Committed by Benjamin Berkels [Torr Samaho] on Sunday 09 August 2015 11:38:35 Changes in files: docs/zandronum-history.txt \| 1 + src/cl_main.cpp \| 6 ++++++ src/network_enums.h \| 1 + src/p_spec.cpp \| 35 +++++++++++++++++++++-------------- src/sv_commands.cpp \| 9 +++++++++ src/sv_commands.h \| 1 + src/sv_main.cpp \| 4 +++- src/thingdef/thingdef_codeptr.cpp \| 4 ++++ 8 files changed, 46 insertions(+), 15 deletions(-)

(0013139) Torr Samaho (administrator) 2015-08-09 09:40	This should be fixed now. The fix also fixes the ancient issue that newly connecting clients were not informed about the secrets that were already revealed. I had to change the secret handling from client side to server side for this, so possibly some things still need to be adjusted.

(0013140) Edward-san (developer) 2015-08-09 09:52 edited on: 2015-08-09 09:54	Quote from Torr Samaho The fix also fixes the ancient issue that newly connecting clients were not informed about the secrets that were already revealed. I believe clients were never updated about the players' revealed secrets, unless a spectator spies a player which does the revealing, so imho this doesn't seem to be useful. Even if it were useful, each player reveals its own secrets, so the found secret count would be different for each player, so this informing the clients idea seems to be inconsistent.

(0013835) Ru5tK1ng (updater) 2015-11-17 03:53	Why would players have separate secret counts? I'm certain players share the same pool in coop. What instance are you specifically referring to? As for the test case, it updates the count correctly online with a message and the count is correct after leaving the server.

(0013861) Edward-san (developer) 2015-11-20 00:22	Yeah, after making that comment, I asked in the zdoom forum about this (multiplayer zdoom does the same as zandronum) the whole thing was just not a bug.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-07-26 19:53	Edward-san	New Issue
2015-07-26 19:54	Edward-san	File Added: decorate.txt
2015-08-09 08:50	Torr Samaho	Assigned To	=> Torr Samaho
2015-08-09 08:50	Torr Samaho	Status	new => assigned
2015-08-09 09:40	cobalt	Status	assigned => needs testing
2015-08-09 09:40	cobalt	Target Version	=> 3.0
2015-08-09 09:40	cobalt	Steps to Reproduce Updated	View Revisions
2015-08-09 09:40	cobalt	Note Added: 0013138
2015-08-09 09:40	Torr Samaho	Note Added: 0013139
2015-08-09 09:52	Edward-san	Note Added: 0013140
2015-08-09 09:54	Edward-san	Note Edited: 0013140	View Revisions
2015-11-17 03:53	Ru5tK1ng	Note Added: 0013835
2015-11-20 00:22	Edward-san	Note Added: 0013861
2015-12-07 02:09	Ru5tK1ng	Status	needs testing => resolved
2015-12-07 02:09	Ru5tK1ng	Resolution	open => fixed
2015-12-07 02:09	Ru5tK1ng	Fixed in Version	=> 3.0
2015-12-07 02:09	Ru5tK1ng	Steps to Reproduce Updated	View Revisions
2018-09-30 22:15	Blzut3	Status	resolved => closed

Relationships