Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002341Zandronum[All Projects] Suggestionpublic2015-07-11 19:422018-09-30 21:40
ReporterVisual Vincent 
Assigned ToEdward-san 
PrioritynormalSeveritytweakReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version2.1Fixed in Version2.2 
Summary0002341: ACS function to restart the current map.
DescriptionI would like to have a function to restart the current map, but still keeping all your items and stats etc. I am currently working on a Cooperative based mod where I want to include the option to play at the same map for a specified amount of rounds. When each round is over the map would restart. ResetMap() won't do it since it's not compatible with Cooperative and also because it won't respawn dead players or spectators if used in another gamemode.

I have tried to use the ChangeLevel function but it crashes in multiplayer. It does only appear to work in singleplayer.
Attached Fileslog file icon zandronum-crash-07_12_2015-14_46_56.3750.log [^] (28,019 bytes) 2015-07-12 12:50

- Relationships

-  Notes
User avatar (0012855)
Edward-san (developer)
2015-07-11 20:05
edited on: 2015-07-11 20:29
Quote from "Visual Vincent"
I have tried to use the ChangeLevel function but it crashes in multiplayer. It does only appear to work in singleplayer.


Can you elaborate on this and why it's not reported as a bug?

Anyways, is the crash easy to reproduce with a simple example wad?

[edit]I and WaTaKiD tried with this acs script:


#include "zcommon.acs"

script 1 open
{
    delay(100);
    // The level would be automatically changed only in case we're at map01.
    if (GetLevelInfo(LEVELINFO_LEVELNUM) == 1)
        ChangeLevel("map02",0,CHANGELEVEL_NOINTERMISSION);
}


And could not reproduce it:
Quote

<WaTaKiD> local server, coop, 2.1: no crashes from it switches from map01 to map02, either as a spectator or player
User avatar (0012856)
Visual Vincent (reporter)
2015-07-11 20:41
edited on: 2015-07-11 20:42

 I tested ChangeLevel with bots in my mod... I see now after testing it standalone, and not in my mod, it works great. Then there's something about my scripts that do not want to work properly when attempting to switch map.

Using StrParam and ChangeLevel it is possible to change to the same level, so please remove my statement about ChangeLevel not working (I can't seem to edit the ticket myself?).
Or if you'd like, you can close/remove the ticket completely as I now got ChangeLevel working. :)
User avatar (0012866)
Edward-san (developer)
2015-07-12 08:10

 Can you post your mod here with the bad ChangeLevel?
User avatar (0012875)
Visual Vincent (reporter)
2015-07-12 10:48

 I'd rather not since it's a very new, WIP mod... I can PM it via the forum to those devs who want it though.
But I do know the problem. I test the mod with bots. And when you die in the mod, you are morphed into a custom class that's made to work pretty much the same way as a spectator. (Flying, noclip, being invisible etc.)
When the bots are morphed into this class and the round is over, the game crashes when either calling Exit_Normal or ChangeLevel. However, If I (as a player) is morphed to this class it seems to work perfectly with atleast Exit_Normal.

I'll PM you the mod vi the forum, Edward. If any other dev want to have a look just tell me. :)
User avatar (0012878)
Edward-san (developer)
2015-07-12 11:32

 Just to clarify: this happens in 2.0 and 2.1, right?
User avatar (0012879)
Visual Vincent (reporter)
2015-07-12 11:41

 I've only tried it in 2.1, but yes.
User avatar (0012903)
Edward-san (developer)
2015-07-12 17:16
edited on: 2015-07-12 17:40

 'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/3fe2399cb54b689cdfc8485ac332c954f55851ad [^]' should fix the crash.


Visual Vincent, can you check this build (based on above commit) and see if you get problems with morphed bots?
User avatar (0012914)
Visual Vincent (reporter)
2015-07-13 12:36
edited on: 2015-07-13 12:38

 Wow! Works perfectly! Thanks!
Should I create a new ticket about this so that we can mark it as resolved?

By the way (whoever hosts this tracker): You should make the creator of a ticket be able to edit or delete the ticket that he or she created.
User avatar (0012919)
Edward-san (developer)
2015-07-13 18:14

 Then it seems to be ready for review.
User avatar (0013151)
Torr Samaho (administrator)
2015-08-09 13:09

 I added your patch to the stable repo.
User avatar (0013245)
cobalt (updater)
2015-08-22 16:26

 Issue addressed by commit 9b556d0: - Fixed a NULL pointer dereference in the bot code, related to morphing, shown in a crash log.
Committed by Edoardo Prezioso [edward-san] on Sunday 12 July 2015 18:54:48

Changes in files:

 src/botcommands.cpp | 3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
User avatar (0013266)
Dusk (developer)
2015-08-25 10:35

 Closing as patch was tested prior to inclusion.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-07-11 19:42 Visual Vincent New Issue
2015-07-11 20:05 Edward-san Note Added: 0012855
2015-07-11 20:21 Edward-san Note Edited: 0012855 View Revisions
2015-07-11 20:28 Edward-san Note Edited: 0012855 View Revisions
2015-07-11 20:28 Edward-san Note Edited: 0012855 View Revisions
2015-07-11 20:29 Edward-san Note Edited: 0012855 View Revisions
2015-07-11 20:41 Visual Vincent Note Added: 0012856
2015-07-11 20:42 Visual Vincent Note Edited: 0012856 View Revisions
2015-07-11 20:42 Visual Vincent Note Edited: 0012856 View Revisions
2015-07-12 08:10 Edward-san Note Added: 0012866
2015-07-12 10:48 Visual Vincent Note Added: 0012875
2015-07-12 11:32 Edward-san Note Added: 0012878
2015-07-12 11:41 Visual Vincent Note Added: 0012879
2015-07-12 12:49 Edward-san File Added: zandronum-crash-07_12_2015-14_46_56.3750.log
2015-07-12 12:49 Edward-san File Deleted: zandronum-crash-07_12_2015-14_46_56.3750.log
2015-07-12 12:50 Edward-san File Added: zandronum-crash-07_12_2015-14_46_56.3750.log
2015-07-12 17:16 Edward-san Note Added: 0012903
2015-07-12 17:39 Edward-san Note Edited: 0012903 View Revisions
2015-07-12 17:40 Edward-san Note Edited: 0012903 View Revisions
2015-07-12 17:40 Edward-san Assigned To => Edward-san
2015-07-12 17:40 Edward-san Status new => feedback
2015-07-13 12:36 Visual Vincent Note Added: 0012914
2015-07-13 12:36 Visual Vincent Status feedback => assigned
2015-07-13 12:38 Visual Vincent Note Edited: 0012914 View Revisions
2015-07-13 12:38 Visual Vincent Note Edited: 0012914 View Revisions
2015-07-13 18:14 Edward-san Note Added: 0012919
2015-07-13 18:14 Edward-san Status assigned => needs review
2015-08-09 13:09 Torr Samaho Note Added: 0013151
2015-08-09 13:09 Torr Samaho Status needs review => feedback
2015-08-22 16:26 cobalt Status feedback => needs testing
2015-08-22 16:26 cobalt Target Version => 2.1
2015-08-22 16:26 cobalt Description Updated View Revisions
2015-08-22 16:26 cobalt Note Added: 0013245
2015-08-25 10:35 Dusk Note Added: 0013266
2015-08-25 10:35 Dusk Status needs testing => resolved
2015-08-25 10:35 Dusk Fixed in Version => 2.2
2015-08-25 10:35 Dusk Resolution open => fixed
2018-09-30 21:40 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker