Zandronum Chat on our Discord Server Get the latest version: 3.2.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002192Zandronum[All Projects] Bugpublic2015-04-16 14:212025-04-08 12:09
ReporterArco 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds reviewResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0 
Target VersionFixed in Version 
Summary0002192: sv_sharekeys doesn't account for sv_coop_loseinventory upon respawning
DescriptionWhen both sv_sharekeys and sv_coop_loseinventory are true, you'll lose all of the keys in your inventory when you die.
Steps To Reproduce1. zandronum.exe -iwad doom2.wad -host -warp map02
2. Make sure sv_sharekeys and sv_coop_loseinventory are true at the same time.
3. Collect a key and then type "kill" in console.
4. Respawn.
Attached Files

- Relationships

-  Notes
User avatar (0012118)
Dusk (developer)
2015-04-16 15:46
edited on: 2015-04-16 15:51

 sv_coop_losekeys appears to also be affected...

This is somewhat problematic. sv_coop_loseinventory causes the player mobj to call DestroyAllInventory, which does exactly that. It is also used elsewhere, including AActor::Destroy... so I'm a bit uncomfortable in putting a shared keys exception in the mix. That limits our options a bit:

- replace the DestroyAllInventory call with a for loop. This causes a delta increase but would keep us to retain the functionality of both cvars
- apply shared keys effect after APlayerPawn::FilterCoopRespawnInventory has done its job. IMO this is probably the best solution, though can cause some bandwidth increase though since players don't die very often this is probably neglegible.
- force sv_coop_loseinventory and sv_coop_losekeys off if sv_sharekeys is on. IMO this is a last-ditch measure and not one I want to pursue.
User avatar (0012120)
Dusk (developer)
2015-04-16 20:11

 Done:'https://bitbucket.org/crimsondusk/zandronum-sandbox/compare/d6dc2ef..eba5568 [^]'
I decided to give it a bit more rework than originally intended. Again.
User avatar (0014094)
Arco (updater)
2016-01-15 05:23

 The link appears to have been deleted...
User avatar (0024396)
unknownna (updater)
2025-04-08 12:09

 While investigating some other issue, I came across this, and the issue still persists to 3.2. The collected keys are needlessly removed from the inventory upon respawning if "sv_coop_loseinventory" and/or "sv_coop_losekeys" are set to 1. Newly connected clients and spectators turning into real players however get all the collected keys stored on the server.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-04-16 14:21 Arco New Issue
2015-04-16 14:22 Arco Description Updated View Revisions
2015-04-16 15:42 Dusk Assigned To => Dusk
2015-04-16 15:42 Dusk Status new => assigned
2015-04-16 15:46 Dusk Note Added: 0012118
2015-04-16 15:51 Dusk Note Edited: 0012118 View Revisions
2015-04-16 15:51 Dusk Status assigned => needs review
2015-04-16 15:52 Dusk Status needs review => assigned
2015-04-16 20:11 Dusk Note Added: 0012120
2015-04-16 20:11 Dusk Status assigned => needs review
2016-01-15 05:23 Arco Note Added: 0014094
2025-04-08 12:09 unknownna Note Added: 0024396




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker