Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002072Zandronum[All Projects] Bugpublic2015-01-19 01:292018-09-30 23:03
ReporterEdward-san 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002072: Scoreboard time, after a minute, reports 0 for all the players except consoleplayer
DescriptionLike the title says. NetCommand conversion broke it. To think it went unnoticed for all this time..
Steps To Reproduce- Host a simple doom2.wad server;
- Connect 2 clients;
- wait at least a minute
- open the scoreboard.

This can be seen also when you exit the current level.
Attached Files

- Relationships

-  Notes
User avatar (0011444)
Edward-san (developer)
2015-01-19 02:46
edited on: 2015-01-19 02:47

 Found the cause, together with Dusk: SERVERCOMMANDS_UpdatePlayerTime, after the netcommand conversion, stopped sending the time to all the clients, just to the client the time is referred, itself. Changing 'command.sendCommandToOneClient( ulPlayer );' to 'command.sendCommandToClients( ulPlayerExtra, ulFlags );' works for me.

I hope there are no other mistakes like that.
User avatar (0011447)
cobalt (updater)
2015-01-19 20:05

 Issue addressed by commit d7c3ad2b0b68: Fixed: SERVERCOMMANDS_UpdatePlayerTime ignored the ulPlayerExtra and ulFlags arguments and always sent the command only to the client belonging to the player whose ping was updated (fixes 2072).
Committed by Benjamin Berkels [Torr Samaho] on Monday 19 January 2015 21:01:09

Changes in files:
 src/sv_commands.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
User avatar (0011448)
Torr Samaho (administrator)
2015-01-19 20:06

 Thanks! Fixed.

BTW: Why didn't GCC warn that the arguments ulPlayerExtra and ulFlags are not used? Or did it? This warning would have immediately shown that there is something wrong here.
User avatar (0011449)
Edward-san (developer)
2015-01-19 20:12
edited on: 2015-01-19 20:34

 Because zdoom, before some time ago, did not enable -Wextra, hence no warnings. If you add it to CMakeLists.txt, it'll report the following things just on sv_commands.cpp:


In file included from /home/edward-san/zdoom/zandronum/sandbox/src/sv_main.h:58:0,
                 from /home/edward-san/zdoom/zandronum/sandbox/src/network.h:58,
                 from /home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:62:
/home/edward-san/zdoom/zandronum/sandbox/src/s_sndseq.h:32:30: warning: unused parameter ‘loop’ [-Wunused-parameter]
  virtual void MakeSound (int loop, FSoundID id) {}
                              ^
/home/edward-san/zdoom/zandronum/sandbox/src/s_sndseq.h:32:45: warning: unused parameter ‘id’ [-Wunused-parameter]
  virtual void MakeSound (int loop, FSoundID id) {}
                                             ^
/home/edward-san/zdoom/zandronum/sandbox/src/s_sndseq.h:35:36: warning: unused parameter ‘seqnum’ [-Wunused-parameter]
  virtual DSeqNode *SpawnChild (int seqnum) { return NULL; }
                                    ^
In file included from /home/edward-san/zdoom/zandronum/sandbox/src/r_data.h:29:0,
                 from /home/edward-san/zdoom/zandronum/sandbox/src/r_local.h:33,
                 from /home/edward-san/zdoom/zandronum/sandbox/src/p_local.h:27,
                 from /home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:63:
/home/edward-san/zdoom/zandronum/sandbox/src/v_video.h:169:26: warning: unused parameter ‘usesimplecanvas’ [-Wunused-parameter]
  virtual bool Lock (bool usesimplecanvas) { return Lock(); }
                          ^
/home/edward-san/zdoom/zandronum/sandbox/src/v_video.h:346:36: warning: unused parameter ‘bright’ [-Wunused-parameter]
  virtual bool SetBrightness (float bright) { return false; }
                                    ^
/home/edward-san/zdoom/zandronum/sandbox/src/v_video.h:347:34: warning: unused parameter ‘contrast’ [-Wunused-parameter]
  virtual bool SetContrast (float contrast) { return false; }
                                  ^
/home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:135:28: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
  const ULONG operator* ( ) const {
                            ^
/home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:139:27: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
  const ULONG operator++ ( ) {
                           ^
/home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:477:51: warning: unused parameter ‘bReliable’ [-Wunused-parameter]
 void SERVERCOMMANDS_Nothing( ULONG ulPlayer, bool bReliable )
                                                   ^
/home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:1186:61: warning: unused parameter ‘ulPlayerExtra’ [-Wunused-parameter]
 void SERVERCOMMANDS_UpdatePlayerTime( ULONG ulPlayer, ULONG ulPlayerExtra, ULONG ulFlags )
                                                             ^
/home/edward-san/zdoom/zandronum/sandbox/src/sv_commands.cpp:1186:82: warning: unused parameter ‘ulFlags’ [-Wunused-parameter]
 void SERVERCOMMANDS_UpdatePlayerTime( ULONG ulPlayer, ULONG ulPlayerExtra, ULONG ulFlags )
                                                                                  ^


In recent zdoom, CMakeLists.txt provides the following parameters: "-Wall -Wextra -Wno-unused -Wno-unused-parameter -Wno-missing-field-initializers", because it would become too much verbose. For example, the CCMDs don't use 'who' and 'key' parameter variables, so you'll see tons of warnings on CCMDs instances.


[edit]uh, interesting that SERVERCOMMANDS_Nothing does not use bReliable ... oh damn, this was wrecked, too, in the netcommand change..
User avatar (0011466)
WaTaKiD (updater)
2015-01-21 00:42

 after testing with 2.0-r150119-2001, issue seems fixed
User avatar (0011492)
Edward-san (developer)
2015-01-21 21:32
Quote

[edit]uh, interesting that SERVERCOMMANDS_Nothing does not use bReliable ... oh damn, this was wrecked, too, in the netcommand change..

Done a commit which fixes this.
User avatar (0011523)
Torr Samaho (administrator)
2015-01-25 09:16

 I pulled the change.
User avatar (0011852)
StrikerMan780 (reporter)
2015-03-16 19:15
edited on: 2015-03-16 19:16

 After disconnecting and reconnecting, everyone's time resets to zero as far as I see.

EDIT: After about a minute it fixes itself. I'm guessing this is normal.
User avatar (0011854)
Marcaek (reporter)
2015-03-16 19:59

 Seems fixed now when I tested with Striker.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-01-19 01:29 Edward-san New Issue
2015-01-19 02:46 Edward-san Note Added: 0011444
2015-01-19 02:46 Edward-san Description Updated View Revisions
2015-01-19 02:47 Edward-san Note Edited: 0011444 View Revisions
2015-01-19 03:02 Edward-san Assigned To => Edward-san
2015-01-19 03:02 Edward-san Status new => needs review
2015-01-19 20:05 cobalt Status needs review => needs testing
2015-01-19 20:05 cobalt Target Version => 2.0
2015-01-19 20:05 cobalt Steps to Reproduce Updated View Revisions
2015-01-19 20:05 cobalt Note Added: 0011447
2015-01-19 20:06 Torr Samaho Note Added: 0011448
2015-01-19 20:12 Edward-san Note Added: 0011449
2015-01-19 20:13 Edward-san Note Edited: 0011449 View Revisions
2015-01-19 20:20 Edward-san Note Edited: 0011449 View Revisions
2015-01-19 20:28 Edward-san Note Edited: 0011449 View Revisions
2015-01-19 20:34 Edward-san Note Edited: 0011449 View Revisions
2015-01-21 00:42 WaTaKiD Note Added: 0011466
2015-01-21 21:32 Edward-san Note Added: 0011492
2015-01-22 17:33 Edward-san Status needs testing => needs review
2015-01-25 09:16 Torr Samaho Note Added: 0011523
2015-01-25 09:16 Torr Samaho Status needs review => needs testing
2015-03-16 19:15 StrikerMan780 Note Added: 0011852
2015-03-16 19:16 StrikerMan780 Note Edited: 0011852 View Revisions
2015-03-16 19:16 StrikerMan780 Note Edited: 0011852 View Revisions
2015-03-16 19:59 Marcaek Note Added: 0011854
2015-03-17 00:29 Dusk Status needs testing => resolved
2015-03-17 00:29 Dusk Fixed in Version => 2.0
2015-03-17 00:29 Dusk Resolution open => fixed
2018-09-30 23:03 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker