Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002053Zandronum[All Projects] Bugpublic2015-01-04 23:022018-09-30 23:08
ReporterWaTaKiD 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002053: sv_nomonsters 1 changes spawn direction in next map
Descriptiononline or offline in 2.0, having sv_nomonsters 1 while exiting will have u spawn in the next map facing the direction u were when u exited, rather than the player start's direction
Steps To Reproduceload any zandro 2.0 build with doom2.wad map01
sv_nomonsters 1
exit while facing the switch at an angle
should spawn in map02 not facing the normal direction
Additional Informationdoes not happen in gzdoom r900 or zdoom 2.5.0/2.6.0 singleplayer or multiplayer
Attached Files

- Relationships

-  Notes
User avatar (0011278)
WaTaKiD (updater)
2015-01-04 23:24

 sorry i forgot to list the earliest 2.0 build that i tested (and could find):
2.0-r131223-1820
User avatar (0011281)
Edward-san (developer)
2015-01-05 00:50
edited on: 2015-01-05 01:33

 It started breaking from changeset abc921f3c681 .

Found out why: when sv_nomonsters is on, zandronum, when calling G_ExitLevel, passes to G_ChangeLevel the nomonsters flag, in order to preserve the nomonsters behavior when the next map is loaded. Zdoom, instead, does not. Inside G_ChangeLevel, flags is 4 and its value is saved in the static variable changeflags. This seems innocent, but the problem starts in G_FinishTravel, when this condition is checked:


if (!changeflags & CHANGELEVEL_KEEPFACING)


and ... surprise! bad logic here: negation is applied on changeflags, not on the result of the 'and', changing the result from 'true' to 'false', hence 'angle' and 'pitch' of the pawn is not reset.
Actually, zdoom fixed this when another problem was arisen in this bug thread, when the same identical problem happened to the 'ChangeLevel' ACS function. It was fixed in r3444.
User avatar (0011289)
Torr Samaho (administrator)
2015-01-05 19:38

 Thanks, Edward-san, for the detailed analysis! I backported the ZDoom fix.
User avatar (0011290)
cobalt (updater)
2015-01-05 19:56
edited on: 2015-01-05 19:57

 Issue addressed by commit 923acc61f1b6: out of sequence fix backport from ZDoom revision 3444: - Fixed: The check for CHANGELEVEL_KEEPFACING in G_FinishTravel() needed parentheses. This addresses the 2.0 specific problems reported in 2053.
Committed by Benjamin Berkels [Torr Samaho] on Monday 05 January 2015 20:35:38

Changes in files:
 src/g_level.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
User avatar (0011303)
WaTaKiD (updater)
2015-01-05 22:56

 after testing with 2.0-r150105-2058, issue seems fixed

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-01-04 23:02 WaTaKiD New Issue
2015-01-04 23:24 WaTaKiD Note Added: 0011278
2015-01-05 00:50 Edward-san Note Added: 0011281
2015-01-05 00:51 Edward-san Note Edited: 0011281 View Revisions
2015-01-05 01:33 Edward-san Note Edited: 0011281 View Revisions
2015-01-05 01:34 Edward-san Assigned To => Torr Samaho
2015-01-05 01:34 Edward-san Status new => assigned
2015-01-05 19:38 Torr Samaho Note Added: 0011289
2015-01-05 19:39 Torr Samaho Status assigned => needs testing
2015-01-05 19:39 Torr Samaho Target Version => 2.0
2015-01-05 19:56 cobalt Note Added: 0011290
2015-01-05 19:57 Dusk Note Edited: 0011290 View Revisions
2015-01-05 22:56 WaTaKiD Note Added: 0011303
2015-01-08 14:39 Arco Status needs testing => resolved
2015-01-08 14:39 Arco Resolution open => fixed
2015-01-08 14:39 Arco Fixed in Version => 2.0
2018-09-30 23:08 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker