Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001338Zandronum[All Projects] Suggestionpublic2013-05-05 22:262018-09-30 22:27
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0001338: Allow clang to compile zandronum (backport)
DescriptionSince I'm using clang (I believe I'm not alone on this), in order to compile zandronum I need these zdoom changes:

r3589 and r3591 (which fixes an accidental hunk added in r3589). No more, no less.
Attached Files

- Relationships
child of 0002172closedTorr Samaho Upgrade GZDoom base to 1.8.6 

-  Notes
User avatar (0009237)
Watermelon (developer)
2014-06-13 17:59

 Do we have these in 2.0?
User avatar (0009358)
Edward-san (developer)
2014-06-15 00:14
edited on: 2014-06-15 01:43

 Nope, the changes are ahead 2.5.0.

[edit] uh ... I don't agree with the message added by the first commit:


// [CE] Clang doesn't yet support some inline ASM operations so I disabled it for that instance


The problem is that Clang is perfectly right to reject that assembly code, and gcc is wrong to allow that. I asked some asm experts if there was a workaround, they told me it's not a good idea to use asm like that at all. :\

[edit2] It seems there's a workaround:


-: "%3", "%4", "st(1)", "st(7)" );
+: "st(1)", "st(2)", "st(3)", "st(4)", "st(5)", "st(6)", "st(7)" );
User avatar (0012269)
Edward-san (developer)
2015-05-13 07:21

 Apart from the compiler error I pointed out in ticket 0002172, with 3.0 clang compiles fine ( and also gcc5, which had the same compiler errors as clang for 'dumb' code ).
User avatar (0012327)
Edward-san (developer)
2015-05-17 21:27
edited on: 2015-05-17 21:34

 I noticed that clang still has an error when compiling src/p_spec.h . This is fixed by zdoom in'https://github.com/rheit/zdoom/commit/310979e9e6d64a54bf0b7a0df4627f31f5c06f6c [^]' .


edit: nvm, that change is present in 2.7.1, so this can wait..

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-05-05 22:26 Edward-san New Issue
2014-06-13 17:59 Watermelon Note Added: 0009237
2014-06-13 17:59 Watermelon Status new => feedback
2014-06-13 17:59 Watermelon Assigned To => Edward-san
2014-06-13 17:59 Watermelon Status feedback => assigned
2014-06-13 17:59 Watermelon Status assigned => feedback
2014-06-15 00:14 Edward-san Note Added: 0009358
2014-06-15 00:14 Edward-san Status feedback => assigned
2014-06-15 00:52 Edward-san Note Edited: 0009358 View Revisions
2014-06-15 01:43 Edward-san Note Edited: 0009358 View Revisions
2015-04-04 21:32 Arco Relationship added child of 0002172
2015-04-05 08:16 WaTaKiD Target Version => 3.0
2015-05-09 13:56 Dusk Assigned To Edward-san => Torr Samaho
2015-05-09 13:58 Dusk Status assigned => needs testing
2015-05-13 07:21 Edward-san Note Added: 0012269
2015-05-13 07:22 Edward-san Status needs testing => resolved
2015-05-13 07:22 Edward-san Fixed in Version => 3.0
2015-05-13 07:22 Edward-san Resolution open => fixed
2015-05-17 21:27 Edward-san Note Added: 0012327
2015-05-17 21:34 Edward-san Note Edited: 0012327 View Revisions
2018-09-30 22:27 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker