Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001307Zandronum[All Projects] Bugpublic2013-03-25 23:542015-09-06 17:07
ReporterIjon Tichy 
Assigned To 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version1.0 
Target VersionFixed in Version 
Summary0001307: ACS libraries compiled with StrParam use the same string table as BEHAVIOR ACS
DescriptionThis is a weird bug. When StrParam doesn't come into play, ACS libraries have their own string table, and things work fine. However, when StrParam is used and a map with ACS is opened, ACS libraries suddenly decide that using their own string table makes too much sense, and instead, they use the string table that the BEHAVIOR lump is using. This fails miserably. Every single string in the library changes values, and this ends up leading to a crash with libraries such as stralloc.h (to be attached).
Steps To Reproduce1. Load Zandronum with strparambroken.pk3.
2. "map map01"
3. Hit the switches on the metal textures. The strings for these are provided by BEHAVIOR, and StrParam works as expected. (Should print "StrParam BEHAVIOR" and "Static BEHAVIOR")
4. Hit the switches on the stone textures. The strings for theses are provided by LOADACS... or would be if it didn't break. They print the exact same things the metal switches do (instead of "StrParam LOADACS" and "Static LOADACS").
Attached Files? file icon strparambroken.pk3 [^] (10,206 bytes) 2013-03-25 23:54
? file icon stralloc.h [^] (5,113 bytes) 2013-03-25 23:55

- Relationships

-  Notes
User avatar (0006173)
Ijon Tichy (reporter)
2013-03-25 23:58

 Ignore commonFuncs.h. That's just something automatically linked into all projects I create.
User avatar (0006338)
Ijon Tichy (reporter)
2013-05-15 22:39

 So it seems a #library line was forgotton, which fixes it... in this example. Hangman still breaks entirely when the game ACS is loaded as a library in a map with ACS.
User avatar (0009238)
Watermelon (developer)
2014-06-13 18:00

 Does this still happen in 2.0?
User avatar (0013427)
Dusk (developer)
2015-09-05 18:20

 'http://forum.zdoom.org/viewtopic.php?f=2&p=858018 [^]'
User avatar (0013440)
Dusk (developer)
2015-09-06 17:07
Quote from "Graf Zahl"

A missing #library statement is a user error. A library without this will inevitably have problems with string references.
And that's exactly what's missing in the linked code.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-03-25 23:54 Ijon Tichy New Issue
2013-03-25 23:54 Ijon Tichy File Added: strparambroken.pk3
2013-03-25 23:55 Ijon Tichy File Added: stralloc.h
2013-03-25 23:58 Ijon Tichy Note Added: 0006173
2013-05-15 22:39 Ijon Tichy Note Added: 0006338
2014-06-13 18:00 Watermelon Note Added: 0009238
2014-06-13 18:00 Watermelon Status new => feedback
2015-09-05 18:20 Dusk Note Added: 0013427
2015-09-05 18:20 Dusk Status feedback => acknowledged
2015-09-05 18:20 Dusk Resolution open => waiting for zdoom
2015-09-06 17:07 Dusk Note Added: 0013440
2015-09-06 17:07 Dusk Status acknowledged => closed
2015-09-06 17:07 Dusk Resolution waiting for zdoom => no change required




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker