0001115: Change ACS runaway script threshold from 500,000 to a variable or something higher

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001115

Zandronum

[All Projects] Suggestion

public

2012-10-10 16:09

2014-05-12 00:16

Reporter

Watermelon

Assigned To

Priority

normal

Severity

tweak

Reproducibility

have not tried

Status

closed

Resolution

backport later

Platform

OS Version

Product Version

1.0

Target Version

Fixed in Version

Summary

0001115: Change ACS runaway script threshold from 500,000 to a variable or something higher

Description

The limit of 500,000 is slowly becoming archaic from some of our mods that can push the engine quite far. ZDaemon has raised it to 2 million p-code instructions before runaway happens, and while I'm not trying to create [yet another] ZD thread, this showed me that it can be changed. It would be interesting to either up the limit for the mod developers in this community (since we're a mod driven port).

If this idea is feasible, maybe there should be a limit for the server (and clients have their own limit), like:
int sv_acsrunawaythreshold

Of course the only problem is someone could set it to 2 billion and go nuts, though they'd have to go out of their way to do such a thing; which means the server could possibly puke a log message if the threshold was changed?

Additional Information

Usually I get the message when running things like a square root formula on a lot of actors since there isn't a native square root function and does lots of stuff. When you have 4000 actors or such, there's enough calls to flood it to runaway.

Attached Files

Relationships

Notes
(0005076) Blzut3 (administrator) 2012-10-10 21:16	This should be suggested over at ZDoom first. That said, I have a hard time believing that you guys are legitimately hitting the limit all that often. :P

(0005080) Watermelon (developer) 2012-10-11 02:14 edited on: 2012-10-11 04:38	The code in Zandronum be changed in: p_acs.cpp [line 3723] if (++runaway > 500000) to if (++runaway > 2000000) Apparently zdoom has changed it. Figured this would be a simple thing to update and test. 'http://zdoom.org/Changelog/3697/files [^]'

(0005086) Dusk (developer) 2012-10-12 15:39	I do agree with Graf's sentiments that if you hit the runaway limit it's time to rethink what you are doing..

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	ZzZombo
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-10-10 16:09	Watermelon	New Issue
2012-10-10 21:16	Blzut3	Note Added: 0005076
2012-10-11 02:14	Watermelon	Note Added: 0005080
2012-10-11 02:15	Watermelon	Note Edited: 0005080	View Revisions
2012-10-11 02:16	Watermelon	Note Edited: 0005080	View Revisions
2012-10-11 02:27	Watermelon	Note Edited: 0005080	View Revisions
2012-10-11 04:38	Watermelon	Note Edited: 0005080	View Revisions
2012-10-12 15:39	Dusk	Note Added: 0005086
2014-05-12 00:16	Watermelon	Status	new => closed
2014-05-12 00:16	Watermelon	Resolution	open => backport later

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.