0002662: Code generator to handle server command read/write

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002662

Zandronum

[All Projects] Suggestion

public

2016-03-06 00:09

2018-09-30 21:49

Reporter

Dusk

Assigned To

Dusk

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.1

Target Version

3.0

Fixed in Version

3.0

Summary

0002662: Code generator to handle server command read/write

Description

We talked about this on the previous meeting. The code generator is mostly feature complete now so I've taken and refabricated the commits on top of the Zandronum current history (mostly because edward-san's mom→vel stuff kind of threw a few spanners into the works). I'm putting in a pull request now.

The benefits should be clear:
- automates the generation of boilerplate code, removing the factor of human error from within that
- prints warnings in various places where client code previously silently returned away
- eliminates vast quantities of code duplication
- exposes the spec of the server commands to a parseable text file which should assist external programs in analyzing Zandronum traffic, e.g.'http://zandronum.com/forum/showthread.php?tid=7048 [^]'

I've managed to convert all thing commands and most player commands now, as well as a select few difficult cases (i.e. WeaponRailgun and ACSScriptExecute). Along the way I've noticed several ways the server could crash the client that the code generator automatically fixes…

I'm confident that I can also convert the rest of the commands but the complexity of the patch is already large enough that I find it most unfeasible to convert everything for a single patch. This already contains a week of work and only covers a third or quarter of the commands. Nevertheless it's a mostly stable base that we can build upon.

Attached Files

Relationships

Notes
(0014554) Dusk (developer) 2016-03-06 00:14 edited on: 2016-03-06 00:14	'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/77 [^]' Notice that I've (painstakingly) arranged the changes to a series of commits. The combined diff is very large already.

(0014557) ZzZombo (reporter) 2016-03-06 03:39	ClientIterator::increm_?_ntCurrentTillValid

(0015028) Dusk (developer) 2016-06-05 23:00	'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/105 [^]' Now with the latest changes, all neatly packaged up.

(0016311) Edward-san (developer) 2016-11-24 07:49	It was added some months ago.

(0016785) Dusk (developer) 2017-02-06 19:00	It seems to be working just fine. I will rework on it for 3.1 but that'll go into a different ticket.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-03-06 00:09	Dusk	New Issue
2016-03-06 00:14	Dusk	Note Added: 0014554
2016-03-06 00:14	Dusk	Assigned To	=> Dusk
2016-03-06 00:14	Dusk	Status	new => needs review
2016-03-06 00:14	Dusk	Note Edited: 0014554	View Revisions
2016-03-06 03:39	ZzZombo	Note Added: 0014557
2016-06-05 23:00	Dusk	Note Added: 0015028
2016-06-05 23:00	Dusk	Severity	minor => major
2016-11-24 07:49	Edward-san	Note Added: 0016311
2016-11-24 07:49	Edward-san	Status	needs review => needs testing
2016-11-24 07:49	Edward-san	Product Version	=> 2.1
2016-11-24 07:49	Edward-san	Target Version	=> 3.0
2017-02-06 19:00	Dusk	Note Added: 0016785
2017-02-06 19:00	Dusk	Status	needs testing => resolved
2017-02-06 19:00	Dusk	Fixed in Version	=> 3.0
2017-02-06 19:00	Dusk	Resolution	open => fixed
2018-09-30 21:49	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.