0003980: Desync with firing weapons with WEAPON.NOAUTOFIRE flag

MantisBT - Zandronum

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0003980

Zandronum

[All Projects] Bug

public

2022-02-24 05:00

2024-05-27 18:27

Reporter

Kaminsky

Assigned To

Kaminsky

Priority

high

Severity

minor

Reproducibility

always

Status

feedback

Resolution

open

Platform

OS Version

Product Version

3.1

Target Version

3.2

Fixed in Version

Summary

0003980: Desync with firing weapons with WEAPON.NOAUTOFIRE flag

Description

Sometimes, if you try firing a weapon that has the WEAPON.NOAUTOFIRE flag (e.g. rocket launcher or BFG9000) the firing animation plays like normal but no projectile/hitscan appears. This doesn't seem to be a problem when firing weapons that don't have the flag.

I suspect that in some cases, there's a discrepancy in the value of player_t::attackdown between the server and client which causes the desync.

Steps To Reproduce

The issue appears to occur intermittently, but might occur more frequently right after spawning. In my experience, playing a few games of deathmatch or CTF on maps containing rocket launchers or BFGs is a good way to encounter the bug.

Use the example wad in the link below:
'https://zandronum.com/tracker/file_download.php?file_id=1547&type=bug [^]'
1. zandronum -iwad doom2.wad -file changemap_weap_desync.wad -host +sv_nomonsters 1
2. Connect a client to the server with an emulated ping of 160 and join the game.
3. Copy-paste "kill;wait 35;+use;wait 1;-use;wait 1;+attack;wait 1;-attack;wait 1;+attack;wait 1;-attack;wait 1;+attack;wait 1;-attack;wait 1;+attack;wait 1;-attack;wait 1;+attack;wait 1;-attack;wait 1;+attack;wait 75;-attack" into the console. The weapon will start to fire too early, spending ammo and animating the rocket launcher with no rockets coming out.

Additional Information

The issue also causes the "rampage" mugshot to appear on the status bar when it shouldn't.

[11:46 PM] agaures: marine guy brought up a good point about it happening with rocket launchers in ctf
[11:47 PM] agaures: for whatever reason i've had that happen to me a lot so that's what i was trying to search for last night
[11:49 PM] agaures: he also mentioned something interesting to me in dm: he posted a video of 3.1 where when shooting the pistol and then switching to the rl, the statusbar face would i think either switch to the angry one of "you've been holding down mouse1 for a while" or remain static (i couldn't tell it was a custom statusbar face)

Tags

No tags attached.

Relationships

related to	0001116	resolved	Kaminsky	Client fires weapon too early after respawning
related to	0003715	confirmed		COOP SPY feature show frozen (ready) weapon state on weapons with +WEAPON.NOAUTOFIRE
parent of	0003491	feedback	Kaminsky	Berserk powerup causes weapons to desync and client to fire weapon too early
parent of	0000534	confirmed		Ammo desync if you have a high ping. Client thinks that it didn't use any ammo.
has duplicate	0001780	closed		BFG plays sound and uses ammo but doesn't fire.
Not all the children of this issue are yet resolved or closed.