MantisBT - Zandronum
View Issue Details
0002407Zandronum[All Projects] Bugpublic2015-08-20 14:212018-09-30 22:20
Dusk 
Dusk 
normalcrashalways
closedfixed 
3.0-beta 
3.03.0 
0002407: Server chat crashes the client
Using rcon say crashes the client. Server remains fine.

This happens because CHAT_PrintChatString will call BOTCMD_SetLastChatPlayer( players[ulPlayer].userinfo.GetName() ); even if ulPlayer is MAXPLAYERS.

0000002 <signal handler called>
No locals.
0000003 0x000000000058d7cc in FindKey (key=..., this=<optimized out>) at /home/crimson/dev/zandronum-sandbox/src/tarray.h:834
        n = 0x24c3
0000004 CheckKey (key=..., this=<optimized out>) at /home/crimson/dev/zandronum-sandbox/src/tarray.h:579
No locals.
0000005 GetName (this=<optimized out>) at /home/crimson/dev/zandronum-sandbox/src/d_player.h:340
No locals.
0000006 CHAT_PrintChatString (ulPlayer=64, ulMode=<optimized out>, pszString=0x17e9000 <NETWORK_ReadString(BYTESTREAM_s*)::s_szString> "hi") at /home/crimson/dev/zandronum-sandbox/src/chat.cpp:480
        ulChatLevel = 2
        OutString = {Chars = 0x3ab466c "<server>: hi", static NullString = {Len = 0, AllocLen = 2, RefCount = 55768, Nothing = "\000"}}
        ChatString = {Chars = 0x3ab441c "hi", static NullString = {Len = 0, AllocLen = 2, RefCount = 55768, Nothing = "\000"}}
0000007 0x00000000005977e9 in client_PlayerSay (pByteStream=pByteStream@entry=0x17e8df8 <g_NetworkMessage+24>) at /home/crimson/dev/zandronum-sandbox/src/cl_main.cpp:5761
        ulPlayer = <optimized out>
        ulMode = <optimized out>
        pszString = <optimized out>
No tags attached.
Issue History
2015-08-20 14:21DuskNew Issue
2015-08-20 14:21DuskDescription Updatedbug_revision_view_page.php?rev_id=7927#r7927
2015-08-20 14:22DuskProduct Version => 3.0-beta
2015-09-04 14:47DuskNote Added: 0013392
2015-09-04 14:47DuskAssigned To => Dusk
2015-09-04 14:47DuskStatusnew => needs review
2015-09-05 09:35cobaltStatusneeds review => needs testing
2015-09-05 09:35cobaltTarget Version => 3.0
2015-09-05 09:35cobaltDescription Updatedbug_revision_view_page.php?rev_id=8021#r8021
2015-09-05 09:35cobaltAdditional Information Updatedbug_revision_view_page.php?rev_id=8023#r8023
2015-09-05 09:35cobaltNote Added: 0013410
2015-09-08 11:21DevilHunterNote Added: 0013454
2015-09-08 19:35DuskStatusneeds testing => resolved
2015-09-08 19:35DuskFixed in Version => 3.0
2015-09-08 19:35DuskResolutionopen => fixed
2018-09-30 22:20Blzut3Statusresolved => closed

Notes
(0013392)
Dusk   
2015-09-04 14:47   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/15 [^]'
(0013410)
cobalt   
2015-09-05 09:35   
Issue addressed by commit eb439948c1af: Fixed: server chat crashed all clients (fixes 2407)
Committed by Teemu Piippo [Dusk] on Friday 04 September 2015 17:46:25

Changes in files:

 src/chat.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

(0013454)
DevilHunter   
2015-09-08 11:21   
Tested this on my own server. It works.