View Revisions: Issue #3814 |
[ All Revisions ] [ Back to Issue ] |
Summary |
0003814: Inefficient string concatenation |
|
Revision |
2020-06-07 05:20 by WubTheCaptain |
|
Steps To Reproduce |
Here's an example:
Quote from src/core/irc/ircnetworkadapter.cpp
void IRCNetworkAdapter::setChannelMode(const QString &channel, const QString &nickname,
const QString &flag, bool bSet)
{
/* ... */
QString flagPrefixed;
if (bSet)
flagPrefixed = "+" + flag.trimmed();
else
flagPrefixed = "-" + flag.trimmed();
/* ... */
}
There are many more. They're not always easy to search for.
$ grep -r '" + "' src/ | wc -l
1
$ grep -r '" + ' src/ | wc -l
98
$ grep -r ' + "' src/ | wc -l
118
Assumed good behavior:
$ grep -r "\.append(" src/ | wc -l
72 |
|
Revision |
2020-06-07 05:20 by WubTheCaptain |
|
Steps To Reproduce |
Here's an example:
Quote from src/core/irc/ircnetworkadapter.cpp
void IRCNetworkAdapter::setChannelMode(const QString &channel, const QString &nickname,
const QString &flag, bool bSet)
{
/* ... */
QString flagPrefixed;
if (bSet)
flagPrefixed = "+" + flag.trimmed();
else
flagPrefixed = "-" + flag.trimmed();
/* ... */
}
There are many more. They're not always easy to search for.
$ grep -r '" + "' src/ | wc -l
1
$ grep -r '" + ' src/ | wc -l
98
$ grep -r ' + "' src/ | wc -l
118
Assumed good behavior:
$ grep -r "\.append(" src/ | wc -l
72 |
|
Revision |
2020-06-07 05:20 by WubTheCaptain |
|
Steps To Reproduce |
Here's an example:
Quote from src/core/irc/ircnetworkadapter.cpp
void IRCNetworkAdapter::setChannelMode(const QString &channel, const QString &nickname,
const QString &flag, bool bSet)
{
/* ... */
QString flagPrefixed;
if (bSet)
flagPrefixed = "+" + flag.trimmed();
else
flagPrefixed = "-" + flag.trimmed();
/* ... */
}
There are many more. They're not always easy to search for.
$ grep -r '" + "' src/ | wc -l
1
$ grep -r '" + ' src/ | wc -l
98
$ grep -r ' + "' src/ | wc -l
118
Assumed good behavior:
$ grep -r "\.append(" src/ | wc -l
72 |