View Revisions: Issue #3810 |
[ All Revisions ] [ Back to Issue ] |
Summary |
0003810: Some integer literals are cast to bool |
|
Revision |
2020-06-07 04:25 by WubTheCaptain |
|
Steps To Reproduce |
$ grep -r "bool " src/ | grep "= 1" | wc -l
1
$ grep -r "bool " src/ | grep "= 0" | wc -l
16
$ grep -r "bool " src/ | grep "(1)" | wc -l
0
$ grep -r "bool " src/ | grep "(0)" | wc -l
0
$ grep -r "bool " src/ | grep "? 1" | wc -l
0
$ grep -r "bool " src/ | grep "? 0" | wc -l
0 |
|
Revision |
2020-06-07 04:20 by WubTheCaptain |
|
Steps To Reproduce |
$ grep -r "bool " src/ | grep "= 1" | wc -l
1
$ grep -r "bool " src/ | grep "= 0" | wc -l
16
$ grep -r "bool " src/ | grep "(1)" | wc -l
0
$ grep -r "bool " src/ | grep "(0)" | wc -l
0
$ grep -r "bool " src/ | grep "? 1" | wc -l
0
$ grep -r "bool " src/ | grep "? 0" | wc -l
0
An example:
Quote from src/core/modreader.h virtual bool load() = 0;
should be written as:
Quote from src/core/modreader.h virtual bool load() = false; |