0003810: Some integer literals are cast to bool

View Revisions: Issue #3810		[ All Revisions ] [ Back to Issue ]
Summary	0003810: Some integer literals are cast to bool

Revision	2020-06-07 04:25 by WubTheCaptain
Description	Some code in Doomseeker uses integer values like 0 or 1 to indicate false / true, instead of those keywords. Not ideal (for readability). Guesstimate some of them were an int type before (like in C89), then converted from int to bool without changing the value itself. An example: Quote from src/core/modreader.h virtual bool load() = 0; should be written as: Quote from src/core/modreader.h virtual bool load() = false;

Revision	2020-06-07 04:20 by WubTheCaptain
Description	Some code in Doomseeker uses integer values like 0 or 1 to indicate false / true, instead of those keywords. Not ideal (for readability). Guesstimate some of them were an int type before (like in C89), then converted from int to bool without changing the value itself.

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.