0000682: Poly object doors break online

(0002667)
TIHan (reporter)
2012-02-22 08:52

Almost forgot, here are two test wads.'http://zdoom.org/zdkb/testdoor.zip [^]'
'http://zdoom.org/zdkb/rotdoor.zip [^]'

(0002707)
TIHan (reporter)
2012-02-28 05:33
edited on: 2012-02-28 05:46

All poly object issues as I'm concerned are fixed in this changeset:'https://bitbucket.org/TIHan/tst/changesets/tip/branch(%22polyobject_fixes_final%22) [^]'

Here are the binaries with test wads:'http://www.mediafire.com/?lw6kusee8y5z47a [^]'

(0002790)
Torr Samaho (administrator)
2012-03-11 18:48

I added your "sliding doors during map reset" fix (slightly extended for single player) and also added your *_SetPolyDoorSpeedRotation functions. Still need to look into your po_man.cpp changes. In the meantime, can somebody thoroughly test the binaries TIHan posted above? Would be really nice if the changes fix all the poly object issues :).

(0002821)
TIHan (reporter)
2012-03-17 20:09

Check the latest changes in the branch. I updated it to your current codebase and probably fixed the latest issues the poly objects had when they closed.

(0002834)
Torr Samaho (administrator)
2012-03-18 23:03

> probably fixed the latest issues the poly objects had when they closed.

Does your latest change fix any problems that you could reproduce? I'm asking this because wario reported that the latest change still has the same problems.

BTW: Judging from wario's feedback overall your fixes seem to be very effective :).

(0002835)
TIHan (reporter)
2012-03-18 23:31

I did manage to reproduce the swinging doors not closing perfectly all the way, after I attempted a fix it didn't happen again. I'm going to need better test wads for poly objects.

(0002836)
Torr Samaho (administrator)
2012-03-18 23:35

I see. I'm asking to find out whether the SERVERCOMMANDS_SetPolyDoorSpeedPosition and SERVERCOMMANDS_SetPolyDoorSpeedRotation calls added in the latest fix improve the situation or not.

(0002838)
TIHan (reporter)
2012-03-19 00:03

> I'm asking to find out whether the SERVERCOMMANDS_SetPolyDoorSpeedPosition and SERVERCOMMANDS_SetPolyDoorSpeedRotation calls added in the latest fix improve the situation or not.

Yea, that's what I meant. To my observations, they did.

(0002840)
Torr Samaho (administrator)
2012-03-19 00:24

> Yea, that's what I meant. To my observations, they did.

And you can reproduce this, i.e. if you remove the calls the problems you observed come back? If so, all is fine :). I'm just double checking everything here since your formulation "I did manage to reproduce the swinging doors not closing perfectly all the way, after I attempted a fix it didn't happen again." sounded to me like you never tried to go back after it seemed fixed to check whether the change fixed it or you just can't reproduce the problem reliably enough.

(0002841)
TIHan (reporter)
2012-03-19 01:01

Check the latest changes. Hopefully this should solve the issue.

(0002855)
TIHan (reporter)
2012-03-22 00:16

Hmm, for some reason all the bugs in the Bugs Forum got killed. Anyway, this is the changeset that fixes broke poly object doors when a client connects if a poly object door is fully open or moving.'https://bitbucket.org/TIHan/tst/changeset/e198f264fd80 [^]'
A bit of stuff was changed here, please read comments to understand my reasoning.

(0002856)
Torr Samaho (administrator)
2012-03-22 00:45

> Hmm, for some reason all the bugs in the Bugs Forum got killed.

Good grief. What is going on there?

> Anyway, this is the changeset that fixes broke poly object doors when a client connects if a poly object door is fully open or moving

Hmm, at first glance I'm not sure that this has to work in all cases. Is a polyobject that is not at it's initial position guaranteed to have an associated action? In particular something that is not a door.

(0002858)
TIHan (reporter)
2012-03-22 01:42

> Is a polyobject that is not at it's initial position guaranteed to have an associated action? In particular something that is not a door.

Good call. This should do it.
'https://bitbucket.org/TIHan/tst/changeset/7d9d43f33481 [^]'

(0002861)
TIHan (reporter)
2012-03-23 06:20

Here is my latest changeset.'https://bitbucket.org/TIHan/tst/changeset/832b52cc353e [^]'
I really cleaned up some stuff here. AFAIK, I haven't spotted any bugs. Works really well. :)

Binaries here:'http://www.mediafire.com/?zvp6pul7txjp0q5 [^]'

Note: There is a chance swing doors will screw up, even in single-player ZDoom 2.5.0 ;) - so don't freak out if this happens! I reproduced it myself in multiplayer/singleplayer ST and ZDoom 2.3.1 + 2.5.0.

(0002872)
wario (reporter)
2012-03-24 16:58

Works perfectly!

(0003319)
TIHan (reporter)
2012-04-16 08:56

Made some more changes.
'https://bitbucket.org/TIHan/tst/changeset/27acdefc1fde [^]'

(0003332)
TIHan (reporter)
2012-04-17 04:00
edited on: 2012-04-17 06:42

THIS should be it. Final, completely.
'https://bitbucket.org/TIHan/tst/changesets/tip/branch(%22polyobject_fixes_final%22) [^]'

Edit:
This actually does fix the Hexen traversing bugs that I noticed.

(0003354)
Torr Samaho (administrator)
2012-04-21 15:24

The fact that this is like the third (?) final version of the fix makes me kinda nervous ;). How thoroughly was the last incarnation of the fix tested?

(0003368)
TIHan (reporter)
2012-04-21 20:07

> How thoroughly was the last incarnation of the fix tested?

I believe Wario tested it pretty thoroughly as he always provided even the slightest bugs with them when I did the fixes.

Really where I was going with the last few changes was to make it simple and cut out code.

(0003484)
Torr Samaho (administrator)
2012-04-29 01:15

Patch added, but you take the responsibility ;).

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-02-22 08:42	TIHan	New Issue
2012-02-22 08:52	TIHan	Note Added: 0002667
2012-02-28 05:33	TIHan	Note Added: 0002707
2012-02-28 05:34	TIHan	Note Edited: 0002707	View Revisions
2012-02-28 05:46	TIHan	Note Edited: 0002707	View Revisions
2012-03-11 18:48	Torr Samaho	Note Added: 0002790
2012-03-11 18:48	Torr Samaho	Status	new => feedback
2012-03-17 20:09	TIHan	Note Added: 0002821
2012-03-17 20:09	TIHan	Status	feedback => new
2012-03-18 23:03	Torr Samaho	Note Added: 0002834
2012-03-18 23:31	TIHan	Note Added: 0002835
2012-03-18 23:35	Torr Samaho	Note Added: 0002836
2012-03-19 00:03	TIHan	Note Added: 0002838
2012-03-19 00:24	Torr Samaho	Note Added: 0002840
2012-03-19 01:01	TIHan	Note Added: 0002841
2012-03-22 00:16	TIHan	Note Added: 0002855
2012-03-22 00:45	Torr Samaho	Note Added: 0002856
2012-03-22 01:34	TIHan	Note Added: 0002857
2012-03-22 01:35	TIHan	Note Deleted: 0002857
2012-03-22 01:42	TIHan	Note Added: 0002858
2012-03-23 06:20	TIHan	Note Added: 0002861
2012-03-24 16:58	wario	Note Added: 0002872
2012-03-25 02:37	TIHan	Assigned To	=> TIHan
2012-03-25 02:37	TIHan	Status	new => assigned
2012-03-27 03:45	TIHan	Status	assigned => feedback
2012-04-16 07:44	TIHan	Summary	Poly object doors break on survival map reset => Poly object doors break online
2012-04-16 08:12	TIHan	Relationship added	related to 0000782
2012-04-16 08:28	TIHan	Status	feedback => assigned
2012-04-16 08:56	TIHan	Note Added: 0003319
2012-04-17 04:00	TIHan	Note Added: 0003332
2012-04-17 04:00	TIHan	Status	assigned => needs review
2012-04-17 06:42	TIHan	Note Edited: 0003332	View Revisions
2012-04-21 15:24	Torr Samaho	Note Added: 0003354
2012-04-21 20:07	TIHan	Note Added: 0003368
2012-04-29 01:15	Torr Samaho	Note Added: 0003484
2012-04-29 01:15	Torr Samaho	Status	needs review => feedback
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2016-04-18 02:38	Ru5tK1ng	Assigned To	TIHan =>
2016-04-18 02:38	Ru5tK1ng	Status	feedback => resolved
2016-04-18 02:38	Ru5tK1ng	Resolution	open => fixed
2018-09-30 22:36	Blzut3	Status	resolved => closed

Notes
(0002667) TIHan (reporter) 2012-02-22 08:52	Almost forgot, here are two test wads.'http://zdoom.org/zdkb/testdoor.zip [^]' 'http://zdoom.org/zdkb/rotdoor.zip [^]'

(0002707) TIHan (reporter) 2012-02-28 05:33 edited on: 2012-02-28 05:46	All poly object issues as I'm concerned are fixed in this changeset:'https://bitbucket.org/TIHan/tst/changesets/tip/branch(%22polyobject_fixes_final%22) [^]' Here are the binaries with test wads:'http://www.mediafire.com/?lw6kusee8y5z47a [^]'

(0002790) Torr Samaho (administrator) 2012-03-11 18:48	I added your "sliding doors during map reset" fix (slightly extended for single player) and also added your *_SetPolyDoorSpeedRotation functions. Still need to look into your po_man.cpp changes. In the meantime, can somebody thoroughly test the binaries TIHan posted above? Would be really nice if the changes fix all the poly object issues :).

(0002821) TIHan (reporter) 2012-03-17 20:09	Check the latest changes in the branch. I updated it to your current codebase and probably fixed the latest issues the poly objects had when they closed.

(0002834) Torr Samaho (administrator) 2012-03-18 23:03	> probably fixed the latest issues the poly objects had when they closed. Does your latest change fix any problems that you could reproduce? I'm asking this because wario reported that the latest change still has the same problems. BTW: Judging from wario's feedback overall your fixes seem to be very effective :).

(0002835) TIHan (reporter) 2012-03-18 23:31	I did manage to reproduce the swinging doors not closing perfectly all the way, after I attempted a fix it didn't happen again. I'm going to need better test wads for poly objects.

(0002836) Torr Samaho (administrator) 2012-03-18 23:35	I see. I'm asking to find out whether the SERVERCOMMANDS_SetPolyDoorSpeedPosition and SERVERCOMMANDS_SetPolyDoorSpeedRotation calls added in the latest fix improve the situation or not.

(0002838) TIHan (reporter) 2012-03-19 00:03	> I'm asking to find out whether the SERVERCOMMANDS_SetPolyDoorSpeedPosition and SERVERCOMMANDS_SetPolyDoorSpeedRotation calls added in the latest fix improve the situation or not. Yea, that's what I meant. To my observations, they did.

(0002840) Torr Samaho (administrator) 2012-03-19 00:24	> Yea, that's what I meant. To my observations, they did. And you can reproduce this, i.e. if you remove the calls the problems you observed come back? If so, all is fine :). I'm just double checking everything here since your formulation "I did manage to reproduce the swinging doors not closing perfectly all the way, after I attempted a fix it didn't happen again." sounded to me like you never tried to go back after it seemed fixed to check whether the change fixed it or you just can't reproduce the problem reliably enough.

(0002841) TIHan (reporter) 2012-03-19 01:01	Check the latest changes. Hopefully this should solve the issue.

(0002855) TIHan (reporter) 2012-03-22 00:16	Hmm, for some reason all the bugs in the Bugs Forum got killed. Anyway, this is the changeset that fixes broke poly object doors when a client connects if a poly object door is fully open or moving.'https://bitbucket.org/TIHan/tst/changeset/e198f264fd80 [^]' A bit of stuff was changed here, please read comments to understand my reasoning.

(0002856) Torr Samaho (administrator) 2012-03-22 00:45	> Hmm, for some reason all the bugs in the Bugs Forum got killed. Good grief. What is going on there? > Anyway, this is the changeset that fixes broke poly object doors when a client connects if a poly object door is fully open or moving Hmm, at first glance I'm not sure that this has to work in all cases. Is a polyobject that is not at it's initial position guaranteed to have an associated action? In particular something that is not a door.

(0002858) TIHan (reporter) 2012-03-22 01:42	> Is a polyobject that is not at it's initial position guaranteed to have an associated action? In particular something that is not a door. Good call. This should do it. 'https://bitbucket.org/TIHan/tst/changeset/7d9d43f33481 [^]'

(0002861) TIHan (reporter) 2012-03-23 06:20	Here is my latest changeset.'https://bitbucket.org/TIHan/tst/changeset/832b52cc353e [^]' I really cleaned up some stuff here. AFAIK, I haven't spotted any bugs. Works really well. :) Binaries here:'http://www.mediafire.com/?zvp6pul7txjp0q5 [^]' Note: There is a chance swing doors will screw up, even in single-player ZDoom 2.5.0 ;) - so don't freak out if this happens! I reproduced it myself in multiplayer/singleplayer ST and ZDoom 2.3.1 + 2.5.0.

(0002872) wario (reporter) 2012-03-24 16:58	Works perfectly!

(0003319) TIHan (reporter) 2012-04-16 08:56	Made some more changes. 'https://bitbucket.org/TIHan/tst/changeset/27acdefc1fde [^]'

(0003332) TIHan (reporter) 2012-04-17 04:00 edited on: 2012-04-17 06:42	THIS should be it. Final, completely. 'https://bitbucket.org/TIHan/tst/changesets/tip/branch(%22polyobject_fixes_final%22) [^]' Edit: This actually does fix the Hexen traversing bugs that I noticed.

(0003354) Torr Samaho (administrator) 2012-04-21 15:24	The fact that this is like the third (?) final version of the fix makes me kinda nervous ;). How thoroughly was the last incarnation of the fix tested?

(0003368) TIHan (reporter) 2012-04-21 20:07	> How thoroughly was the last incarnation of the fix tested? I believe Wario tested it pretty thoroughly as he always provided even the slightest bugs with them when I did the fixes. Really where I was going with the last few changes was to make it simple and cut out code.

(0003484) Torr Samaho (administrator) 2012-04-29 01:15	Patch added, but you take the responsibility ;).