Anonymous | Login | Signup for a new account | 2024-03-29 00:19 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002565 | Zandronum | [All Projects] Suggestion | public | 2016-01-06 12:57 | 2018-09-30 22:12 | ||||
Reporter | Fused | ||||||||
Assigned To | Dusk | ||||||||
Priority | normal | Severity | text | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 3.0-beta | ||||||||
Target Version | 3.0 | Fixed in Version | 3.0 | ||||||
Summary | 0002565: Merge a connecting player's name and IP together in one line | ||||||||
Description | Currently the "Connection ..." and "... has connected/entered the game" lines are not one line and this can cause a messy log when multiple people are connecting at the same time. Since there is a delay between these lines you won't be able to sort players with the corresponding ID when multiple people join. | ||||||||
Additional Information | sv_main.cpp replace line 1589-1601 with 'http://pastebin.com/raw/mYTtVT5N [^]' | ||||||||
Attached Files | |||||||||
Notes | |
(0014049) Dusk (developer) 2016-01-06 16:18 edited on: 2016-01-06 16:19 |
I'm not convinced that we should merge these lines since connection is asynchronous. The first message (with the IP address) logs the initial connection and the "player has connected" line logs when the player is properly in the server. I'm getting the vibe here that this request is for external RCON tools, judging by the proposal of adding a parseable connection line in the log. In such a case a protocol feature would probably be the way to go. |
(0014050) WaTaKiD (updater) 2016-01-06 18:18 |
it does feel kind of messy when multiple players connect at the same time or after a 'map' change, resulting in multiple lines of "connect: (ip)" followed by multiple lines of "player has connected" BE logs always gave me the confidence that i knew exactly whos ip was whos upon connecting with this "CONNECTION (name) (ip)" line, whereas with NJ logs that lacked this, i would have to wait until certain users called votes under these circumstances (albeit rarely) however i suppose theres also a part of me that just wants a little consistency to go with:'http://zandronum.com/tracker/view.php?id=2562 [^]' as in if the disconnect message displays their name and ip on the same line (im only assuming it does this, please correct me if im wrong), why not on connect as well? but as i give this more thought while rambling on, if this connect line is a no go, then as long as ticket 2562 is implemented i will be satisfied |
(0014051) Dusk (developer) 2016-01-06 22:15 edited on: 2016-01-06 22:41 |
We could add the IP address to the connect message as well as to the disconnect one. I remain unconvinced that we should add more of these kinds of print lines when the RCON protocol should be the go-to for 3rd party server administration tools. |
(0014149) Dusk (developer) 2016-01-21 22:15 |
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/56 [^]' The OP did not respond with feedback so I chose to address WaTaKiD's concern of being able to tell whose IP is whose in logfiles. |
(0014155) Fused (reporter) 2016-01-22 11:22 |
Sorry. WaTaKiD's post elaborated everything I had in mind and I had nothing to add to it. |
(0014174) cobalt (updater) 2016-01-24 13:22 |
Issue addressed by commit 76fc208d08d4: Print the IP address in the server console on connection, addresses 2565 Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57 Changes in files:
|
(0014192) WaTaKiD (updater) 2016-01-24 22:04 |
using'https://www.dropbox.com/s/mqqtgjo6j3dys3r/zandronum-3.0-r150424-1455-1749f30-windows.zip?dl=0 [^]' the ip is printed correctly, with and without cl_startasspectator [13:58:44] Connect (v3.0-alpha): 192.168.1.119:10667 [13:58:45] WaTaKiD (192.168.1.119:10667) has connected. (from: LAN) [13:58:54] Connect (v3.0-alpha): 192.168.1.119:10667 [13:58:54] WaTaKiD (192.168.1.119:10667) entered the game. (from: LAN) |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | WaTaKiD ZzZombo |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2016-01-06 12:57 | Fused | New Issue | |
2016-01-06 16:18 | Dusk | Note Added: 0014049 | |
2016-01-06 16:19 | Dusk | Note Edited: 0014049 | View Revisions |
2016-01-06 18:18 | WaTaKiD | Note Added: 0014050 | |
2016-01-06 22:15 | Dusk | Note Added: 0014051 | |
2016-01-06 22:15 | Dusk | Relationship added | related to 0002562 |
2016-01-06 22:41 | Dusk | Note Edited: 0014051 | View Revisions |
2016-01-06 22:41 | Dusk | Note Edited: 0014051 | View Revisions |
2016-01-21 22:15 | Dusk | Note Added: 0014149 | |
2016-01-21 22:15 | Dusk | Assigned To | => Dusk |
2016-01-21 22:15 | Dusk | Status | new => needs review |
2016-01-22 11:22 | Fused | Note Added: 0014155 | |
2016-01-24 13:22 | cobalt | Status | needs review => needs testing |
2016-01-24 13:22 | cobalt | Target Version | => 3.0 |
2016-01-24 13:22 | cobalt | Description Updated | View Revisions |
2016-01-24 13:22 | cobalt | Additional Information Updated | View Revisions |
2016-01-24 13:22 | cobalt | Note Added: 0014174 | |
2016-01-24 13:25 | Dusk | Priority | low => normal |
2016-01-24 13:25 | Dusk | Severity | tweak => text |
2016-01-24 13:25 | Dusk | Description Updated | View Revisions |
2016-01-24 13:25 | Dusk | Additional Information Updated | View Revisions |
2016-01-24 22:04 | WaTaKiD | Note Added: 0014192 | |
2016-01-24 22:06 | WaTaKiD | Status | needs testing => resolved |
2016-01-24 22:06 | WaTaKiD | Resolution | open => fixed |
2016-01-24 22:06 | WaTaKiD | Fixed in Version | => 3.0 |
2018-09-30 22:12 | Blzut3 | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |