Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002213Zandronum[All Projects] Bugpublic2015-04-26 14:012015-04-26 14:08
ReporterCh0wW 
Assigned To 
PriorityhighSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformAnyOSAnyOS VersionAny
Product Version2.0 
Target VersionFixed in Version 
Summary0002213: Spectators are counted as valid voters with sv_nocallvote 2
DescriptionIf someone calls a vote, if there are at least less than 50% players than spectators, the vote doesn't end.

This all happens because of a forgotten check in ULONG CALLVOTE_CountNumEligibleVoters( void ) .
Steps To ReproduceGet 3 players, with sv_nocallvote 2.

1 player, 2 spectators.
Let the player call a vote ==> yes.

Nothing happens.
Additional InformationThis error happens because of the way the server checks votes.

Ie: The server only accept/discards a vote IF at least 50% of legit clients have voted.

Problem is: when the server only allows players to vote with sv_nocallvote 2, the way it's handled is wrong.

For the current case, only 33% of the players have voted Yes. If players have only the right to vote, that should have been 100%.


Function fixed on the file.
Attached Filestxt file icon fix.txt [^] (1,163 bytes) 2015-04-26 14:01 [Show Content]

- Relationships

-  Notes
User avatar (0012174)
Ch0wW (reporter)
2015-04-26 14:08

Also, because I like things done correctly: in scoreboard.cpp , if player is a spectator while sv_nocallvote 2 is set, don't show "VOTE NOW". That might remove a possible confusion for spectators thinking they are able to vote while it isn't the case.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-04-26 14:01 Ch0wW New Issue
2015-04-26 14:01 Ch0wW File Added: fix.txt
2015-04-26 14:08 Ch0wW Note Added: 0012174






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker