MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000915Zandronum[All Projects] Suggestionpublic2012-07-12 19:482024-08-18 04:28
ReporterQent 
Assigned ToKaminsky 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version98d 
Target Version3.2Fixed in Version3.2 
Summary0000915: Add a "Wins" column to the duel scoreboard
DescriptionWith a duellimit greater than 1, players could need to keep track of both frags and wins for all players in the server, even spectators. There could be another column in the scoreboard for duels, a la "Points" and "Frags" in the CTF scoreboard.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0004300closed  Duel doesn't keep track of who wins the most 
related to 0001829resolved Kaminsky Customizable scoreboard 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-07-12 19:48QentNew Issue
2014-06-11 01:56WatermelonRelationship addedrelated to 0001829
2014-06-11 14:32WatermelonStatusnew => acknowledged
2023-07-01 13:50KaminskyNote Added: 0022855
2023-07-01 13:50KaminskyStatusacknowledged => needs testing
2024-06-01 03:44unknownnaNote Added: 0023742
2024-06-01 03:44unknownnaStatusneeds testing => feedback
2024-06-15 12:29unknownnaRelationship addedrelated to 0004300
2024-07-29 14:42KaminskyNote Added: 0023845
2024-07-29 14:43KaminskyNote Edited: 0023845bug_revision_view_page.php?bugnote_id=23845#r14320
2024-07-30 01:08unknownnaNote Added: 0023854
2024-07-31 10:29unknownnaNote Edited: 0023854bug_revision_view_page.php?bugnote_id=23854#r14329
2024-08-02 03:35KaminskyNote Added: 0023883
2024-08-02 03:35KaminskyAssigned To => Kaminsky
2024-08-02 03:35KaminskyStatusfeedback => needs review
2024-08-02 03:35KaminskyTarget Version => 3.2
2024-08-02 10:19unknownnaNote Added: 0023888
2024-08-18 04:28KaminskyNote Added: 0023953
2024-08-18 04:28KaminskyStatusneeds review => resolved
2024-08-18 04:28KaminskyFixed in Version => 3.2
2024-08-18 04:28KaminskyResolutionopen => fixed

Notes
(0022855)
Kaminsky   
2023-07-01 13:50   
With the introduction of the new SCORINFO lump:'https://wiki.zandronum.com/SCORINFO [^]' it should be possible for someone to define a custom column that keeps track of how many duels a player has won.
(0023742)
unknownna   
2024-06-01 03:44   
Why not add it to the scoreboard, so the ones who didn't win the most can also see their wins? No basic user will go out their way to make a mod to see a "wins" column in duel.

And the mode seems to be broken currently, for some reason the scoreboard doesn't keep track properly of who wins the most. If you win twice and then lose, the other player suddenly becomes champion even though he only won once. I'll make a new ticket.
(0023845)
Kaminsky   
2024-07-29 14:42   
(edited on: 2024-07-29 14:43)
Quote from "unknownna"
Why not add it to the scoreboard, so the ones who didn't win the most can also see their wins? No basic user will go out their way to make a mod to see a "wins" column in duel.


I say this because as soon as the dueler loses and joins spectators, they lose all of their stats including wins. It wouldn't be very useful to display the "wins" column if the only player who'll have at least one win is the "champion", which already appears on the scoreboard (and I suspect this is only reason why players are given wins). I'm not sure about making a hard-coded exception to not clear a spectator's wins just for duel. Creating a custom column seemed like a very simple solution.

Quote from "unknownna"
And the mode seems to be broken currently, for some reason the scoreboard doesn't keep track properly of who wins the most. If you win twice and then lose, the other player suddenly becomes champion even though he only won once.


Technically speaking, Duel isn't a game mode where players earn wins (they earn frags), and the whole game mode system is designed on the assumption that players beat each other based on only one of these: frags, kills, points, or wins. The "wins" column is designed to only appear in game modes where players earn wins. Doesn't it also make some sense that the player who beats the "champion" becomes the new champion (i.e. the old champion relinquishes their title to the new victor)?
(0023854)
unknownna   
2024-07-30 01:08   
(edited on: 2024-07-31 10:29)
Quote from Kaminsky
I say this because as soon as the dueler loses and joins spectators, they lose all of their stats including wins. It wouldn't be very useful to display the "wins" column if the only player who'll have at least one win is the "champion", which already appears on the scoreboard (and I suspect this is only reason why players are given wins). I'm not sure about making a hard-coded exception to not clear a spectator's wins just for duel. Creating a custom column seemed like a very simple solution.


I see and thanks for the explanation, but I'd say this feels like an oversight, a basic user playing the duel mode with multiple duellimits will naturally assume they should keep their win stat when turning into a spectator until the map is finished. I'd make a hard-coded exception for this if needed. Since the join queue is practically a part of the duel gamemode when there's multiple duellimits, the current behavior feels bugged. And I don't think that creating a custom column is the easiest way for a normal user, one can't expect users to know how to script and make mods. My own abilities are very limited, as an example. But that's just my perspective.

Quote from Kaminsky
Technically speaking, Duel isn't a game mode where players earn wins (they earn frags), and the whole game mode system is designed on the assumption that players beat each other based on only one of these: frags, kills, points, or wins. The "wins" column is designed to only appear in game modes where players earn wins. Doesn't it also make some sense that the player who beats the "champion" becomes the new champion (i.e. the old champion relinquishes their title to the new victor)?


Well, since there's duellimit present, they in a sense earn wins on top of that, don't they? Since there is no proper counting of wins, the "champion" title becomes very ambiguous, which is probably part of the reason why this ticket was made. I think when duellimit is set to a higher value, people would want to keep track of the champion with the most wins to see who they have to surpass in order to become the new champion.
On top of this, I don't think a highly ranked player with multiple wins would want to lose the champion title just because they lost once, especially not when the final duellimit is reached and the new player with lesser wins is crowned champion.
Keeping the player with most wins as a champion feels the most tournament-like IMO. If every winning player becomes champion, the title loses its value.
But I guess it depends on what every individual's perspective is of what the champion should be.

In any case, keeping proper track of wins would be nice. It would look and feel amazing with a proper win counter with the new and updated scoreboard.

Speaking of which, the champion is not displayed during the intermission screen from testing as I type this. And what would you do if 2 players have the same amount of wins when the duellimit is reached? A tie or a sudden death round between the two?

Edit:
If the whole "champion" issue is too much of a hassle to change, then a simple win row counting system on the scoreboard for players and spectators like the OP wants would be fine. It could also be argued that every winning player defeating the current champion rightfully becomes the new champion as well. And maybe it doesn't matter if the champion isn't displayed during the intermission screen if players could see the wins of every other player on the server. At least then there would be no confusion.
(0023883)
Kaminsky   
2024-08-02 03:35   
Thanks for the feedback. I went ahead and created a new merge request that adds the wins column to duel:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/152 [^]'

Note that this doesn't fix players losing their wins when they become a spectator, but that's a separate issue that has its own ticket.

Quote from "unknownna"
If the whole "champion" issue is too much of a hassle to change, then a simple win row counting system on the scoreboard for players and spectators like the OP wants would be fine. It could also be argued that every winning player defeating the current champion rightfully becomes the new champion as well. And maybe it doesn't matter if the champion isn't displayed during the intermission screen if players could see the wins of every other player on the server. At least then there would be no confusion.


It's been a long time since I played on a duel server where the duel limit is greater than one (most active duel servers that I see host Duel40, where players go against each other for one round per map before returning to the lobby), so I feel like the title of "champion" doesn't have a lot of meaning these days. At least, not enough that I think people are overly concerned about keeping their title because they won more rounds than anyone else, rather than how it works right now. The current behaviour also means that we don't need to think about what happens when two players have the same amount of wins, since the champion will be whoever has the current winning streak.

Personally, if the current behaviour isn't bothering anyone, I'd rather keep it the way it is and keep things simple.
(0023888)
unknownna   
2024-08-02 10:19   
The counter looks really good and feels like a natural addition to the mode! Finally we have it at last.

Quote from Kaminsky
Note that this doesn't fix players losing their wins when they become a spectator, but that's a separate issue that has its own ticket.


I assume it's this one:'https://zandronum.com/tracker/view.php?id=4337 [^]'

Quote from Kaminsky
Personally, if the current behaviour isn't bothering anyone, I'd rather keep it the way it is and keep things simple.


Exactly. Let's just keep it as is and move on. If somebody wants some other behavior they should make a ticket for it.
(0023953)
Kaminsky   
2024-08-18 04:28   
This commit:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/840e31e952272fb12196a2904b90da16b3b73dd3 [^]' got pushed recently. Since this adds the "wins" column to duel as the ticket originally suggested, I'm going to mark this ticket as resolved.