MantisBT - Zandronum
View Issue Details
0004361Zandronum[All Projects] Suggestionpublic2024-08-04 11:212024-08-27 08:09
unknownna 
Kaminsky 
normaltweakN/A
resolvedfixed 
 
3.23.2 
0004361: [3.2] Change the counters in PvP modes on the scoreboard that count "x frags left" etc. to a static "fraglimit x"
As noted in my other comment in'https://zandronum.com/tracker/view.php?id=4288#c23887 [^]' , it's a bit confusing to have 2 counters that count opposite ways on the scoreboard.

An example would be in domination mode with a pointlimit of 100. It will start out saying "100 points left", but when a team captures some territory and starts to earn points, the counter will count downwards while there's a counter right beneath it incrementing and comparing points between teams.
The problem with this is that when you look at the scoreboard during mid-game, you will not get a clear indication of what the pointlimit actually is, unless you calculate it yourself by comparing the team points to the "x points left" message.
Ideally it should just say "pointlimit 100" or something so players will always have a clear indication of what it's set to and what the goal to reach is.

The only exception I can think of at the moment is duel and coop modes, where you want duellimit and x amount of monsters/secrets to count downwards.
And maybe an exception for wavelimit in invasion, but I'm not sure which way feels best here.
No tags attached.
related to 0001829resolved Kaminsky Customizable scoreboard 
Issue History
2024-08-04 11:21unknownnaNew Issue
2024-08-04 12:17unknownnaDescription Updatedbug_revision_view_page.php?rev_id=14339#r14339
2024-08-04 13:51unknownnaNote Added: 0023897
2024-08-04 13:51unknownnaDescription Updatedbug_revision_view_page.php?rev_id=14340#r14340
2024-08-04 13:52unknownnaDescription Updatedbug_revision_view_page.php?rev_id=14341#r14341
2024-08-18 04:16KaminskyNote Added: 0023951
2024-08-18 04:16KaminskyAssigned To => Kaminsky
2024-08-18 04:16KaminskyStatusnew => needs review
2024-08-18 04:16KaminskyTarget Version => 3.2
2024-08-18 04:16KaminskyRelationship addedrelated to 0001829
2024-08-18 10:40unknownnaNote Added: 0023959
2024-08-18 10:40unknownnaStatusneeds review => feedback
2024-08-25 13:31KaminskyNote Added: 0023967
2024-08-25 13:31KaminskyStatusfeedback => needs review
2024-08-25 14:40KaminskyNote Edited: 0023967bug_revision_view_page.php?bugnote_id=23967#r14359
2024-08-25 14:40KaminskyStatusneeds review => needs testing
2024-08-26 10:11unknownnaNote Added: 0023975
2024-08-26 10:11unknownnaStatusneeds testing => feedback
2024-08-26 10:12unknownnaNote Edited: 0023975bug_revision_view_page.php?bugnote_id=23975#r14363
2024-08-26 12:48KaminskyNote Added: 0023976
2024-08-26 12:49KaminskyStatusfeedback => needs review
2024-08-26 12:50KaminskyNote Edited: 0023976bug_revision_view_page.php?bugnote_id=23976#r14365
2024-08-27 08:09unknownnaNote Added: 0023980
2024-08-27 08:09unknownnaStatusneeds review => resolved
2024-08-27 08:09unknownnaFixed in Version => 3.2
2024-08-27 08:09unknownnaResolutionopen => fixed

Notes
(0023897)
unknownna   
2024-08-04 13:51   
Fixed wrongly linked comment.
(0023951)
Kaminsky   
2024-08-18 04:16   
'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/170 [^]'

Personally, I still like the appearance of "x things left" because then I immediately know how close a player or team is to winning. To satisfy everyone, I added the CVar "cl_showscoreleft" (default = true), so users have the option to choose between which format they like more: the more dynamic "x things left" message, or the static "x things to win" message.
(0023959)
unknownna   
2024-08-18 10:40   
I really appreciate this feature. It's good that you can flick between the styles depending on which way you prefer. Good work!

* If you have cl_showscoreleft set to 0, the fullscreen cl_stfullscreenhud HUD will show a static "x left" message in the upper right. Could you maybe change the wording a little to "x to win" when cl_showscoreleft is 0? That would make it consistent with the scoreboard and prevent it from looking like a bugged counter that is frozen. Or alternately still make it count down there as an exception, that would work too.
* The server window also seems to use this this client setting, though I guess it doesn't really matter.

After playing around with it for a while, I think it would maybe be nice if some colors for either the limits, leaders, or the server name were different to the default gray. It would help break up and distinguish between the many lines of gray headers currently present.
I'll probably make a separate ticket for this later.

The scoreboard is really starting to shape up nicely!
(0023967)
Kaminsky   
2024-08-25 13:31   
(edited on: 2024-08-25 14:40)
I tweaked the CVar a bit, based on your feedback:

- cl_showscoreleft is now used on the fullscreen HUD, and will change the wording to "x (y to win)" if that CVar's disabled. Otherwise, it shows "x (y left)" as it always used to.'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/1990ec1fa24df7d35aea593d8f10cac650043843 [^]'

- cl_showscoreleft doesn't affect the scoreboard in the server console window. I had no intention of letting this CVar affect it.'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/44cc322d783a6c90942399b82a01b4d4ddc02b70 [^]'

(0023975)
unknownna   
2024-08-26 10:11   
(edited on: 2024-08-26 10:12)
Thanks a lot for this. It works nicely from a quick test, but I noticed that it feels a bit odd in coop modes where there's monsters left and it still prints "x to win". I'd make an exception for modes with monsters and just let it use the "cl_showscoreleft 1" behavior.

And I'm not sure where this feature is supposed to show up:
Quote from Kaminsky
and only use a percentage (i.e. a percentage of how many monsters are left) in game modes where players earn kills.


(0023976)
Kaminsky   
2024-08-26 12:48   
(edited on: 2024-08-26 12:50)
This should be fixed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/178 [^]'

To clarify what I said earlier: what I meant was that the string should only use the format "x (%y left) if both "sv_killallmonsters" is enabled and the current game mode is one where players earn kills (e.g. cooperative, survival, invasion). Otherwise, use "x (y left)", or "x (y to win)" for other earn types. Prior to the changes above, it also used the percentage in game modes where players earn frags, points, or wins, as long as the CVar was enabled, which isn't right.

(0023980)
unknownna   
2024-08-27 08:09   
Thanks for the detailed explanation, this works really good now. Amazing work.