MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003852Doomseeker[All Projects] Epicpublic2020-08-01 16:472021-08-16 19:22
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.1 
Target Version1.3.2Fixed in Version1.3.2 
Summary0003852: Doomseeker 1.3.2 release
DescriptionPol M seemed to be in favor of a trivial stable release due to 0003851 being a major severity issue. I wanted to express that I am also in support of making a new trivial release.

Let's make a stable release of Doomseeker 1.3.2 to include all the fixes made since 1.3.1 in the official Doomseeker packages?
Steps To ReproduceSee 0003735 and follow the established procedure from the previous release.
Additional Information
TagsNo tags attached.
Relationships
related to 0003851closed Pol M Malformed serverinfo data from SRB2 versions > 2.2.6 
Attached Filestxt release-checklist.txt (2,604) 2021-08-07 12:00
https://zandronum.com/tracker/file_download.php?file_id=2651&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-08-01 16:47WubTheCaptainNew Issue
2020-08-01 16:47WubTheCaptainRelationship addedrelated to 0003851
2020-08-01 16:55WubTheCaptainNote Added: 0021517
2020-08-01 17:48Pol MNote Added: 0021520
2020-08-01 17:48Pol MAssigned To => Pol M
2020-08-01 17:48Pol MStatusnew => acknowledged
2020-08-02 08:27ZalewaNote Added: 0021523
2020-08-02 12:21WubTheCaptainStatusacknowledged => feedback
2020-08-02 12:22WubTheCaptainNote Added: 0021524
2020-08-02 12:22WubTheCaptainStatusfeedback => assigned
2020-08-02 12:22WubTheCaptainStatusassigned => resolved
2020-08-02 12:22WubTheCaptainResolutionopen => suspended
2021-08-07 09:02ZalewaAssigned ToPol M => Zalewa
2021-08-07 09:02ZalewaStatusresolved => assigned
2021-08-07 09:03ZalewaNote Added: 0021672
2021-08-07 09:07ZalewaNote Added: 0021673
2021-08-07 12:00ZalewaFile Added: release-checklist.txt
2021-08-07 12:04ZalewaNote Added: 0021674
2021-08-07 12:05ZalewaAssigned ToZalewa => Blzut3
2021-08-07 12:05ZalewaNote Edited: 0021674bug_revision_view_page.php?bugnote_id=21674#r13306
2021-08-07 16:39Blzut3Target Version => 1.3.2
2021-08-07 16:40Blzut3Note Added: 0021675
2021-08-08 09:25Blzut3Note Added: 0021682
2021-08-08 09:26Blzut3Note Edited: 0021682bug_revision_view_page.php?bugnote_id=21682#r13310
2021-08-08 09:26Blzut3Assigned ToBlzut3 => Zalewa
2021-08-08 10:18ZalewaNote Added: 0021683
2021-08-08 10:23Blzut3Note Added: 0021684
2021-08-08 10:32ZalewaNote Added: 0021685
2021-08-08 10:33ZalewaStatusassigned => resolved
2021-08-08 10:33ZalewaFixed in Version => 1.3.2
2021-08-08 10:33ZalewaResolutionsuspended => fixed
2021-08-08 10:40Blzut3Note Added: 0021686
2021-08-16 19:03WubTheCaptainStatusresolved => closed
2021-08-16 19:18WubTheCaptainNote Added: 0021734
2021-08-16 19:20WubTheCaptainNote Edited: 0021734bug_revision_view_page.php?bugnote_id=21734#r13331
2021-08-16 19:22WubTheCaptainNote Edited: 0021734bug_revision_view_page.php?bugnote_id=21734#r13332

Notes
(0021517)
WubTheCaptain   
2020-08-01 16:55   
If acknowledged / confirmed, I guess the 4 or 5 commits in master HEAD after 1.3.1 are good to also go to 1.3.2 and I'll re-sort the issues targeting 1.4.
(0021520)
Pol M   
2020-08-01 17:48   
Yeah, we at least need to release an updated plugin. The current SRB2 plugin is pretty much unusable :)
(0021523)
Zalewa   
2020-08-02 08:27   
The only actual change to the executable code other than Pol's SRB2 fix is the static linking of updater.exe (that I made minutes ago). Does this warrant release of a new version of the whole program instead of just updating the plugin? Only for Windows users, and only for those who will go out of their way to manually download and update the program just to get the updater.exe working again.
(0021524)
WubTheCaptain   
2020-08-02 12:22   
🤷
I take it as a no for now.
(0021672)
Zalewa   
2021-08-07 09:03   
The update for the Odamex plugin (0003878) also requires to update the base program. We can proceed with the release of 1.3.2 now.
(0021673)
Zalewa   
2021-08-07 09:07   
Blzut, can you add 1.3.2 to the tracker please?
(0021674)
Zalewa   
2021-08-07 12:04   
(edited on: 2021-08-07 12:05)
The release procedure is complicated, takes a lot of time and is error prone. I prepared and attached to this ticket the "release-checklist.txt" file. I can't say if this list is complete, but already it's helpful in tracking if all stuff is done. I also kept Blzut's points vague because I don't know the exact details.

From the checklist I completed everything that's under "1. Zalewa". Reassigning to Blzut.
(0021675)
Blzut3   
2021-08-07 16:40   
1.3.2 added.
(0021682)
Blzut3   
2021-08-08 09:25   
(edited on: 2021-08-08 09:26)
Ubuntu and Mac binaries are uploaded. Mac binary is properly notarized this time (which IIRC I didn't quite get working in previous builds).

Source tarballs are also uploaded, note that building and signing these files is captured in an automated script under releasescripts so not sure why you had generating them in your task list?

Tasks for the Ubuntu packages are:
- Build packages without dependency scanning, making sure to run cpackpostprocess.sh.
- Install new libwadseeker on build system.
- Rebuild packages with dependency scanning and deploy to repository.

For the Mac it's basically "find out what Apple broke this time around" and "run build script and deploy." :P
(0021683)
Zalewa   
2021-08-08 10:18   
Cool. I updated the webpage. Here's the forums announcement. The release should be done then.

Quote from Blzut3
For the Mac it's basically "find out what Apple broke this time around" and "run build script and deploy." :P

The M1 Macs aren't giving any problems?
(0021684)
Blzut3   
2021-08-08 10:23   
Honestly haven't had much trouble getting software to work on the M1. In regards to Doomseeker the only thing is the awkward timing where they came out right as Qt 5 was being discontinued (and upstream no longer doing LTS for open source users), so we can only support them through Rosetta until we add Qt 6 support (although I wouldn't be too surprised if someone out there had a patch set to add ARM support to Qt 5.15). Of course this also means the major design change of Big Sur also came at just the right time, but Qt 5 still works mostly OK regardless.
(0021685)
Zalewa   
2021-08-08 10:32   
Ahhh... it seems like we've only just dealt with Qt 4 and now its time to deal with Qt 5 :)

Anyway, that's a separate manner. I'm resolving this one.
(0021686)
Blzut3   
2021-08-08 10:40   
Given that distros like Ubuntu haven't even picked up Qt 6 yet, it'll certainly be awhile before we're killing Qt 5 support. 2025 at the earliest, good chance that Qt 6 support in 22.04 will be lack luster if it's even in the repo, so probably looking at 2027 honestly. But we'll definitely be needing Qt 6 for macOS sooner than later, and I suppose wouldn't hurt for Windows either.
(0021734)
WubTheCaptain   
2021-08-16 19:18   
(edited on: 2021-08-16 19:22)
I closed this issue before being reminded about 0003852:0021517:
Quote from WubTheCaptain
and I'll re-sort the issues targeting 1.4.

Blzut3 had closed them. These are now re-sorted to target 1.3.2 (back then it was known on MantisBT as 1.4).

I also removed the target version from 0003746, which initially meant to target 1.3.2.

This one's good to close.