Zandronum Chat @ irc.zandronum.com
#zandronum
Get the latest version: 3.0
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003758Doomseeker[All Projects] Bugpublic2020-01-30 17:232020-01-30 19:36
ReporterWubTheCaptain 
Assigned ToPol M 
PrioritynormalSeveritytrivialReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.3 
Target Version1.4Fixed in Version1.4 
Summary0003758: Non-dominating UNIX newline in src/core/datapaths.h
Description0003740:0021168:
Quote from Zalewa
Newline consistency across the whole project is not needed. It's only needed to have newline consistency in a file. If there are inconsistent lines in some file then this file has problems and should be fixed.

There's tools/normalize_nl.py in the Doomseeker repo that can scour a whole subdirectory tree and alter all files within it to have the dominating newline style in each file be the consistent one in that single file.

Files that are 3rd party should not be modified even if they have inconsistent newlines.

0003740:0021170:
Quote from WubTheCaptain
Actually, one line is not consistent in src/core/datapaths.h.
Steps To Reproduce
git clonehttps://bitbucket.org/Doomseeker/doomseeker/ [^]
cd doomseeker
git checkout 1.3.1
python3 ./tools/src/ src/ .cpp,.c,.h,.hpp
# git diff --cached, or some other way such as git commit -av to view staged diffs
Attached Filespatch file icon 0001-Normalize-newlines-to-the-dominating-newline-style.patch [^] (947 bytes) 2020-01-30 17:25 [Show Content]

- Relationships
related to 0003740resolvedWubTheCaptain Newlines in git show may show up as ^M 

-  Notes
User avatar (0021172)
WubTheCaptain (developer)
2020-01-30 17:28
edited on: 2020-01-30 17:28

As for why this happened: Commit 4fb646d23 by Pol M. Not sure if it's because of an automated tool? The diff for that commit has both DOS newlines and UNIX newlines in it.

User avatar (0021174)
Zalewa (developer)
2020-01-30 17:42

Applied
User avatar (0021175)
WubTheCaptain (developer)
2020-01-30 17:42

https://bitbucket.org/Doomseeker/doomseeker/commits/41293c52803b07e4938b97c8e5294629f88fdb86 [^]

🤷
User avatar (0021176)
Pol M (developer)
2020-01-30 19:36

I have absolutely no idea why this happened exclusively on this file 🤷🏻‍♂️

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2020-01-30 17:23 WubTheCaptain New Issue
2020-01-30 17:23 WubTheCaptain Status new => assigned
2020-01-30 17:23 WubTheCaptain Assigned To => WubTheCaptain
2020-01-30 17:25 WubTheCaptain File Added: 0001-Normalize-newlines-to-the-dominating-newline-style.patch
2020-01-30 17:25 WubTheCaptain Status assigned => needs review
2020-01-30 17:26 WubTheCaptain Relationship added related to 0003740
2020-01-30 17:28 WubTheCaptain Note Added: 0021172
2020-01-30 17:28 WubTheCaptain Note Edited: 0021172 View Revisions
2020-01-30 17:31 WubTheCaptain Assigned To WubTheCaptain => Pol M
2020-01-30 17:31 WubTheCaptain Status needs review => assigned
2020-01-30 17:31 WubTheCaptain Status assigned => needs review
2020-01-30 17:42 Zalewa Note Added: 0021174
2020-01-30 17:42 WubTheCaptain Note Added: 0021175
2020-01-30 17:42 WubTheCaptain Status needs review => resolved
2020-01-30 17:42 WubTheCaptain Fixed in Version => 1.4
2020-01-30 17:42 WubTheCaptain Resolution open => fixed
2020-01-30 17:49 WubTheCaptain Product Version 1.3.1 => 1.3
2020-01-30 19:36 Pol M Note Added: 0021176






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker