MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003662Doomseeker[All Projects] Epicpublic2019-06-18 10:272024-11-03 19:10
ReporterPol M 
Assigned ToZalewa 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionwon't fix 
PlatformLinuxOSArchOS Versionx86-64
Product Version1.2 
Target Version1.4.0Fixed in Version1.4.0 
Summary0003662: SRB2Kart engine is handled poorly by our SRB2 engine
DescriptionA new fork of SRB2 has been created, and currently we're getting its servers from the SRB2 master server. Of course, the default SRB2 engine doesn't work in these servers. It should be discussed what to do with these.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0003958closed Zalewa SRB2 plugin is unmaintained 
parent of 0003656closed Pol M Srb2 player column is broken. They seem overflowed by players with empty names. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-06-18 10:27Pol MNew Issue
2019-06-18 10:27Pol MStatusnew => assigned
2019-06-18 10:27Pol MAssigned To => Pol M
2019-06-18 23:53WubTheCaptainRelationship addedparent of 0003656
2019-06-19 00:01WubTheCaptainNote Added: 0020770
2019-06-19 00:01WubTheCaptainSummaryHandling the new SRB2Kart engine => SRB2Kart engine is handled poorly by our SRB2 engine
2019-06-19 00:03WubTheCaptainNote Added: 0020771
2019-06-19 00:03WubTheCaptainAssigned ToPol M => WubTheCaptain
2019-06-19 00:03WubTheCaptainStatusassigned => feedback
2019-06-19 00:06WubTheCaptainReproducibilityalways => N/A
2019-06-19 00:08WubTheCaptainNote Edited: 0020771bug_revision_view_page.php?bugnote_id=20771#r12640
2019-06-19 10:34Pol MNote Added: 0020777
2019-06-19 10:34Pol MStatusfeedback => assigned
2019-06-19 10:35Pol MStatusassigned => feedback
2019-06-19 10:35Pol MStatusfeedback => confirmed
2019-06-20 00:19WubTheCaptainProduct Version1.3 => 1.2
2019-06-20 01:01WubTheCaptainAssigned ToWubTheCaptain => Pol M
2019-06-20 01:01WubTheCaptainStatusconfirmed => assigned
2019-06-20 22:04Pol MNote Added: 0020787
2019-06-20 22:10Pol MNote Edited: 0020787bug_revision_view_page.php?bugnote_id=20787#r12655
2019-06-21 14:52ZalewaNote Added: 0020789
2019-06-21 15:00Pol MNote Added: 0020791
2019-06-21 15:00Pol MNote Edited: 0020791bug_revision_view_page.php?bugnote_id=20791#r12659
2019-06-25 14:27Pol MNote Edited: 0020791bug_revision_view_page.php?bugnote_id=20791#r12696
2019-06-25 14:27Pol MAssigned ToPol M =>
2019-06-25 14:27Pol MStatusassigned => confirmed
2019-07-20 06:33ZalewaTarget Version1.3 =>
2022-09-10 14:50ZalewaRelationship addedrelated to 0003958
2022-09-10 14:50ZalewaTarget Version => 1.4.0
2023-01-04 15:44ZalewaAssigned To => Zalewa
2023-01-04 15:44ZalewaStatusconfirmed => assigned
2023-01-04 16:58ZalewaNote Added: 0022631
2023-01-04 16:58ZalewaStatusassigned => resolved
2023-01-04 16:58ZalewaFixed in Version => 1.4.0
2023-01-04 16:58ZalewaResolutionopen => won't fix
2024-11-03 19:10ZalewaStatusresolved => closed

Notes
(0020770)
WubTheCaptain   
2019-06-19 00:01   
(Summarizing the summary into an issue.)
(0020771)
WubTheCaptain   
2019-06-19 00:03   
(edited on: 2019-06-19 00:08)
Are issues like this and 0003656 also reproducible in the latest supported stable release of Doomseeker (1.2)?
(0020777)
Pol M   
2019-06-19 10:34   
Yes, they are.
(0020787)
Pol M   
2019-06-20 22:04   
(edited on: 2019-06-20 22:10)
So, I have some bad news:
Quote from Sryder

I don't see a simple way currently in the game. Which is frustrating because there is a MODID actually in there, but it's not sent back from the server in anything and is only used to check that the game is on the latest version when starting a server from what I can see. There is, of course, the version and subversion sent back in the PT_SERVERINFO packet, but that's likely to change on both counts, unfortunately. patch.kart is also not 100% likely as it's only included to include patch data when the base game needed something changed or added. I think it'd definitely be worth seeing if MODID can be sent from servers directly eventually, I think it'll need to be the same for classic SRB2 though.


That kinda makes it impossible to know what kind of server we have. Also, while all srb2kart use *.kart, that's not an option since there's a chance that eventually that's not the case. I may report SRB2 to ask if it'd be a way to know what kind of server we're dealing with, the "easy way" would be to extend the current network implementation.
(0020789)
Zalewa   
2019-06-21 14:52   
Perhaps a dumb but effective workaround would be to heuristically check that the player list is garbled after parsing it the SRB2 way and reinterpret the packet in the SRB2Kart way?
(0020791)
Pol M   
2019-06-21 15:00   
(edited on: 2019-06-25 14:27)
The playerlist error has been patched and will no longer occour on the next release, so we can't use this mistake to distinguish them :/

EDIT: I'm gonna de-assign myself from this one. The best I can think of is a dropdown menu to make the user select the engine they want, but I feel like it's a rather bad solution. I'll let this one rest a bit.
(0022631)
Zalewa   
2023-01-04 16:58   
The SRB2 plugin will be removed from the 1.4 release, so this problem is now moot.
'https://bitbucket.org/Doomseeker/doomseeker/commits/368f0df909fbb7834ff8c78bfd735f529476ecce [^]'