|Anonymous | Login | Signup for a new account||2019-06-26 12:00 UTC|
|My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003656||Doomseeker||[All Projects] Bug||public||2019-06-05 14:33||2019-06-20 00:19|
|Assigned To||Pol M|
|Status||resolved||Resolution||no change required|
|Target Version||1.3||Fixed in Version|
|Summary||0003656: Srb2 player column is broken. They seem overflowed by players with empty names.|
|Description||Zalewa once pointed that the srb2 servers were registering incorrect amounts of players, and today I checked that, indeed, they were brocken. The issue can be easily understood with a photo.|
The server looks full and there are more players than the limit suggests. While hovering the mouse reveals the name of the connected players, the rest seem empty.
|Steps To Reproduce||Open doomseeker, and enable srb2.|
Notice that the srb2 player column has impossible amounts of players.
|Additional Information||Not all servers are affected. Maybe there is a new release?|
|Attached Files|| Screenshot_20190605_163131.png [^] (13,425 bytes) 2019-06-05 14:33
Screenshot_20190605_163514.png [^] (4,854 bytes) 2019-06-05 14:35
Pol M (developer)
Okay, the issue is caused by a new fork of srb2: SRB2Kart.
Now, about what should be done, I'm not that sure. The empty players can be ruled out without problems due to these having absolutely all values set to 0, but I'd say that first we should notify the developers that they are not marking the players as non-existent (for reference, src/plugins/srb2/srb2server.cpp:275, the check is failing due to the node not being 0xff). Also, this is a fork, not the main engine, and leaving as is does not feel right: it requires its own program, and based on the fact that this ticket exists clearly the internet communications may change. Hoping to hear from you on whether we should rule them out, create a new plugin, or else.
If they don't follow packet compatbility and yet report to the same master server they basically screwed themselves over.
Is there something in the packet that would allow us to recognize that it is from a different game and interpret the packet differently?
Pol M (developer)
Quote from Zalewa
Appart from the fact that the players are pretty much empty (score is 0, name is "", seconds in server is 0, etc...) nothing rellevant, the player structure is the same. Maybe they have done a change somewhere that is backwards-compatible? I think that the best idea is to ask. If you're okay with it, I'll contact them.
|Sure, go ahead and contact them :)|
Pol M (developer)
edited on: 2019-06-18 09:33
I posted on their bug report thread: post
Issue fixed by Sryder in this PR
I'll also ask if there is an easy way to distinguish both engines, and I'll create a ticket to discuss what should be done with this new engine.
|Since we didn't do anything in Doomseeker code (in this reported issue) to resolve the issue with non-compat packets from pre-PR servers, I'm changing this to "no change required".|
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
|Supporters:||No one explicitly supports this issue yet.|
|Opponents:||No one explicitly opposes this issue yet.|
|2019-06-05 14:33||Pol M||New Issue|
|2019-06-05 14:33||Pol M||File Added: Screenshot_20190605_163131.png|
|2019-06-05 14:34||Pol M||Description Updated||View Revisions|
|2019-06-05 14:35||Pol M||File Added: Screenshot_20190605_163514.png|
|2019-06-05 14:38||Pol M||Additional Information Updated||View Revisions|
|2019-06-05 14:38||Pol M||Assigned To||=> Pol M|
|2019-06-05 14:38||Pol M||Status||new => acknowledged|
|2019-06-05 14:38||Pol M||Assigned To||Pol M =>|
|2019-06-05 14:57||Pol M||Assigned To||=> Pol M|
|2019-06-05 14:57||Pol M||Status||acknowledged => assigned|
|2019-06-06 16:26||Pol M||Note Added: 0020732|
|2019-06-09 19:06||Zalewa||Note Added: 0020734|
|2019-06-09 20:57||Pol M||Note Added: 0020737|
|2019-06-12 00:52||WubTheCaptain||Reproducibility||always => sometimes|
|2019-06-13 15:04||Zalewa||Note Added: 0020759|
|2019-06-13 17:52||Pol M||Note Added: 0020763|
|2019-06-16 14:07||Pol M||Note Edited: 0020763||View Revisions|
|2019-06-18 09:33||Pol M||Note Edited: 0020763||View Revisions|
|2019-06-18 09:33||Pol M||Status||assigned => resolved|
|2019-06-18 09:33||Pol M||Fixed in Version||=> 1.3|
|2019-06-18 09:33||Pol M||Resolution||open => fixed|
|2019-06-18 23:47||WubTheCaptain||Note Added: 0020768|
|2019-06-18 23:47||WubTheCaptain||Resolution||fixed => no change required|
|2019-06-18 23:47||WubTheCaptain||Fixed in Version||1.3 =>|
|2019-06-18 23:53||WubTheCaptain||Relationship added||child of 0003662|
|2019-06-20 00:19||WubTheCaptain||Product Version||1.3 => 1.2|
Questions or other issues? Contact Us.
|Copyright © 2000 - 2019 MantisBT Team|