mode=c
style=allman
indent=force-tab=4
indent-cases
indent-namespaces
indent-after-parens
indent-continuation=1
min-conditional-indent=1
max-continuation-indent=80
align-pointer=type
align-reference=type

pad-oper
pad-comma
pad-header

#attach-return-type
#attach-return-type-decl

#remove-braces

Quote from Wub

Now, I'm not so sure how useful documenting these rules would be without continuous integration (CI) checks.

Quote from Wub

Our CI is kind of "meh" currently?

Quote from Wub

Maybe an experienced programmer can look around the source code and try to mimic the existing programming style. Or maybe the maintainer decides to accept a patch, but further contribute to fit the programming style wanted right after.

if(!plugin.data()->demoExtensionAutomatic){}

if (!plugin.data()->demoExtensionAutomatic)
{
}

Quote from Wub

If there are "some minor style differences in different files", it's an issue we should fix; please create a new issue ticket for this for me to work on.

DisableFormat: false
Language: Cpp
Standard: Cpp03
TabWidth: 4
IndentWidth: 4
UseTab: ForContinuationAndIndentation

AccessModifierOffset: -4
AlignAfterOpenBracket: DontAlign
AlignConsecutiveAssignments: false
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperands: false
AlignTrailingComments: true
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: true
AllowShortCaseLabelsOnASingleLine: false
AllowShortFunctionsOnASingleLine: All
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: false
AlwaysBreakTemplateDeclarations: No
BinPackArguments: true
BinPackParameters: true
BreakBeforeBraces: Custom
BraceWrapping:
  AfterClass: true
  AfterControlStatement: true
  AfterEnum: true
  AfterFunction: true
  AfterNamespace: true
  AfterStruct: true
  AfterUnion: true
  AfterExternBlock: true
  BeforeCatch: true
  BeforeElse: true
  SplitEmptyFunction: false
  SplitEmptyRecord: false
  SplitEmptyNamespace: false
BreakBeforeBinaryOperators: None
BreakConstructorInitializers: AfterColon
BreakInheritanceList: AfterColon
BreakStringLiterals: false
ColumnLimit: 80
CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: false
ConstructorInitializerIndentWidth: 4
ContinuationIndentWidth: 4
Cpp11BracedListStyle: false
DerivePointerAlignment: true
FixNamespaceComments: false
ForEachMacros: ['foreach']
IncludeBlocks: Preserve
IndentCaseLabels: true
IndentPPDirectives: None
IndentWrappedFunctionNames: true
KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: 1
NamespaceIndentation: All
PointerAlignment: Left
ReflowComments: true
SortIncludes: true
SortUsingDeclarations: true
SpaceAfterCStyleCast: true
SpaceAfterTemplateKeyword: false
SpaceBeforeAssignmentOperators: true
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 1
SpacesInAngles: false
SpacesInCStyleCastParentheses: false
SpacesInParentheses: false
SpacesInSquareBrackets: false

PenaltyBreakAssignment: 30
PenaltyBreakComment: 5
PenaltyBreakFirstLessLess: 30
PenaltyBreakString: 25
PenaltyBreakTemplateDeclaration: 100
PenaltyExcessCharacter: 15
PenaltyReturnTypeOnItsOwnLine: 100

Quote from "Pol M"
What issues do you have with .cpp files?

Quote from Zalewa

This can be solved by converting the 'foreach' macros into C++11's for-each loops.

Quote from Zalewa

1. What would be the proposed approach to ensure that this is applied to all commits? For me, at least, it appears that Emacs can integrate with uncrustify. I haven't checked that yet but if it works as expected then it should be enough. What about everyone else?

Quote from Zalewa

- dmflags in Zandronum plugin are ripped straight out from Zandronum source. These should not be touched for easier diffing with the original code in Zandronum, however all of the code that surrounds them is free to be uncrustified.

Quote from Zalewa

- Turok 2 EX CRC code refuses to compile after uncrustification due to reliance on order of #includes, however this can be considered as bug and fixed.

Quote from Zalewa
Turok 2 EX CRC code refuses to compile after uncrustification due to reliance on order of #includes, however this can be considered as bug and fixed.

gLog << tr("text"
\t\t"following text");

default:
\tsomething(); // intentional fall-through

#!/bin/bash
uncrustify -c uncrustify.cfg --replace --no-backup \
    $(find src -type f -name '*.cpp' -or -name '*.h' -or -name '*.c' \
        | grep -v src/wadseeker/lzma \
        | grep -v /huffman/ \
        | grep -v json \
        | grep -vE 'zandronum(2|3)dmflags\.h' )

Quote from Zalewa

"indent_shift = true" screws up enum braces in "src/plugins/zandronum/zandronumgameinfo.h".

Quote from Zalewa

If any of these problems can be fixed then it'd be good to fix them, but anyway I think the main goal of this ticket has been achieved