MantisBT - Doomseeker
View Issue Details
0003399Doomseeker[All Projects] Bugpublic2018-03-04 12:202018-10-27 22:53
WubTheCaptain 
Zalewa 
lowminoralways
closedfixed 
1.1 
1.21.2 
0003399: Buddies: Deleting an invalid basic pattern type will remove the next pattern in list index
In Buddies list, because of issue 0003398 []Wub is still accepted as a basic pattern type while it is actually invalid and silently discarded on next restart.

However before restarting Doomseeker, trying to delete this invalid pattern type from Buddies will also remove the next pattern type in the list.
  1. Launch Doomseeker.
  2. Open "Buddies" if it's not open already: View → Buddies (Ctrl+B)
  3. Click "Manage" in the Buddies window.
  4. Remove any existing pattern types, if applicable.
  5. Press "Add" and add a new basic pattern type: []Wub
  6. Press "Add" and add a new advanced pattern type: \[\]Wub
  7. Right click basic pattern type []Wub and delete it. \[\]Wub should still be in the list.
  8. Restart Doomseeker.
  9. Notice how deleting the invalid pattern type []Wub also deleted the next pattern \[\]Wub in the list.
Closely related to 0003398, a side-effect of that bug. Ditto in 1.2~beta-1.
No tags attached.
child of 0003398closed Zalewa Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type but not matching and the pattern is removed on launch 
Issue History
2018-03-04 12:20WubTheCaptainNew Issue
2018-03-04 12:21WubTheCaptainAdditional Information Updatedbug_revision_view_page.php?rev_id=11478#r11478
2018-03-04 12:21WubTheCaptainRelationship addedparent of 0003398
2018-03-04 12:25WubTheCaptainSummaryBuddies: Deleting an invalid basic pattern type will remove the next pattern type in list index => Buddies: Deleting an invalid basic pattern type will remove the next pattern in list index
2018-03-04 12:34WubTheCaptainNote Added: 0019135
2018-03-04 12:38WubTheCaptainNote Edited: 0019135bug_revision_view_page.php?bugnote_id=19135#r11480
2018-10-05 06:36WubTheCaptainPrioritynormal => low
2018-10-13 14:46ZalewaAssigned To => Zalewa
2018-10-13 14:46ZalewaStatusnew => assigned
2018-10-13 16:49ZalewaNote Added: 0020103
2018-10-13 16:49ZalewaStatusassigned => needs testing
2018-10-13 16:59WubTheCaptainNote Edited: 0020103bug_revision_view_page.php?bugnote_id=20103#r12257
2018-10-13 17:00WubTheCaptainTarget Version => 1.2
2018-10-13 17:48WubTheCaptainRelationship replacedchild of 0003398
2018-10-13 17:55WubTheCaptainNote Added: 0020107
2018-10-13 17:55WubTheCaptainStatusneeds testing => resolved
2018-10-13 17:55WubTheCaptainFixed in Version => 1.2
2018-10-13 17:55WubTheCaptainResolutionopen => fixed
2018-10-27 22:53WubTheCaptainStatusresolved => closed

Notes
(0019135)
WubTheCaptain   
2018-03-04 12:34   
(edited on: 2018-03-04 12:38)
I guess there's so many more bugs one can do with arrays where the internal state doesn't match the state in the GUI, but I won't go more into detail of those. At worst, the possible outcome could be a crash via out of bounds array but I can't think quickly of a way to do that.

(0020103)
Zalewa   
2018-10-13 16:49   
(edited on: 2018-10-13 16:59)
The commit proposed for 0003398 should remove the possibility of adding an invalid pattern and possibly render this a non-issue.

(0020107)
WubTheCaptain   
2018-10-13 17:55   
Hopefully so.