MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003394Doomseeker[All Projects] Suggestionpublic2018-03-03 18:512018-10-27 22:55
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSDebian GNU/LinuxOS Versionbuster/sid
Product Version1.1 
Target Version1.2Fixed in Version1.2 
Summary0003394: Create Game: Allow hiding passwords in the "Misc." tab
DescriptionThere's some visible parts in the Create Game dialog with secrets (passwords) displayed in plaintext with no option to hide them.

Of course, they will be stored in plaintext in config files but allowing to hide the passwords may at least provide some security from an adversary learning secrets by watching over the shoulder if hidden.
Steps To Reproduce
  1. Start Doomseeker.
  2. Press the Create Game icon, or navigate to File → Create Game (Ctrl+S).
  3. Navigate to the "Misc." tab.
  4. Input any characters to three of the password dialogs ("Connect password:", "Join password:", "RCon password:").
  5. Notice how the characters are displayed as plaintext and not bullets.
  6. Notice how there is no checkbox option next to these forms to toggle hiding the passwords between plaintext and bullets.
Additional InformationI acknowledge some of these will still be visible in the "Show join command line" dialog, as intended.

Doomseeker 1.2 has an option to toggle hiding the password in the RCon client, so far.

I'm using Qt 5.9.2.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-03 18:51WubTheCaptainNew Issue
2018-03-03 18:51WubTheCaptainAdditional Information Updatedbug_revision_view_page.php?rev_id=11442#r11442
2018-03-03 18:52WubTheCaptainSummaryCreate Game: Allow hiding passwords in the "Misc." tab from being displayed => Create Game: Allow hiding passwords in the "Misc." tab
2018-03-03 19:20WubTheCaptainNote Added: 0019112
2018-03-03 19:20WubTheCaptainStatusnew => feedback
2018-03-03 19:23WubTheCaptainNote Added: 0019113
2018-03-03 19:23WubTheCaptainStatusfeedback => new
2018-03-03 19:23WubTheCaptainNote Edited: 0019113bug_revision_view_page.php?bugnote_id=19113#r11447
2018-08-10 19:59ZalewaNote Added: 0019322
2018-08-10 19:59ZalewaAssigned To => Zalewa
2018-08-10 19:59ZalewaStatusnew => needs review
2018-08-15 09:00ZalewaNote Added: 0019336
2018-08-15 09:00ZalewaStatusneeds review => needs testing
2018-08-20 18:56WubTheCaptainNote Added: 0019345
2018-08-20 18:56WubTheCaptainNote Edited: 0019345bug_revision_view_page.php?bugnote_id=19345#r11622
2018-08-20 18:57WubTheCaptainStatusneeds testing => resolved
2018-08-20 18:57WubTheCaptainResolutionopen => fixed
2018-08-20 18:57WubTheCaptainFixed in Version => 1.2
2018-08-20 18:57WubTheCaptainTarget Version => 1.2
2018-08-20 18:58WubTheCaptainNote Edited: 0019345bug_revision_view_page.php?bugnote_id=19345#r11623
2018-08-20 18:59WubTheCaptainNote Edited: 0019345bug_revision_view_page.php?bugnote_id=19345#r11624
2018-10-27 22:55WubTheCaptainStatusresolved => closed

Notes
(0019112)
WubTheCaptain   
2018-03-03 19:20   
As Zalewa pointed out in ticket 0003393, there is a way to hide them from Appearance settings. (Although, this is a bit buggy and non-working in Doomseeker 1.1, possibly due to config backwards incompatibility issues with 1.1 and 1.2.)

For extra convenience, should a new checkbox "Hide" be added next to the password fields in the "Misc." tab to toggle hiding the password of each form input? Reminding this already exists for Doomseeker 1.2's RCon client.
(0019113)
WubTheCaptain   
2018-03-03 19:23   
Quote from WubTheCaptain
As Zalewa pointed out in ticket 0003393, there is a way to hide them from Appearance settings. (Although, this is a bit buggy and non-working in Doomseeker 1.1, possibly due to config backwards incompatibility issues with 1.1 and 1.2.)


Nevermind me on that, it has no effect on the "Misc." tab in 1.2 either with a new config and "Hide passwords" checked. A bug?
(0019322)
Zalewa   
2018-08-10 19:59   
Done by Pol M:'https://bitbucket.org/Doomseeker/doomseeker/commits/4c84247d451349ad8b09a83b0bc6640bc7dac2f5 [^]'
(0019336)
Zalewa   
2018-08-15 09:00   
A follow-up commit to connect the checkbox with the Appearance "Hide Passwords" configuration setting:'https://bitbucket.org/Doomseeker/doomseeker/commits/dfd10629cc56e294275c5621991720ee650f558d [^]'
(0019345)
WubTheCaptain   
2018-08-20 18:56   
(edited on: 2018-08-20 18:59)
This works, as long as one remembers the intended functionality:
  • The "Hide passwords" option in Appearance settings is permanent and influences the default option in Create Game.
  • The "Hide passwords" option in Create Game is temporary (toggling it here does not change the "Hide passwords" option in Appearance settings), and not saved to the Create Game configuration (as far as I understand it).

Tested with 1.2~beta-180816-2126M (aafacb71daee), which includes both patches.