0004367: Domination territory capture messages missing a period at ends

Notes
(0023911) Kaminsky (developer) 2024-08-07 14:17	This properly adds the period at the end of the message:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/158 [^]'

(0023917) Kaminsky (developer) 2024-08-07 21:31	This commit has been pushed in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/b9989ed6931d8922927ca5f2dc4d8e35d05ff784 [^]' Since it was a very simple typo to fix, I'm going to mark this ticket as resolved already.

(0023956) unknownna (updater) 2024-08-18 07:28	I tested the fix now after checking out the new scoreboard features, and there seems to be a small error in the fix. There's a huge space before the period. See the attached screenshot.

(0023957) Kaminsky (developer) 2024-08-18 08:37	Is it possible that the map itself is at fault for adding trailing whitespace after the sector's name? I don't have the map to confirm that myself.

(0023960) unknownna (updater) 2024-08-18 11:14	You're right. From looking at the SECTINFO lump in the wad (zandom02.wad), there are numerous whitespaces in most of the sector points. That's strange. For some reason it has to do with the way sector names are rendered on the HUD. Here's an example: [MAP14] points = { "the office " = {79}, "the factory " = {217}, "the helipad " = {398}, "the dockyard " = {396}, "the sludge tanks" = {397} } See the attached screenshot. The sector names above are the ones with the added whitespaces. The duplicate sector names beneath are the ones without any whitespaces. It was done that way to work around the way Skulltag/Zandronum aligns the names, or doesn't align them one could say. IMO, this needs to be fixed engine-side by making the sector with the longest name set the initial spacing and alignment for the rest to follow. That way, you can keep the proper period at the end of the capture messages in addition to modders not having to mess around with fake whitespaces to align the way the sector names appear on the HUD.

(0024030) Trillster (reporter) 2024-09-11 03:33	While I was creating an MR to propose some general Domination reworks, I went ahead and addressed the alignment issue as well. 'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/192 [^]'

(0024104) unknownna (updater) 2024-10-26 06:02	Hey, and thanks for doing this! Sorry for being so late with my response. We can mark this ticket as resolved again. I noticed some issues: * A bug where the HUD area messages aren't displayed at lower resolutions beneath 1024x. "x has taken control of y." is missing color for the team that captured territory. * SECTINFO lumps don't overwrite former ones, making users unable to patch old domination mods without updating the whole mod, and leading to duplicate sector names on HUD and duplicate capture messages. I'll make a separate ticket for the issues.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-08-05 21:35	unknownna	New Issue
2024-08-05 21:35	unknownna	File Added: Screenshot_Doom_20240805_232736.png
2024-08-07 14:17	Kaminsky	Note Added: 0023911
2024-08-07 14:17	Kaminsky	Assigned To	=> Kaminsky
2024-08-07 14:17	Kaminsky	Status	new => needs review
2024-08-07 14:17	Kaminsky	Target Version	=> 3.2
2024-08-07 21:31	Kaminsky	Note Added: 0023917
2024-08-07 21:31	Kaminsky	Status	needs review => resolved
2024-08-18 07:28	unknownna	Note Added: 0023956
2024-08-18 07:28	unknownna	Status	resolved => feedback
2024-08-18 07:28	unknownna	Resolution	open => reopened
2024-08-18 07:28	unknownna	File Added: Screenshot_Doom_20240818_092500.png
2024-08-18 08:37	Kaminsky	Note Added: 0023957
2024-08-18 11:14	unknownna	Note Added: 0023960
2024-08-18 11:14	unknownna	Status	feedback => assigned
2024-08-18 11:14	unknownna	File Added: Screenshot_Doom_20240818_130439.png
2024-09-11 03:33	Trillster	Note Added: 0024030
2024-10-26 06:02	unknownna	Note Added: 0024104
2024-10-26 06:02	unknownna	Status	assigned => resolved
2024-10-26 06:02	unknownna	Fixed in Version	=> 3.2
2024-10-26 06:02	unknownna	Resolution	reopened => fixed

Relationships