Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004072DoomseekerUIpublic2022-12-31 02:302023-02-19 14:14
ReporterWubTheCaptain 
Assigned ToZalewa 
PrioritylowSeveritytweakReproducibilitysometimes
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.3.3 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004072: Ambiguous "Clear" button Create Game
DescriptionThe left-aligned "Clear" button in Create Game window is meant to clear the "Additional WADs and files" list, but it could be misunderstood for a reset button to clear all fields in the window (e.g. server name). If the WAD list is empty when the user presses the button for the first time in their life ever, the user may misunderstand that the button is functionally broken and does nothing ever.
There's no tooltip on hover to explain what the button does.
Steps To ReproduceCreate game (Ctrl + S). Fill in a server name, make sure the additional WADs and files list is empty. Press "Clear". Nothing happens (it would clear the additional WADs list in this case).
Additional Information
$ git describe --tags
1.3.3-111-gc21f2267

Source:'https://bitbucket.org/Doomseeker/doomseeker/src/c21f2267f91b8041e3d2f60d32ad0e3d1ff2219e [^]'
Attached Filespng file icon 2022-12-31-022439_maim.png [^] (54,672 bytes) 2022-12-31 02:30


jpg file icon ds_2022-12-31-1149_creategame.jpg [^] (85,365 bytes) 2022-12-31 10:49


png file icon ds-20230115-left-align-buttons.png [^] (5,729 bytes) 2023-01-15 22:22

- Relationships

-  Notes
User avatar (0022595)
WubTheCaptain (reporter)
2022-12-31 03:30
edited on: 2022-12-31 03:30

 Honestly, I had to ask: Does this "Clear" button even need to exist as is? Pressing "Ctrl + A" in the list selects all the list items, so does click the topmost list item + Shift-click the lowest one, then remove. The only thing missing is that right clicking the list doesn't present an option to select all list items.
If something else, I'd much rather prefer a full "Reset" button in the very bottom left that resets everything in the window to default, fresh values.
User avatar (0022596)
WubTheCaptain (reporter)
2022-12-31 03:32

 Heck, you can even mouse click-drag in the empty space of the list to select multiple WADS/files with a mouse.
User avatar (0022597)
WubTheCaptain (reporter)
2022-12-31 03:38
edited on: 2022-12-31 03:40

 If the existing "Clear" button should continue to exist, sure, but I'd like to have the whole additional files widget grouped on a darker background (like the Rules tab does) please.
User avatar (0022603)
WubTheCaptain (reporter)
2022-12-31 04:21

 Related to 0004078, caused me (an user) to misunderstand what "Clear" buttons generally do. One clears textboxes, another doesn't.
User avatar (0022608)
Zalewa (developer)
2022-12-31 10:54

 I altered the layout so that the buttons pertaining this list are laid out vertically:'https://bitbucket.org/Doomseeker/doomseeker/commits/5c9f5729c7c672670c0e357feb83e83194b8a016 [^]'
See: ds_2022-12-31-1149_creategame.jpg

Quote from WubTheCaptain
I'd like to have the whole additional files widget grouped on a darker background (like the Rules tab does)

The darker background depends on the OS theme. Windows 10 doesn't do that.

The elements in the Rules tab are placed inside a group box. I first tried to do the same here, but the group box requires some padding to look fine, and this extra padding was squashing the list too much. It didn't look good. Laying out the buttons vertically to the side of the list should achieve the same grouping effect without stealing the precious real estate.

I've also made the list respond to the delete, minus and plus keyboard keys.
User avatar (0022653)
Zalewa (developer)
2023-01-05 12:22

 Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test if the buttons are fine now.
User avatar (0022701)
Zalewa (developer)
2023-01-15 22:24

 I had to remove the forced left text-align of the buttons because it was producing really awkward-looking buttons in some themes (see KDE theme in ds-20230115-left-align-buttons.png, Mate theme was even worse).

'https://bitbucket.org/Doomseeker/doomseeker/commits/98bc2e929518c8a012334faab777a2c2a8e59b79 [^]'

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2022-12-31 02:30 WubTheCaptain New Issue
2022-12-31 02:30 WubTheCaptain File Added: 2022-12-31-022439_maim.png
2022-12-31 03:30 WubTheCaptain Note Added: 0022595
2022-12-31 03:30 WubTheCaptain Note Edited: 0022595 View Revisions
2022-12-31 03:32 WubTheCaptain Note Added: 0022596
2022-12-31 03:38 WubTheCaptain Note Added: 0022597
2022-12-31 03:38 WubTheCaptain Note Edited: 0022597 View Revisions
2022-12-31 03:40 WubTheCaptain Note Edited: 0022597 View Revisions
2022-12-31 04:21 WubTheCaptain Note Added: 0022603
2022-12-31 10:49 Zalewa File Added: ds_2022-12-31-1149_creategame.jpg
2022-12-31 10:54 Zalewa Note Added: 0022608
2022-12-31 10:54 Zalewa Assigned To => Zalewa
2022-12-31 10:54 Zalewa Status new => needs review
2022-12-31 10:54 Zalewa Target Version => 1.4.0
2023-01-05 12:22 Zalewa Note Added: 0022653
2023-01-05 12:22 Zalewa Status needs review => needs testing
2023-01-15 22:22 Zalewa File Added: ds-20230115-left-align-buttons.png
2023-01-15 22:24 Zalewa Note Added: 0022701
2023-02-19 14:14 Zalewa Status needs testing => resolved
2023-02-19 14:14 Zalewa Fixed in Version => 1.4.0
2023-02-19 14:14 Zalewa Resolution open => fixed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker